Re: [asterisk-dev] [Code Review] 4573: trunk: Can't touch this

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4573/#review15030 --- So typical US-centric. The rest of the world has moved to Unico

Re: [asterisk-dev] [Code Review] 4573: trunk: Can't touch this

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4573/#review15029 --- Ship it! Do it. - Ashley Sanders On April 1, 2015, 2:59 p.m

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

Ashley Sanders has posted comments on this change. Change subject: Rewrite sip_attended_transfer test to stop failing. .. Patch Set 3: Code-Review+1 (2 comments) Very nice!!! Thanks for taking my (more reasonable) suggestions

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

Ashley Sanders has posted comments on this change. Change subject: Rewrite sip_attended_transfer test to stop failing. .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/19/2/tests/channels/SIP/sip_attended_transfer/a

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

Hello Mark Michelson, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/18 to look at the new patch set (#2). Change subject: stasis: set a channel variable on websocket disconnect error .. stas

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: (5 comments) https://gerrit.asterisk.org/#/c/18/1/tests/rest_api/applications/stas

Re: [asterisk-dev] [Code Review] 4572: RFC: Refactor Qualify and res_pjsip/endpt_send_request

> On April 1, 2015, 6:21 p.m., Mark Michelson wrote: > > As a concept, this feels like a suitable stop-gap solution. Better > > solutions would be alterations to PJSIP itself. Either > > > > 1) Make pjsip_endpt_send_request() not ignore the timeout parameter passed > > to it. > > 2) Make pjsip

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

Mark Michelson has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: Code-Review+1 (4 comments) I noticed that I gave the Code-Review a 0 last time. I

Re: [asterisk-dev] [Code Review] 4573: trunk: Can't touch this

> On April 1, 2015, 5:45 p.m., Mark Michelson wrote: > > http://www.tomscott.com/hammer/ I was looking for that earlier today. /me bookmarks - Matt --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.ast

Re: [asterisk-dev] [Code Review] 4572: RFC: Refactor Qualify and res_pjsip/endpt_send_request

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4572/#review15026 --- As a concept, this feels like a suitable stop-gap solution. Bet

Re: [asterisk-dev] [Code Review] 4556: dns: Add res_resolver_system module.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4556/ --- (Updated April 2, 2015, 12:01 a.m.) Status -- This change has been di

Re: [asterisk-dev] [Code Review] 4536: iax2_poke_noanswer expiration timer too short

> On April 1, 2015, 1:07 a.m., Matt Jordan wrote: > > trunk/channels/chan_iax2.c, line 12370 > > > > > > The usage of max_retries here feels arbitrary. I'm not against this > > being controlled more dynamically b

Re: [asterisk-dev] [Code Review] 4556: dns: Add res_resolver_system module.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4556/#review15024 --- In general, I'm going to say that while I understand that this

Re: [asterisk-dev] [Code Review] 4571: Add usegmtime option to cel_pgsql

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4571/#review15023 --- Just commenting to say that aside from what Matt has already po

[asterisk-dev] Change in testsuite[master]: rest_api/channels/snoop_spy: Stop test on bridge destruction

Joshua Colp has posted comments on this change. Change subject: rest_api/channels/snoop_spy: Stop test on bridge destruction .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.asterisk.org/21 To unsubscribe, visit htt

[asterisk-dev] Change in testsuite[master]: rest_api/channels/snoop_spy: Stop test on bridge destruction

Joshua Colp has submitted this change and it was merged. Change subject: rest_api/channels/snoop_spy: Stop test on bridge destruction .. rest_api/channels/snoop_spy: Stop test on bridge destruction The snoop_spy test is current

[asterisk-dev] Change in testsuite[master]: rest_api/channels/snoop_spy: Stop test on bridge destruction

Joshua Colp has posted comments on this change. Change subject: rest_api/channels/snoop_spy: Stop test on bridge destruction .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.asterisk.org/21 To unsubscribe, visit

Re: [asterisk-dev] [Code Review] 4573: trunk: Can't touch this

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4573/#review15022 --- http://www.tomscott.com/hammer/ - Mark Michelson On April 1,

Re: [asterisk-dev] [Code Review] 4574: pjsip: resolve compatibility problem with ast_sip_session struct

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4574/#review15021 --- Ship it! Ship It! - Mark Michelson On April 1, 2015, 9:20 p

[asterisk-dev] Change in testsuite[master]: rest_api/channels/snoop_spy: Stop test on bridge destruction

Mark Michelson has posted comments on this change. Change subject: rest_api/channels/snoop_spy: Stop test on bridge destruction .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/21 To unsubscribe, vis

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

Mark Michelson has uploaded a new patch set (#3). Change subject: Rewrite sip_attended_transfer test to stop failing. .. Rewrite sip_attended_transfer test to stop failing. The sip_attended_transfer test has been bouncing for a

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

Hello Ashley Sanders, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/19 to look at the new patch set (#3). Change subject: Rewrite sip_attended_transfer test to stop failing. .. Rewrite sip_a

Re: [asterisk-dev] Problems Building 13.x with GCC 5.0

On Wed, Apr 1, 2015 at 4:15 PM, Jeffrey Ollie wrote: > On Wed, Apr 1, 2015 at 4:41 PM, Matthew Jordan wrote: > >> On Wed, Apr 1, 2015 at 4:37 PM, Jeffrey Ollie wrote: >> > On Wed, Apr 1, 2015 at 4:13 PM, Scott Griepentrog < >> sgriepent...@digium.com> >> > wrote: >> >> >> >> Have you submitted

Re: [asterisk-dev] Problems Building 13.x with GCC 5.0

On Wed, Apr 1, 2015 at 4:41 PM, Matthew Jordan wrote: > On Wed, Apr 1, 2015 at 4:37 PM, Jeffrey Ollie wrote: > > On Wed, Apr 1, 2015 at 4:13 PM, Scott Griepentrog < > sgriepent...@digium.com> > > wrote: > >> > >> Have you submitted a ticket on http://issues.asterisk.org ? > > > > https://issues

Re: [asterisk-dev] Problems Building 13.x with GCC 5.0

On Wed, Apr 1, 2015 at 4:37 PM, Jeffrey Ollie wrote: > On Wed, Apr 1, 2015 at 4:13 PM, Scott Griepentrog > wrote: >> >> Have you submitted a ticket on http://issues.asterisk.org ? > > > https://issues.asterisk.org/jira/browse/ASTERISK-24932 > > -- > Jeff Ollie > Thanks Jeff. What version of Fe

Re: [asterisk-dev] Problems Building 13.x with GCC 5.0

On Wed, Apr 1, 2015 at 4:13 PM, Scott Griepentrog wrote: > Have you submitted a ticket on http://issues.asterisk.org ? > https://issues.asterisk.org/jira/browse/ASTERISK-24932 -- Jeff Ollie -- _ -- Bandwidth and Colocation P

Re: [asterisk-dev] [Code Review] 4574: pjsip: resolve compatibility problem with ast_sip_session struct

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4574/ --- (Updated April 1, 2015, 4:20 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] Problems Building 13.x with GCC 5.0

Have you submitted a ticket on http://issues.asterisk.org ? On Wed, Apr 1, 2015 at 2:50 PM, Jeffrey Ollie wrote: > Fedora recently switched to GCC 5.0 as the default C compiler, and > Asterisk 13.X stopped building. It was first brought to my attention with > 13.1.1, but 13.3.0 won't compile ei

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: (6 comments) Responses to most of the review feedback from Mark Michelson. https:

[asterisk-dev] [Code Review] 4574: pjsip: resolve compatibility problem with ast_sip_session struct

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4574/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4573: trunk: Can't touch this

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4573/#review15020 --- I don't think the ASCII art is very representative... Hammer pa

[asterisk-dev] [Code Review] 4573: trunk: Can't touch this

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4573/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] Problems Building 13.x with GCC 5.0

Fedora recently switched to GCC 5.0 as the default C compiler, and Asterisk 13.X stopped building. It was first brought to my attention with 13.1.1, but 13.3.0 won't compile either. https://bugzilla.redhat.com/show_bug.cgi?id=1195304 https://kojipkgs.fedoraproject.org//work/tasks/4722/9394722/bui

[asterisk-dev] Asterisk 13.3.0 Now Available

The Asterisk Development Team has announced the release of Asterisk 13.3.0. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 13.3.0 resolves several issues reported by the community and would have not been possible wit

[asterisk-dev] Asterisk 11.17.0 Now Available

The Asterisk Development Team has announced the release of Asterisk 11.17.0. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 11.17.0 resolves several issues reported by the community and would have not been possible w

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

Matt Jordan has posted comments on this change. Change subject: Memory Debugging Improvements .. Patch Set 3: Barring Ashley's finding, this looks good to go. Once that patch set is up, I'll +1 it. -- To view, visit https://

[asterisk-dev] Change in testsuite[master]: rest_api/channels/snoop_spy: Stop test on bridge destruction

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/21 Change subject: rest_api/channels/snoop_spy: Stop test on bridge destruction .. rest_api/channels/snoop_spy: Stop test on bridge destruction The

Re: [asterisk-dev] [Code Review] 4528: dns: Add SRV recording parsing, sorting/weighting, and unit tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4528/ --- (Updated April 1, 2015, 11:28 a.m.) Status -- This change has been ma

Re: [asterisk-dev] running pjsip testsuite

Hi Everyone, Sorry for all the questions. Well I managed to understand the 488 issue - I had to add some codec capabilities. Now the test works but only if I setup the dtmfmode to rfc4733. If I set it to inband it fails - the Read on the receiver side doesn't receive DTMF. The following is the sc

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/ --- (Updated April 1, 2015, 2:51 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

> On March 31, 2015, 3:25 p.m., Matt Jordan wrote: > > /team/group/dns/main/dns_naptr.c, lines 420-421 > > > > > > The asserts here are appropriate. > > > > However, if there is an error in the record, such

Re: [asterisk-dev] running pjsip testsuite

Hi everyone, I am still having problems with the testsuite. I made a simple scenario that originates a call from the ami to a local channel, an then dials through a PJSIP endpoint to another PJSIP endpoint. The issue I am having is when I dial the other endpoint I receive 488 not acceptable here.