Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-30 Thread Corey Farrell
/func_jitterbuffer.c. Diffs (updated) - /branches/11/funcs/func_jitterbuffer.c 426804 Diff: https://reviewboard.asterisk.org/r/4128/diff/ Testing --- tests/funcs/func_jitterbuffer against 13 no longer leaks. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-30 Thread Corey Farrell
/ Testing --- tests/funcs/func_jitterbuffer against 13 no longer leaks. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 4094: Install refcounter.py to /var/lib/asterisk/scripts

2014-10-30 Thread Corey Farrell
/asterisk/scripts when REF_DEBUG is enabled. Diffs - /branches/1.8/contrib/Makefile PRE-CREATION /branches/1.8/Makefile 425404 Diff: https://reviewboard.asterisk.org/r/4094/diff/ Testing --- make install and make uninstall with and without REF_DEBUG enabled. Thanks, Corey

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-30 Thread Corey Farrell
, passes with. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] Fwd: [asterisk-commits] mjordan: testsuite/asterisk/trunk r5811 - in /asterisk/trunk/tests/fax/pjsip:...

2014-10-30 Thread Corey Farrell
, Matthew Jordan mjor...@digium.com wrote: On Thu, Oct 30, 2014 at 6:36 PM, Corey Farrell g...@cfware.com wrote: I'm confused about how this can be? Unless I'm missing something a module dependency doesn't effect how the test runs, just if it runs. If chan_sip is not required then shouldn't we

[asterisk-dev] [Code Review] 4138: main/app.c, app_voicemail: Fix ast_writestream leaks

2014-10-30 Thread Corey Farrell
Diff: https://reviewboard.asterisk.org/r/4138/diff/ Testing --- tests/apps/voicemail/check_voicemail_forward_with_prepend/ no longer leaks. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-29 Thread Corey Farrell
/asterisk/trunk/run-local 5803 /asterisk/trunk/contrib/scripts/refleaks-summary PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4038/diff/ Testing --- Ran against tests/channels/SIP/route on Asterisk 11 with and without r4037 applied. Test fails without, passes with. Thanks, Corey

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-29 Thread Corey Farrell
/asterisk/trunk/contrib/scripts/refleaks-summary PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4038/diff/ Testing --- Ran against tests/channels/SIP/route on Asterisk 11 with and without r4037 applied. Test fails without, passes with. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-29 Thread Corey Farrell
be something to do with our running 'restart'. At a certain point the CLI is not available, so fullybooted_run fails without the delay (or with 1 second delay). Maybe it could be decreased to 2 seconds but that would make the test more sensitive. On Oct. 29, 2014, 5:18 a.m., Corey Farrell

Re: [asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-29 Thread Corey Farrell
/dialplan_reload/run-test 5803 Diff: https://reviewboard.asterisk.org/r/4122/diff/ Testing --- Yes Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4125: app_queue: fix a couple leaks to struct call_queue in set_member_value

2014-10-29 Thread Corey Farrell
no longer leaks any references (verifies first added queue_unref). I'm unsure if the second added queue_unref has been tested, but seems like it is needed. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4112: testsuite: Make tests/fax/pjsip/* depend on chan_pjsip

2014-10-28 Thread Corey Farrell
was compiled without pjproject. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4113: func_cdr: CDR_PROP leaks payload

2014-10-28 Thread Corey Farrell
tests and this fix is very clear. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4111: app_queue: ao2_iterator not destroyed, causing leak

2014-10-28 Thread Corey Farrell
-members, causing a reference leak. Diffs - /branches/11/apps/app_queue.c 426232 Diff: https://reviewboard.asterisk.org/r/4111/diff/ Testing --- Testsuite against 13, compile test/visual inspection for 11. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4115: res_fax: fax gateway frames leak

2014-10-28 Thread Corey Farrell
, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4121: testsuite: Close ARI websocket connections before stopping reactor

2014-10-28 Thread Corey Farrell
) - /asterisk/trunk/lib/python/asterisk/ari.py 5796 Diff: https://reviewboard.asterisk.org/r/4121/diff/ Testing --- Using r4038 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-28 Thread Corey Farrell
on Asterisk 11 with and without r4037 applied. Test fails without, passes with. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-28 Thread Corey Farrell
://reviewboard.asterisk.org/r/4122/diff/ Testing --- Yes Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

[asterisk-dev] [Code Review] 4124: audiohooks: Clean references to formats

2014-10-28 Thread Corey Farrell
/diff/ Testing --- Yes Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

[asterisk-dev] [Code Review] 4125: app_queue: fix a couple leaks to struct call_queue in set_member_value

2014-10-28 Thread Corey Farrell
added queue_unref has been tested, but seems like it is needed. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

[asterisk-dev] [Code Review] 4112: testsuite: Make tests/fax/pjsip/* depend on chan_pjsip

2014-10-27 Thread Corey Farrell
/directmedia_reinvite_t38/test-config.yaml 5649 Diff: https://reviewboard.asterisk.org/r/4112/diff/ Testing --- Verified these tests no longer attempt to run when Asterisk was compiled without pjproject. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 4113: func_cdr: CDR_PROP leaks payload

2014-10-27 Thread Corey Farrell
/funcs/func_cdr.c 426139 Diff: https://reviewboard.asterisk.org/r/4113/diff/ Testing --- Visual inspection only - my system is busy running other tests and this fix is very clear. Thanks, Corey Farrell -- _ -- Bandwidth

[asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

2014-10-27 Thread Corey Farrell
/ Testing --- Manual test using https://github.com/elessard1/asterisk-lab/blob/master/examples/lab_stringfields_leak.c to verify that old pools are now freed. Full testsuite against Asterisk 13. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4115: res_fax: fax gateway frames leak

2014-10-27 Thread Corey Farrell
by one of the instances of Asterisk. Diffs (updated) - /branches/11/res/res_fax.c 426232 Diff: https://reviewboard.asterisk.org/r/4115/diff/ Testing --- Verified tests/fax/sip/gateway_g711_t38 no longer leaks on 11 and 13. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 4110: manager: acl_change_sub leaks

2014-10-26 Thread Corey Farrell
, verified tests/manager/acl-login no longer leaks the reference. Visually inspected code and compiled for 12 to verify the issue applied to that version. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http

[asterisk-dev] [Code Review] 4111: app_queue: ao2_iterator not destroyed, causing leak

2014-10-26 Thread Corey Farrell
/ Testing --- Testsuite against 13, compile test/visual inspection for 11. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 4108: Weak References

2014-10-22 Thread Corey Farrell
, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4108: Weak References

2014-10-22 Thread Corey Farrell
that this cannot race, since any potential for a race would be due to very exact timing. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 4094: Install refcounter.py to /var/lib/asterisk/scripts

2014-10-17 Thread Corey Farrell
: https://reviewboard.asterisk.org/r/4094/diff/ Testing --- make install and make uninstall with and without REF_DEBUG enabled. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-17 Thread Corey Farrell
/trunk/runtests.py 5655 /asterisk/trunk/run-local 5655 Diff: https://reviewboard.asterisk.org/r/4038/diff/ Testing --- Ran against tests/channels/SIP/route on Asterisk 11 with and without r4037 applied. Test fails without, passes with. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4091: build: Force -fsigned-char on platforms where the default for char is unsigned.

2014-10-17 Thread Corey Farrell
/4091/#comment24091 Is it appropriate for us to use $ac_cv_c_char_unsigned? I raise this question since the variable is not documented. Might be better to just directly test ((char) -1) 0 the same way AC_C_CHAR_UNSIGNED does, except to just set CONFIG_SIGNED_CHAR. - Corey Farrell

Re: [asterisk-dev] [Code Review] 4091: build: Force -fsigned-char on platforms where the default for char is unsigned.

2014-10-17 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4091/#review13572 --- Ship it! Ship It! - Corey Farrell On Oct. 17, 2014, 11:59

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

2014-10-17 Thread Corey Farrell
shouldn't continue. - Corey Farrell On Oct. 16, 2014, 5:23 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090

Re: [asterisk-dev] [Code Review] 4048: res_fax: Fix fax handler module reference leak

2014-10-14 Thread Corey Farrell
://reviewboard.asterisk.org/r/4048/diff/ Testing --- In testsuite against 11 verified that res_fax_spandsp now unloads in tests that previously leaked references to the module. Thanks, Corey Farrell -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4049: res_fax: Fix reference leak caused by gateway sessions being added to faxregistry.container twice

2014-10-14 Thread Corey Farrell
- /branches/1.8/res/res_fax.c 424175 Diff: https://reviewboard.asterisk.org/r/4049/diff/ Testing --- Verified this resolves the leak in 11 and 12. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-10 Thread Corey Farrell
://reviewboard.asterisk.org/r/4038/diff/ Testing --- Ran against tests/channels/SIP/route on Asterisk 11 with and without r4037 applied. Test fails without, passes with. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-10 Thread Corey Farrell
/r/4038/#comment24009 Per IRC discussion with mjordan this is not always the correct location of refcounter.py. Update will follow to find refcounter.py and skip processing if it's not found. - Corey Farrell On Oct. 10, 2014, 12:44 p.m., Corey Farrell wrote

Re: [asterisk-dev] [Code Review] 4049: res_fax: Fix reference leak caused by gateway sessions being added to faxregistry.container twice

2014-10-07 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4049/#review13461 --- On Oct. 5, 2014, 11:10 p.m., Corey Farrell wrote

Re: [asterisk-dev] [Code Review] 4049: res_fax: Fix reference leak caused by gateway sessions being added to faxregistry.container twice

2014-10-07 Thread Corey Farrell
/r/4049/diff/ Testing --- Verified this resolves the leak in 11 and 12. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 4047: astobj2: ao2_callback with OBJ_MULTIPLE causes REF_DEBUG to report false leaks

2014-10-07 Thread Corey Farrell
with ao2_container_alloc_options. Diffs - /branches/1.8/main/astobj2.c 424175 Diff: https://reviewboard.asterisk.org/r/4047/diff/ Testing --- Against 11 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 4048: res_fax: Fix fax handler module reference leak

2014-10-06 Thread Corey Farrell
/4048/#review13458 --- On Oct. 5, 2014, 4:34 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4048

Re: [asterisk-dev] [Code Review] 4048: res_fax: Fix fax handler module reference leak

2014-10-06 Thread Corey Farrell
--- In testsuite against 11 verified that res_fax_spandsp now unloads in tests that previously leaked references to the module. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

[asterisk-dev] [Code Review] 4047: astobj2: ao2_callback with OBJ_MULTIPLE causes REF_DEBUG to report false leaks

2014-10-05 Thread Corey Farrell
/ Testing --- Against 11 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

[asterisk-dev] [Code Review] 4048: res_fax: Fix fax handler module reference leak

2014-10-05 Thread Corey Farrell
that previously leaked references to the module. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

[asterisk-dev] [Code Review] 4049: res_fax: Fix reference leak caused by gateway sessions being added to faxregistry.container twice

2014-10-05 Thread Corey Farrell
in 11 and 12. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 4043: chan_motif: Release format capabilities on module load error

2014-10-04 Thread Corey Farrell
driver are released during a load error. Diffs - /branches/11/channels/chan_motif.c 424175 Diff: https://reviewboard.asterisk.org/r/4043/diff/ Testing --- Verified with REF_DEBUG using the default config (which produces a load error). Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4045: chan_sip: process_sdp leaks on an error path

2014-10-04 Thread Corey Farrell
- /branches/11/channels/chan_sip.c 424335 Diff: https://reviewboard.asterisk.org/r/4045/diff/ Testing --- Yes Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4037: Release AMI connections on shutdown

2014-10-04 Thread Corey Farrell
. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4041: features.c: Fix lingering channel ref while Bridge() application is active.

2014-10-03 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4041/#review13448 --- Ship it! Ship It! - Corey Farrell On Oct. 1, 2014, 4:49

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-03 Thread Corey Farrell
it be applied to that version as well? - Corey Farrell On Oct. 1, 2014, 11:43 a.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039

Re: [asterisk-dev] [Code Review] 3957: Update commit_msg.py To Work With A Web Proxy, Follow New Commit Msg Format, Prompt For License

2014-10-03 Thread Corey Farrell
/#comment23978 It appears we can retrieve the license number via REST: https://issues.asterisk.org/jira/rest/api/2/attachment/{id} It is available as properties.license. - Corey Farrell On Aug. 28, 2014, 4:56 p.m., Michael Young wrote

Re: [asterisk-dev] [Code Review] 4037: Release AMI connections on shutdown

2014-10-03 Thread Corey Farrell
424175 Diff: https://reviewboard.asterisk.org/r/4037/diff/ Testing --- Tested with tests/channels/SIP/route. Verified the AMI session is leaked without this patch, released with this patch. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4043: chan_motif: Release format capabilities on module load error

2014-10-03 Thread Corey Farrell
(updated) - /branches/11/channels/chan_motif.c 424175 Diff: https://reviewboard.asterisk.org/r/4043/diff/ Testing --- Verified with REF_DEBUG using the default config (which produces a load error). Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4037: Release AMI connections on shutdown

2014-10-03 Thread Corey Farrell
proposing this fix for 11+. Diffs (updated) - /branches/11/main/manager.c 424175 Diff: https://reviewboard.asterisk.org/r/4037/diff/ Testing --- Tested with tests/channels/SIP/route. Verified the AMI session is leaked without this patch, released with this patch. Thanks, Corey

Re: [asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-02 Thread Corey Farrell
I don't have access. - Corey Farrell On Oct. 1, 2014, 5:14 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4042

Re: [asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-02 Thread Corey Farrell
. This change provides that error message. Diffs - /Makefile.in 884 Diff: https://reviewboard.asterisk.org/r/4042/diff/ Testing --- Yes Note this fix unfortunately will not protect anyone until after they re-run configure once to update Makefile from this change. Thanks, Corey

[asterisk-dev] [Code Review] 4037: Release AMI connections on shutdown

2014-10-01 Thread Corey Farrell
/route. Verified the AMI session is leaked without this patch, released with this patch. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

[asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-01 Thread Corey Farrell
tests/channels/SIP/route on Asterisk 11 with and without r4037 applied. Test fails without, passes with. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

Re: [asterisk-dev] [Code Review] 4026: res_hep leaks reference to configuration

2014-10-01 Thread Corey Farrell
to data in global_data, but doesn't release the reference created by the original allocation. Diffs - /branches/12/res/res_hep.c 424090 Diff: https://reviewboard.asterisk.org/r/4026/diff/ Testing --- Verified data no longer leaks. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-01 Thread Corey Farrell
--- Yes Note this fix unfortunately will not protect anyone until after they re-run configure once to update Makefile from this change. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-01 Thread Corey Farrell
/#review13432 --- On Oct. 1, 2014, 4:59 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4042

Re: [asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-01 Thread Corey Farrell
://reviewboard.asterisk.org/r/4042/diff/ Testing --- Yes Note this fix unfortunately will not protect anyone until after they re-run configure once to update Makefile from this change. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 4043: chan_motif: Release format capabilities on module load error

2014-10-01 Thread Corey Farrell
/4043/diff/ Testing --- Verified with REF_DEBUG using the default config (which produces a load error). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-01 Thread Corey Farrell
/trunk/run-local 5655 Diff: https://reviewboard.asterisk.org/r/4038/diff/ Testing --- Ran against tests/channels/SIP/route on Asterisk 11 with and without r4037 applied. Test fails without, passes with. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 4045: chan_sip: process_sdp leaks on an error path

2014-10-01 Thread Corey Farrell
to goto process_sdp_cleanup it causes these tests to fail, that is why I created the label process_sdp_cleanup_b to skip offered_media_list_destroy. Diffs - /branches/11/channels/chan_sip.c 424335 Diff: https://reviewboard.asterisk.org/r/4045/diff/ Testing --- Yes Thanks, Corey

[asterisk-dev] [Code Review] 4026: res_hep leaks reference to configuration

2014-09-28 Thread Corey Farrell
Diff: https://reviewboard.asterisk.org/r/4026/diff/ Testing --- Verified data no longer leaks. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4012: testsuite: Allow multiple -t options to be passed.

2014-09-27 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4012/#review13392 --- Ship it! Ship It! - Corey Farrell On Sept. 26, 2014, 9:28

Re: [asterisk-dev] [Code Review] 4023: Allow passing options and command to MixMonitor when recording in ConfBridge

2014-09-26 Thread Corey Farrell
arbitrary commands on the Asterisk server (security risk). The ability to SetVar CONFBRIDGE(bridge,record_command) from AMI would need to be blocked when asterisk.conf has live_dangerously=no. - Corey Farrell On Sept. 26, 2014, 12:23 a.m., gareth wrote

Re: [asterisk-dev] [Code Review] 4012: testsuite: Allow multiple -t options to be passed.

2014-09-26 Thread Corey Farrell
. This would include situations where -t is specified multiple times, or for '-t channels'. I realize this was an issue in the past (for example when using -t channels/), but might as well fix while you're here. - Corey Farrell On Sept. 22, 2014, 5:01 a.m., wdoekes wrote

Re: [asterisk-dev] [Code Review] 3972: Only install dahdi_span_config_hook if DAHDI is enabled

2014-09-17 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3972/#review13319 --- Ship it! Ship It! - Corey Farrell On Sept. 4, 2014, 2:35

Re: [asterisk-dev] [Code Review] 3971: astobj2.c/refcounter.py: Fix to deal with invalid object refs.

2014-09-15 Thread Corey Farrell
://reviewboard.asterisk.org/r/3971/#comment23786 This can be optimized if invalid objects are given curcount == -1, that way it wouldn't have to do substring comparison again. - Corey Farrell On Sept. 2, 2014, 10:22 p.m., rmudgett wrote

Re: [asterisk-dev] [Code Review] 3969: Manager: FullyBooted events are sent to AMI users that log in even if they don't have system level read permission.

2014-09-03 Thread Corey Farrell
stuff. - Corey Farrell On Sept. 3, 2014, 6:15 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3969

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-08-11 Thread Corey Farrell
when I have time to work on this. - Corey Farrell On Aug. 1, 2014, 6:22 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3811

Re: [asterisk-dev] [Code Review] 3862: testsuite: run-local creates broken symlinks for tests

2014-08-07 Thread Corey Farrell
/ total 0 lrwxrwxrwx 1 cfarrell cfarrell 38 Jul 25 21:57 path - ../../8b45633c808b7fa365b7fd61078fc1a2 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] managerEvent XML documentation

2014-08-06 Thread Corey Farrell
, 2014 at 12:20 PM, Matthew Jordan mjor...@digium.com wrote: On Fri, Aug 1, 2014 at 5:47 PM, Corey Farrell g...@cfware.com wrote: Hello everyone, As part of r3811 I'm fixing build_tools/get_documentation so it picks up every /*** DOCUMENTATION ***/ block, instead of just the first from each file

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-08-06 Thread Corey Farrell
On Aug. 1, 2014, 6:29 p.m., Corey Farrell wrote: /trunk/res/res_manager_channels.c, lines 253-261 https://reviewboard.asterisk.org/r/3811/diff/2/?file=66030#file66030line253 channel_state_change has a comment stating that Newchannel, Newstate and Hangup events are mutually

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-08-01 Thread Corey Farrell
events from res_manager_channels.c. Events from other files were not tested, though res_manager_channels.c was the most likely to cause problems. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-08-01 Thread Corey Farrell
channel_state_change has a comment stating that Newchannel, Newstate and Hangup events are mutually exclusive. I think this may also apply to Newexten, NewCallerID and NewAccountcode. If so this should be moved back to stasis_channels.c as a .to_ami callback. - Corey Farrell On Aug. 1, 2014, 6:22 p.m

[asterisk-dev] managerEvent XML documentation

2014-08-01 Thread Corey Farrell
Hello everyone, As part of r3811 I'm fixing build_tools/get_documentation so it picks up every /*** DOCUMENTATION ***/ block, instead of just the first from each file. As a side-effect this picked up some validation error's that were previously unnoticed. One of them is in main/logger.c, the

Re: [asterisk-dev] [Code Review] 3862: testsuite: run-local creates broken symlinks for tests

2014-07-31 Thread Corey Farrell
astroot/tmp/channels/SIP/ total 0 lrwxrwxrwx 1 cfarrell cfarrell 38 Jul 25 21:57 path - ../../8b45633c808b7fa365b7fd61078fc1a2 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3884: testsuite: fail sipp test if sipp not installed

2014-07-31 Thread Corey Farrell
://reviewboard.asterisk.org/r/3884/#comment23334 I'm guessing this should go away, or be a info/debug message instead of error. - Corey Farrell On July 31, 2014, 3:36 p.m., Scott Griepentrog wrote: --- This is an automatically generated e

Re: [asterisk-dev] [Code Review] 3884: testsuite: fail sipp test if sipp not installed

2014-07-31 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3884/#review12951 --- Ship it! Ship It! - Corey Farrell On July 31, 2014, 3:41

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-07-31 Thread Corey Farrell
other than AMI? Could there be? I think that, given the options, the way Corey is doing this is the way to go if we want to make AMI messages for a given message type on a channel topic provided by a loadable module. Corey Farrell wrote: I'm against use of OPTIONAL_API

[asterisk-dev] [Code Review] 3887: Fix build_tools/get_documentation awk script so it doesn't quit after the first documentation block

2014-07-31 Thread Corey Farrell
). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3887: Fix build_tools/get_documentation awk script so it doesn't quit after the first documentation block

2014-07-31 Thread Corey Farrell
stasis_channels.c after running 'make doc/core-en_US.xml' (tested against trunk). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-07-30 Thread Corey Farrell
other than AMI? Could there be? I think that, given the options, the way Corey is doing this is the way to go if we want to make AMI messages for a given message type on a channel topic provided by a loadable module. Corey Farrell wrote: I'm against use of OPTIONAL_API

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-07-30 Thread Corey Farrell
was moved to core but still the same code. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

[asterisk-dev] [Code Review] 3862: testsuite: run-local creates broken symlinks for tests

2014-07-25 Thread Corey Farrell
://reviewboard.asterisk.org/r/3862/diff/ Testing --- ./run-local run -t tests/channels/SIP/path; ./run-local run -t tests/predial Both tests resulted in symbolic links from astroot/tmp/testname to the md5 folder. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

2014-07-24 Thread Corey Farrell
- /trunk/channels/sip/include/sip.h 419127 /trunk/channels/chan_sip.c 419127 Diff: https://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3818: Deprecate astobj.h

2014-07-24 Thread Corey Farrell
.h instead. After 3758 and 3759 are committed the only thing that will still use astobj.h is netsock.c, and that is already deprecated. Diffs - /trunk/include/asterisk/astobj.h 418788 Diff: https://reviewboard.asterisk.org/r/3818/diff/ Testing --- Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 3834: chan_sip: sip_subscribe_mwi_destroy should not call sip_destroy

2014-07-24 Thread Corey Farrell
/chan_sip.c 418992 Diff: https://reviewboard.asterisk.org/r/3834/diff/ Testing --- None Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

2014-07-22 Thread Corey Farrell
://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

2014-07-22 Thread Corey Farrell
://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

2014-07-22 Thread Corey Farrell
://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3831: res_fax: unregister manager actions on unload

2014-07-22 Thread Corey Farrell
/ Testing --- Verified that tests/manager/originate no longer produces REF_DEBUG leaks. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

2014-07-22 Thread Corey Farrell
to use standard list or vector macro's prior to release of 13. - Corey Farrell On July 22, 2014, 7:01 p.m., opticron wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3812

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-21 Thread Corey Farrell
://reviewboard.asterisk.org/r/3758/diff/ Testing --- Compile only (I do not have SMDI hardware). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-21 Thread Corey Farrell
/chan_dahdi.c 418788 /trunk/apps/app_voicemail.c 418788 Diff: https://reviewboard.asterisk.org/r/3758/diff/ Testing --- Compile only (I do not have SMDI hardware). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

2014-07-21 Thread Corey Farrell
419043 Diff: https://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-07-21 Thread Corey Farrell
for all effected events, but does verify many events from res_manager_channels.c. Events from other files were not tested, though res_manager_channels.c was the most likely to cause problems. Thanks, Corey Farrell

<    1   2   3   4   5   6   7   >