Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

when I have time to work on this. - Corey Farrell On Aug. 1, 2014, 6:22 p.m., Corey Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asteris

Re: [asterisk-dev] [Code Review] 3862: testsuite: run-local creates broken symlinks for tests

total 0 lrwxrwxrwx 1 cfarrell cfarrell 38 Jul 25 21:57 path -> ../../8b45633c808b7fa365b7fd61078fc1a2 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

> On Aug. 1, 2014, 6:29 p.m., Corey Farrell wrote: > > /trunk/res/res_manager_channels.c, lines 253-261 > > <https://reviewboard.asterisk.org/r/3811/diff/2/?file=66030#file66030line253> > > > > channel_state_change has a comment stating that Newchannel, Ne

Re: [asterisk-dev] managerEvent XML documentation

ath is used it would be automatic). On Wed, Aug 6, 2014 at 12:20 PM, Matthew Jordan wrote: > On Fri, Aug 1, 2014 at 5:47 PM, Corey Farrell wrote: >> >> Hello everyone, >> >> As part of r3811 I'm fixing build_tools/get_documentation so it picks >> up ever

[asterisk-dev] managerEvent XML documentation

Hello everyone, As part of r3811 I'm fixing build_tools/get_documentation so it picks up every /*** DOCUMENTATION ***/ block, instead of just the first from each file. As a side-effect this picked up some validation error's that were previously unnoticed. One of them is in main/logger.c, the Log

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

.org/r/3811/#comment23352> channel_state_change has a comment stating that Newchannel, Newstate and Hangup events are mutually exclusive. I think this may also apply to Newexten, NewCallerID and NewAccountcode. If so this should be moved back to stasis_channels.c as a .to_ami callback. - Corey

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

verify many events from res_manager_channels.c. Events from other files were not tested, though res_manager_channels.c was the most likely to cause problems. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provid

Re: [asterisk-dev] [Code Review] 3887: Fix build_tools/get_documentation awk script so it doesn't quit after the first documentation block

ation from stasis_channels.c after running 'make doc/core-en_US.xml' (tested against trunk). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing li

[asterisk-dev] [Code Review] 3887: Fix build_tools/get_documentation awk script so it doesn't quit after the first documentation block

tested against trunk). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

; the res_manager_channels module should be very small: it should set up a > > forwarding relationship between the channel topics and the manager topic > > and be done. > > Corey Farrell wrote: > (1) I couldn't determine what causes the current code (stasis_channel

Re: [asterisk-dev] [Code Review] 3884: testsuite: fail sipp test if sipp not installed

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3884/#review12951 --- Ship it! Ship It! - Corey Farrell On July 31, 2014, 3:41

Re: [asterisk-dev] [Code Review] 3884: testsuite: fail sipp test if sipp not installed

tps://reviewboard.asterisk.org/r/3884/#comment23334> I'm guessing this should go away, or be a info/debug message instead of error. - Corey Farrell On July 31, 2014, 3:36 p.m., Scott Griepentrog wrote: > > --- > This is an aut

Re: [asterisk-dev] [Code Review] 3862: testsuite: run-local creates broken symlinks for tests

ls -lh astroot/tmp/channels/SIP/ total 0 lrwxrwxrwx 1 cfarrell cfarrell 38 Jul 25 21:57 path -> ../../8b45633c808b7fa365b7fd61078fc1a2 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

itterbuffer code was moved to core but still the same code. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: htt

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

; the res_manager_channels module should be very small: it should set up a > > forwarding relationship between the channel topics and the manager topic > > and be done. > > Corey Farrell wrote: > (1) I couldn't determine what causes the current code (stasis_channel

[asterisk-dev] [Code Review] 3862: testsuite: run-local creates broken symlinks for tests

://reviewboard.asterisk.org/r/3862/diff/ Testing --- ./run-local run -t tests/channels/SIP/path; ./run-local run -t tests/predial Both tests resulted in symbolic links from astroot/tmp/ to the md5 folder. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 3834: chan_sip: sip_subscribe_mwi_destroy should not call sip_destroy

1.8/channels/chan_sip.c 418992 Diff: https://reviewboard.asterisk.org/r/3834/diff/ Testing --- None Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mai

Re: [asterisk-dev] [Code Review] 3818: Deprecate astobj.h

.h instead. After 3758 and 3759 are committed the only thing that will still use astobj.h is netsock.c, and that is already deprecated. Diffs - /trunk/include/asterisk/astobj.h 418788 Diff: https://reviewboard.asterisk.org/r/3818/diff/ Testing --- Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

- /trunk/channels/sip/include/sip.h 419127 /trunk/channels/chan_sip.c 419127 Diff: https://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

runk/include/asterisk/xmldoc.h <https://reviewboard.asterisk.org/r/3812/#comment23172> Same. - Corey Farrell On July 22, 2014, 10:42 p.m., opticron wrote: > > --- > This is an automatically generated e-mail. To rep

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

to use standard list or vector macro's prior to release of 13. - Corey Farrell On July 22, 2014, 7:01 p.m., opticron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.as

Re: [asterisk-dev] [Code Review] 3831: res_fax: unregister manager actions on unload

/ Testing --- Verified that tests/manager/originate no longer produces REF_DEBUG leaks. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

https://reviewboard.asterisk.org/r/3812/#comment23159> Tab between parameter name and description? trunk/main/xmldoc.c <https://reviewboard.asterisk.org/r/3812/#comment23161> Please remove _ast_ prefix. - Corey Farrell On July 18, 2014, 3:57 p.m., opticron wrote: > >

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

leak (not caused by this change). - Corey --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/#review12807 --- On July 22, 2014, 6:0

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 3834: chan_sip: sip_subscribe_mwi_destroy should not call sip_destroy

using mwi->call it can cause problems. This change uses dialog_unref instead, to balance the ref provided by sip_alloc(). Diffs - /branches/1.8/channels/chan_sip.c 418992 Diff: https://reviewboard.asterisk.org/r/3834/diff/ Testing --- None Thanks, C

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

/channels/chan_sip.c 419127 Diff: https://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

. Since ®1->name == reg1, it didn't cause a problem. Now that reg1->configvalue is a stringfield, I think this would have caused a segfault, though I didn't get one with the testsuite. - Corey ------- This is an

Re: [asterisk-dev] [Code Review] 3818: Deprecate astobj.h

still use astobj.h is netsock.c, and that is already deprecated. Diffs - /trunk/include/asterisk/astobj.h 418788 Diff: https://reviewboard.asterisk.org/r/3818/diff/ Testing --- Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

e coverage for all effected events, but does verify many events from res_manager_channels.c. Events from other files were not tested, though res_manager_channels.c was the most likely to cause problems. Thanks, Cor

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

419043 Diff: https://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

nnels/chan_dahdi.c 418788 /trunk/apps/app_voicemail.c 418788 Diff: https://reviewboard.asterisk.org/r/3758/diff/ Testing --- Compile only (I do not have SMDI hardware). Thanks, Corey Farrell -- _ -- Bandwidth and Coloc

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

https://reviewboard.asterisk.org/r/3758/diff/ Testing --- Compile only (I do not have SMDI hardware). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing li

[asterisk-dev] [Code Review] 3831: res_fax: unregister manager actions on unload

this in the future. Diffs - /trunk/res/res_fax.c 419018 /trunk/main/manager.c 419018 Diff: https://reviewboard.asterisk.org/r/3831/diff/ Testing --- Verified that tests/manager/originate no longer produces REF_DEBUG leaks. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

chan_sip to ao2. Diffs (updated) - /trunk/channels/sip/include/sip.h 419043 /trunk/channels/chan_sip.c 419043 Diff: https://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

to this macro were not even using the return. - Corey --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/#review12742 ----------

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

; the res_manager_channels module should be very small: it should set up a > > forwarding relationship between the channel topics and the manager topic > > and be done. > > Corey Farrell wrote: > (1) I couldn't determine what causes the current code (stasis_channel

Re: [asterisk-dev] [Code Review] 3821: Use ao2_t_alloc for certain stasis allocators

/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3800: media formats: chan_iax2 - Obey preferred codec order when selecting format for calls

revision, r3822 has been committed. This renamed ast_codec_pref* to iax2_codec_pref and a couple of the ast_format_compatibility_* to iax2_format_compatibility. - Corey Farrell On July 15, 2014, 6:28 p.m., Jonathan Rose wrote

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

: https://reviewboard.asterisk.org/r/3822/diff/ Testing --- Compile only. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

://reviewboard.asterisk.org/r/3822/diff/ Testing --- Compile only. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

eply, visit: https://reviewboard.asterisk.org/r/3822/#review12732 ------- On July 17, 2014, 4:06 p.m., Corey Farrell wrote: > > --- > This is an automatically ge

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

might prevent me from producing custom events. - Corey --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3811/#review12733 --- On July

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

> On July 17, 2014, 1:37 p.m., Corey Farrell wrote: > > trunk/doc/appdocsxml.dtd, line 34 > > <https://reviewboard.asterisk.org/r/3812/diff/2/?file=64572#file64572line34> > > > > I'd prefer to see a new xml tag for responses instead of managerEve

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

/diff/ Testing --- Compile only. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

://reviewboard.asterisk.org/r/3822/diff/ Testing --- Compile only. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

On July 16, 2014, 10:46 p.m., Corey Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3822/ > --- &g

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

end of list. I'm sure we'll find other reasons to have different attributes/tags within action responses vs managerEvent, but list responses are the big reason I can think of. I'm sure there will be similarities, but that's what ATTLIST is for. - Corey Farrell On Jul

[asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

/asterisk/config_options.h 418809 /team/group/media_formats-reviewed-trunk/channels/iax2/parser.c 418809 /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c 418809 Diff: https://reviewboard.asterisk.org/r/3822/diff/ Testing --- Compile only. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 3821: Use ao2_t_alloc for certain stasis allocators

/stasis_message.c 418809 /trunk/main/stasis_cache_pattern.c 418809 /trunk/main/stasis.c 418809 Diff: https://reviewboard.asterisk.org/r/3821/diff/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

s://reviewboard.asterisk.org/r/3758/#review12704 ----------- On July 16, 2014, 9:29 p.m., Corey Farrell wrote: > > --- > This is an automatically generated e-mail. T

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

only (I do not have SMDI hardware). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digiu

[asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

channels.c was the most likely to cause problems. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visi

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

. I'm not flagging issues for this, but it would be great if you could add brackets to places you are making changes. /trunk/main/loader.c <https://reviewboard.asterisk.org/r/3777/#comment22981> Not sure we want this, but if we do I think it should be ast_debug. - Corey Farrel

[asterisk-dev] [Code Review] 3818: Deprecate astobj.h

://reviewboard.asterisk.org/r/3818/diff/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

hanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

https://reviewboard.asterisk.org/r/3758/#review12606 ----------- On July 12, 2014, 7:38 p.m., Corey Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3758/ > --

Re: [asterisk-dev] [Code Review] 3802: Add module support level to module info; print module support level in CLI "module show" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3802/#review12681 --- Ship it! Ship It! - Corey Farrell On July 15, 2014, 7:27

Re: [asterisk-dev] [Code Review] 3724: chan_pjsip: Allow an endpoint to set an accountcode on channels via an endpoint configuration setting

> On July 9, 2014, noon, rmudgett wrote: > > /branches/12/contrib/ast-db-manage/config/versions/1d50859ed02e_create_accountcode.py, > > line 17 > > > > > > A size of twenty? Seems potentially too small. > > >

Re: [asterisk-dev] [Code Review] 3802: Add module support level to module info; print module support level in CLI "module show" command.

tps://reviewboard.asterisk.org/r/3802/#comment22945> AST_MODULE_SUPPORT_UNKNOWN should be 0 that way it's the default if someone doesn't update the source to specify a value. /trunk/main/loader.c <https://reviewboard.asterisk.org/r/3802/#comment22946> This likely needs to be reorde

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

this in r3463 but discarded it when you started splitting astobj2.c. - Corey Farrell On July 8, 2014, 12:43 a.m., George Joseph wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboa

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

ue to the new required external dependency. - Corey Farrell On July 14, 2014, 5:21 p.m., Matt Jordan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.as

Re: [asterisk-dev] [Code Review] 3775: translate.c: Remove dead struct ast_trans_pvt member explicit_dst.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3775/#review12616 --- Ship it! Ship It! - Corey Farrell On July 13, 2014, 10:32

Re: [asterisk-dev] [Code Review] 3774: translate.c: Reduce the number of codec refs in the log when the translation matrix is rebuilt.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3774/#review12615 --- Ship it! Ship It! - Corey Farrell On July 13, 2014, 10:13

Re: [asterisk-dev] [Code Review] 3756: refcounter.py: use delta's to track current reference count, treat **destroyed** as just another "-1", partially fix a race condition in astobj2

e the change. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/ast

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/#review12607 --- Ship it! Ship It! - Corey Farrell On July 13, 2014, 4:05

Re: [asterisk-dev] [Code Review] 3757: Fix TEST_FRAMEWORK leak in manager.c and another leak in app_skel.c

Diff: https://reviewboard.asterisk.org/r/3757/diff/ Testing --- Verified leaks gone (tested with media_formats branch) Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3761: media formats: Prevent crash on unset format

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3761/#review12602 --- Ship it! Ship It! - Corey Farrell On July 13, 2014, 11:49

Re: [asterisk-dev] [Code Review] 3755: Remove files left behind by h323, jabber, jingle

/jingle.h 418436 /trunk/include/asterisk/jabber.h 418436 /trunk/configs/h323.conf.sample 418436 Diff: https://reviewboard.asterisk.org/r/3755/diff/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3761: media formats: Prevent crash on unset format

/res_rtp_asterisk.c <https://reviewboard.asterisk.org/r/3761/#comment22887> Since rtp is newly allocated, can we just do rtp->lastrxformat = ao2_bump(ast_format_none); ao2_replace makes it appear as if these formats might be previously set. - Corey Farrell On July 12, 2014, 11:01 p.m.,

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

g/r/3765/#comment22886> Please add 'return -1;' after the assert. We want this procedure to give up here even if DO_CRASH isn't enabled. - Corey Farrell On July 12, 2014, 11:49 p.m., Scott Griepentrog wrote: > > -

Re: [asterisk-dev] [Code Review] 3764: astobj2: fix define for ao2_t_cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3764/#review12598 --- Ship it! Ship It! - Corey Farrell On July 12, 2014, 11:40

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

[asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

Description --- Upgrade all ASTOBJ objects in chan_sip to ao2. Diffs - /trunk/channels/sip/include/sip.h 418438 /trunk/channels/chan_sip.c 418438 Diff: https://reviewboard.asterisk.org/r/3759/diff/ Testing --- Full testsuite run. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

dware). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3757: Fix TEST_FRAMEWORK leak in manager.c and another leak in app_skel.c

Description --- app_skel.c leak is in 11+ manager.c leak is in 12+ Diffs - /branches/12/main/manager.c 418395 /branches/12/apps/app_skel.c 418395 Diff: https://reviewboard.asterisk.org/r/3757/diff/ Testing --- Verified leaks gone (tested with media_formats branch) Thanks, Corey

Re: [asterisk-dev] [Code Review] 3756: refcounter.py: use delta's to track current reference count, treat **destroyed** as just another "-1", partially fix a race condition in astobj2

ps://reviewboard.asterisk.org/r/3756/#review12588 ------- On July 12, 2014, 2:13 a.m., Corey Farrell wrote: > > --- > This is an automatically generated e-mail.

Re: [asterisk-dev] [Code Review] 3756: refcounter.py: use delta's to track current reference count, treat **destroyed** as just another "-1", partially fix a race condition in astobj2

https://reviewboard.asterisk.org/r/3756/diff/ Testing --- Verified that all false reported leaks are no longer. One thing I noticed, the updated refcounter.py took 40 seconds to process a file when the same file was processed in 30 seconds before the change. Thanks, Corey Fa

Re: [asterisk-dev] [Code Review] 3756: refcounter.py: use delta's to track current reference count, treat **destroyed** as just another "-1", partially fix a race condition in astobj2

ds to process the same file that took 30 seconds in the unmodified refcounter.py. Maybe a python wizard can suggest something to speed this up. If not the slower processing is worth not having false reports. - Corey Farrell On July 12, 2014, 2:13 a.m., Corey Farrell

[asterisk-dev] [Code Review] 3756: refcounter.py: use delta's to track current reference count, treat **destroyed** as just another "-1", partially fix a race condition in astobj2

leaks are no longer. One thing I noticed, the updated refcounter.py took 40 seconds to process a file when the same file was processed in 30 seconds before the change. Thanks, Corey Farrell -- _ -- Bandwidth and Coloc

Re: [asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

is actually only 12+ (1.8/11 didn't add a ref in add_peer_mwi_subs). - Corey Farrell On July 12, 2014, 12:35 a.m., Scott Griepentrog wrote: > > --- > This is an automatically generated e-mail. To reply,

[asterisk-dev] [Code Review] 3755: Remove files left behind by h323, jabber, jingle

/diff/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

be fixed in the release branches. - Corey Farrell On July 11, 2014, 11:16 p.m., Scott Griepentrog wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asteris

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

> On July 11, 2014, 11:01 p.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed-trunk/main/astobj2.c, lines 503-507 > > <https://reviewboard.asterisk.org/r/3752/diff/1/?file=62839#file62839line503> > > > > This reorder will prevent ref

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

j, -1) == 1 And for thread 2 (which runs the destructor) actually finishing first (and the last 2 entries to ref_log are reversed. - Corey Farrell On July 11, 2014, 10:45 p.m., Matt Jordan wrote: > > --- > This is an autom

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

t; > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3747/ > ------- > > (Updated July 11, 2014, 4:59 p.m.) > > > Rev

Re: [asterisk-dev] [Code Review] 3751: media_formats: resolve double unref of fmt in sip_new, clear fr->mallocd when we're not freeing fr.

ed-trunk/channels/chan_sip.c 418416 Diff: https://reviewboard.asterisk.org/r/3751/diff/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

Re: [asterisk-dev] [Code Review] 3750: media_formats: Add tag variants of ao2_bump/ao2_replace/ao2_cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3750/#review12574 --- Ship it! Ship It! - Corey Farrell On July 11, 2014, 5:32

[asterisk-dev] [Code Review] 3751: media_formats: resolve double unref of fmt in sip_new, clear fr->mallocd when we're not freeing fr.

llocd is cleared if we are not freeing fr. Diffs - /team/group/media_formats-reviewed-trunk/main/frame.c 418416 /team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418416 Diff: https://reviewboard.asterisk.org/r/3751/diff/ Testing --- Thanks, Corey

Re: [asterisk-dev] [Code Review] 3750: media_formats: Add tag variants of ao2_bump/ao2_replace/ao2_cleanup

/astobj2.h <https://reviewboard.asterisk.org/r/3750/#comment22863> Why get rid of the tab indenting? /team/group/media_formats-reviewed-trunk/include/asterisk/astobj2.h <https://reviewboard.asterisk.org/r/3750/#comment22864> Tab indent here too. - Corey Farrell On July 11

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3734/#review12570 --- Ship it! Ship It! - Corey Farrell On July 11, 2014, 5:26

Re: [asterisk-dev] [Code Review] 3743: astobj2: tweak ao2_replace to do nothing when it would be a NoOp

we're not actually doing anything. Diffs - /branches/12/include/asterisk/astobj2.h 418364 Diff: https://reviewboard.asterisk.org/r/3743/diff/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Coloc

Re: [asterisk-dev] [Code Review] 3746: media formats: Fix double unref on full cache

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3746/#review12564 --- Ship it! Ship It! - Corey Farrell On July 11, 2014, 3:30

Re: [asterisk-dev] [Code Review] 3748: translate.c: Fix ref leaks in ast_translator_best_choice().

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3748/#review12563 --- Ship it! Ship It! - Corey Farrell On July 11, 2014, 4:15

[asterisk-dev] [Code Review] 3743: astobj2: tweak ao2_replace to do nothing when it would be a NoOp

org/r/3743/diff/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/ma

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

> On July 11, 2014, 2:43 a.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed-trunk/tests/test_core_format.c, lines > > 61-66 > > <https://reviewboard.asterisk.org/r/3734/diff/4/?file=62711#file62711line61> > > > > Do we really want doxyg

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

dst_caps + src_caps == count? /team/group/media_formats-reviewed-trunk/tests/test_format_cap.c <https://reviewboard.asterisk.org/r/3734/#comment22845> Can we say re-append or append duplicate? - Corey Farrell On July 10, 2014, 12:11 p.m., Matt Jordan wrote: > > ---

<    1   2   3   4   5   6   7   8   >