Diff: https://reviewboard.asterisk.org/r/3408/diff/
Testing
---
Verified this corrects the symbol failure.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev
there, Asterisk 12
renames the variable to ast_defaultlanguage so it was not a problem in 12+.
Diffs
-
/branches/11/main/asterisk.exports.in 411572
Diff: https://reviewboard.asterisk.org/r/3408/diff/
Testing
---
Verified this corrects the symbol failure.
Thanks,
Corey Farrell
per hook_id.
Maybe add to documentation that a timer interval will be skipped if the
channel from the previous interval hasn't ended.
- Corey Farrell
On March 29, 2014, 4:27 p.m., Russell Bryant wrote
p.m.)
Review request for Asterisk Developers, Corey Farrell and wdoekes.
Repository: Asterisk
Description
---
Note: while an improvement to Asterisk, this patch only affects Asterisk when
compiled in -dev-mode. Since it has benefit only for developers looking to
fix bugs
would be useful we would
want the original refs file and full debug logs from the same run.
- Corey Farrell
On March 27, 2014, 10:23 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/
Testing
---
I verified after applying this patch I am unable to cause a segfault by running
'killall asterisk' while a call is active. This test causes a SEGV every time
without the patch.
Thanks,
Corey Farrell
compiled
with devmode.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
On March 20, 2014, 5:12 a.m., Corey Farrell wrote:
We should remove utils/refcounter from all branches. The format is
changing, so the existing utils/refcounter will be unusable with 1.8.27.0 /
11.9.0 / 12.2.0. I think providing utils/refcounter in those versions will
only cause
compile app_jack due to dependencies, all other changed files compiled
with devmode.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
to be correct for
use without run-local, but can't test that.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
://reviewboard.asterisk.org/r/3386/diff/
Testing
---
Compiled, visually inspected.
I cannot compile app_jack due to dependencies, all other changed files compiled
with devmode.
Thanks,
Corey Farrell
--
_
-- Bandwidth
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3349/#review11335
---
Ship it!
Ship It!
- Corey Farrell
On March 22, 2014, 9:08
On March 21, 2014, 2:01 p.m., Corey Farrell wrote:
/trunk/channels/sip/reqresp_parser.c, line 130
https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130
This needs to blank both variables:
userinfo = uri = ;
Geert Van Pamel wrote:
We return
caused by garbage collection could be partly
responsible for making that safe. It's also possible that it's not actually
safe in Firefox.
- Corey Farrell
On March 23, 2014, 2 p.m., George Joseph wrote:
---
This is an automatically
On March 21, 2014, 2:01 p.m., Corey Farrell wrote:
/trunk/channels/sip/reqresp_parser.c, line 130
https://reviewboard.asterisk.org/r/3349/diff/7-8/?file=56285#file56285line130
This needs to blank both variables:
userinfo = uri = ;
Geert Van Pamel wrote:
We return
/reqresp_parser.c
https://reviewboard.asterisk.org/r/3349/#comment20960
!ast_strlen_zero(name) was correct.
- Corey Farrell
On March 21, 2014, 3:32 a.m., Geert Van Pamel wrote:
---
This is an automatically generated e-mail
)?
- Corey Farrell
On March 19, 2014, 5:01 a.m., Geert Van Pamel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3349
this would be impossible without starting
to use constructor/destructor priorities.
- Corey Farrell
On March 19, 2014, 2:22 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
I would prefer we use a goto here instead of duplicating this code, but
since this works around a crash I don't want to hold it up over a few
duplicated lines.
https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines#CodingGuidelines-Labels/gotoareacceptable
- Corey Farrell
code than when the input file was not found, but I don't think
it would hurt.
- Corey Farrell
On March 19, 2014, 2:22 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
= 0x29e88f55f57 Address 0x29e88f55f57 out of bounds,
ttl = 0x7fff88f583a0 __PRETTY_FUNCTION__.27916
sip_parse_uri_test, maddr = 0x7fff88f55e24 sip/reqresp_parser.c, lr =
-1997185193}
- Corey Farrell
On March 20, 2014, 5:59 p.m., Geert Van Pamel wrote
by running
'killall asterisk' while a call is active. This test causes a SEGV every time
without the patch.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
run:
test execute category /channels/chan_sip/
- Corey Farrell
On March 17, 2014, 3:01 p.m., Geert Van Pamel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3349
with the patch.
- Corey Farrell
On March 14, 2014, 2:35 p.m., Scott Griepentrog wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3209
://reviewboard.asterisk.org/r/3349/#comment20865
This will cause sip_uri_full_parse_test to fail, as the test loop requires
non-error result from all tests. Currently all tests for expected failures are
in sip_uri_parse_test.
- Corey Farrell
On March 15, 2014, 6:02 p.m., Geert Van Pamel wrote
/reqresp_parser.c
https://reviewboard.asterisk.org/r/3349/#comment20859
scheme is the input parameter listing acceptable schemes, we don't need to
see it here. The other ast_debug included scheme since the problem was a
failure to match the uri with any scheme.
- Corey Farrell
On March 15, 2014, 8
On March 15, 2014, 2:46 p.m., Russell Bryant wrote:
So, after talking to pabelanger about it, this could be a bit more generic
without a lot of effort. Right now it's hard coded to do a Playback(beep)
into the call. It could pretty easily changed to just be a periodic
dialplan
% of the calls to beep_callback will
take no action.
- Corey Farrell
On March 15, 2014, 2:15 p.m., Russell Bryant wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3362
an already freed or NULL pointer.
- Corey Farrell
On March 13, 2014, 1:37 p.m., Scott Griepentrog wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3209
My one concern is if we stop optimizing Local channels and allow the
ast_channel to live for the duration of the call, this could significantly
increase open FD's. This would be a bigger issue for systems using
res_timing_timerfd, since that causes alert pipe's to be created.
On Tue, Mar 11,
-debug.patch from ASTERISK-21406 to ensure
I could no longer reproduce the deadlock.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
the lock and be allowed to exit.
Diffs
-
/branches/1.8/channels/chan_sip.c 409411
Diff: https://reviewboard.asterisk.org/r/3284/diff/
Testing
---
Tested with chan_sip-unload-deadlock-debug.patch from ASTERISK-21406 to ensure
I could no longer reproduce the deadlock.
Thanks,
Corey
is handled separate, that way the special
prefix can be given to the exception print-out.
- Corey Farrell
On March 3, 2014, 5:30 p.m., Scott Griepentrog wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
ASTERISK-21406 to ensure
I could no longer reproduce the deadlock.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options
/diff/
Testing
---
Original failure found with old version of starpy that mishandled channel None
for AMI getVar. This change caused the correct error Failed to execute
GetVar instead of a python backtrace.
Thanks,
Corey Farrell
,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
On Feb. 27, 2014, 11:26 a.m., Joshua Colp wrote:
This is fine but we should probably do an audit and try to find other cases.
If nobody is working on the audit of channel usage in dialplan functions I can.
Should I start a new JIRA ticket?
- Corey
,
so success is incorrectly reported.
Diffs
-
/asterisk/trunk/tests/cdr/originate-cdr-disposition/test-config.yaml 4730
/asterisk/trunk/tests/cdr/cdr-tests.py 4730
Diff: https://reviewboard.asterisk.org/r/3263/diff/
Testing
---
Thanks,
Corey Farrell
://reviewboard.asterisk.org/r/3264/diff/
Testing
---
Tested with AMIFactory.login that doesn't accept bindAddress and with updated
starpy that accepts it. With old starpy the test failed due to all connections
being from 127.0.0.1. With updated starpy the test passed.
Thanks,
Corey Farrell
., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3261/
---
(Updated Feb. 24, 2014, 6:25 p.m.)
Review
the lock and be allowed to exit.
Diffs
-
/branches/1.8/channels/chan_sip.c 408931
Diff: https://reviewboard.asterisk.org/r/3269/diff/
Testing
---
Tested with chan_sip-unload-deadlock-debug.patch from ASTERISK-21406 to ensure
I could no longer reproduce the deadlock.
Thanks,
Corey
reproduce the deadlock.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
be blocked from trunk.
Diffs
-
/branches/1.8/res/res_fax.c 408784
/branches/1.8/configs/res_fax.conf.sample 408784
Diff: https://reviewboard.asterisk.org/r/3261/diff/
Testing
---
Thanks,
Corey Farrell
/asterisk/trunk/lib/python/asterisk/test_config.py 4730
Diff: https://reviewboard.asterisk.org/r/3262/diff/
Testing
---
Verified tests/channels/SIP/rfc2833_dtmf_detect was skipped for failed
dependency rawsocket as non-root, and was successful when run as root.
Thanks,
Corey Farrell
-disposition/test-config.yaml 4730
/asterisk/trunk/tests/cdr/cdr-tests.py 4730
Diff: https://reviewboard.asterisk.org/r/3263/diff/
Testing
---
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3247/#review10939
---
Ship it!
Ship It!
- Corey Farrell
On Feb. 22, 2014, 12:06
accept bindAddress and with updated
starpy that accepts it. With old starpy the test failed due to all connections
being from 127.0.0.1. With updated starpy the test passed.
Thanks,
Corey Farrell
--
_
-- Bandwidth
or + would cause 1 to be used as hostport (like in SIP uri).
I'd like to see test cases added to sip_parse_uri_full_test and/or
sip_parse_uri_test. At minimum the tests need to verify no change in results
for URI scheme sip.
- Corey Farrell
On Feb. 23, 2014, 6:17 a.m., wdoekes wrote
channel None
for AMI getVar. This change caused the correct error Failed to execute
GetVar instead of a python backtrace.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk
408296
Diff: https://reviewboard.asterisk.org/r/3236/diff/
Testing
---
tests/channels/SIP/path, tests/channels/SIP/route, manual test of calls without
Record-Route headers.
Thanks,
Corey Farrell
--
_
-- Bandwidth
/pbx.c 408383
Diff: https://reviewboard.asterisk.org/r/3241/diff/
Testing
---
Compile only for asterisk.
./utils/aelparse ran without failure. I attempted to run ./utils/conf2ael, but
it segfaulted both before and after my patch.
Thanks,
Corey Farrell
for asterisk.
./utils/aelparse ran without failure. I attempted to run ./utils/conf2ael, but
it segfaulted both before and after my patch.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api
/path, tests/channels/SIP/route, manual test of calls without
Record-Route headers.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3202/#review10879
---
Ship it!
Ship It!
- Corey Farrell
On Feb. 10, 2014, 1:46
/
---
(Updated Feb. 11, 2014, 2:37 p.m.)
Review request for Asterisk Developers, Corey Farrell and n8ideas.
Bugs: ASTERISK-23103
https://issues.asterisk.org/jira/browse/ASTERISK-23103
Repository: Asterisk
Description
---
This fixes a possible crash on shutdown
://reviewboard.asterisk.org/r/3202/#comment20435
I don't think these are needed.
/trunk/build_tools/install_subst
https://reviewboard.asterisk.org/r/3202/#comment20433
Duplicate
- Corey Farrell
On Feb. 10, 2014, 10:08 a.m., Tzafrir Cohen wrote
://reviewboard.asterisk.org/r/3172/diff/
Testing
---
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com
/trunk/channels/chan_sip.c 407178
Diff: https://reviewboard.asterisk.org/r/3173/diff/
Testing
---
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing
/asterisk/test_config.py 4663
/asterisk/trunk/lib/python/asterisk/asterisk.py 4663
Diff: https://reviewboard.asterisk.org/r/3195/diff/
Testing
---
Ran tests/cdr and tests/channels/SIP in both local and system mode.
Thanks,
Corey Farrell
://reviewboard.asterisk.org/r/3202/#comment20429
If we have '-d' we need to shift.
/trunk/build_tools/install_subst
https://reviewboard.asterisk.org/r/3202/#comment20425
This is missing __ASTERISK_ETC_DIR__
- Corey Farrell
On Feb. 9, 2014, 2:24 p.m., Tzafrir Cohen wrote
://reviewboard.asterisk.org/r/3195/diff/
Testing
---
Ran tests/cdr and tests/channels/SIP in both local and system mode.
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
json_variables
object.
/branches/12/res/ari/resource_channels.c
https://reviewboard.asterisk.org/r/3183/#comment20333
If we actually failed to create variables that were requested, we should
abort the Originate. Half-success is worse than total failure.
- Corey Farrell
On Feb. 6, 2014
/res/ari/resource_channels.c
https://reviewboard.asterisk.org/r/3183/#comment20361
Why not ast_ari_response_alloc_failed?
- Corey Farrell
On Feb. 6, 2014, 2:57 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3183/#review10816
---
Ship it!
Ship It!
- Corey Farrell
On Feb. 6, 2014, 4:18
://reviewboard.asterisk.org/r/3175/#comment20264
Not sure why this isn't a red blob, should be tabbed
- Corey Farrell
On Feb. 5, 2014, 1:17 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3173/#review10745
---
On Feb. 3, 2014, 2:48 p.m., Corey Farrell wrote
.
As for refcounting, most of it has been removed since you no longer ao2_find
the timer data. Since timer lifetime is controlled by ast_timer_open /
ast_timer_close, refcounting is not useful.
- Corey Farrell
On Feb. 4, 2014, 10:16 a.m., Joshua Colp wrote
/asterisk/trunk/tests/channels/SIP/route/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/route/configs/ast1/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3172/diff/
Testing
---
Thanks,
Corey Farrell
/
Testing
---
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3173/#review10741
---
On Feb. 3, 2014, 7:41 a.m., Corey Farrell wrote
://reviewboard.asterisk.org/r/3173/diff/
Testing
---
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
://reviewboard.asterisk.org/r/3173/diff/
Testing
---
Thanks,
Corey Farrell
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
601 - 672 of 672 matches
Mail list logo
