* stupid assumptions!!!
- Mark Michelson
On Oct. 10, 2014, 6:49 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4071
On 10/07/2014 05:57 AM, Joshua Colp wrote:
I'm down with proposal #2 but I have to ask: would this work with
realtime, and how?
(In this response, I refer to the new configuration type as a compound
type since I also refer to sorcery wizards, which are a different thing.)
I'm thinking
to this patch's
inclusion in Asterisk 12.
branches/12/tests/test_config.c
https://reviewboard.asterisk.org/r/4033/#comment23952
For all of the snprintf() calls in this test, use sizeof(temp) instead of
32.
- Mark Michelson
On Sept. 30, 2014, 9:24 p.m., George Joseph wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4018/#review13430
---
Ship it!
Ship It!
- Mark Michelson
On Oct. 1, 2014, 6:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4034/#review13431
---
Ship it!
Ship It!
- Mark Michelson
On Sept. 30, 2014, 7:24
://reviewboard.asterisk.org/r/4032/#comment23892
Just set uri-transport_param.slen = 0 instead of creating the empty_string
constant.
- Mark Michelson
On Sept. 30, 2014, 12:19 p.m., opticron wrote:
---
This is an automatically generated e-mail
benefit for doing this is that any taskprocessor implementation
will automatically have the thread ID set correctly.
/branches/13/main/taskprocessor.c
https://reviewboard.asterisk.org/r/4034/#comment23895
Use pthread_equal() instead of the == operator.
- Mark Michelson
On Sept. 29, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4036/#review13409
---
Ship it!
Ship It!
- Mark Michelson
On Sept. 30, 2014, 4:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4026/#review13412
---
Ship it!
Ship It!
- Mark Michelson
On Sept. 28, 2014, 5:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4019/#review13413
---
Ship it!
Ship It!
- Mark Michelson
On Sept. 24, 2014, 1:03
REG_ICASE be one of the flags passed to regcomp?
- Mark Michelson
On Sept. 29, 2014, 10:11 p.m., George Joseph wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4033
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4024/#review13388
---
Ship it!
Ship It!
- Mark Michelson
On Sept. 26, 2014, 9:04
There's a red blob at the end of this line.
- Mark Michelson
On Sept. 19, 2014, 5:04 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4008
pass
with no FRACKs.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
,
things are pretty disastrous in the CEL tests (i.e. Asterisk crashes). And the
CDR tests have FRACKs in them. With the patch, all CDR and CEL unit tests pass
with no FRACKs.
Thanks,
Mark Michelson
--
_
-- Bandwidth
on whether the SIPp scenario
succeeds or fails.
- Mark Michelson
On Sept. 19, 2014, 8:09 a.m., Torrey Searle wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4006
Diff: https://reviewboard.asterisk.org/r/3967/diff/
Testing
---
/r/3966 exercises these events and has tested that the events are sent when
expected.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided
/subscriptions/rls/lists/nominal/mwi/batched/basic/configs/ast1/pjsip.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3966/diff/
Testing
---
Ran all tests many many times to ensure they consistently pass.
Thanks,
Mark Michelson
On Sept. 15, 2014, 4:14 p.m., opticron wrote:
This change appears to render the media_use_received_transport
configuration option non-functional since it removes all checks relating to
it.
Joshua Colp wrote:
It'll still work, the difference is on received it is always done and
://reviewboard.asterisk.org/r/4000/#comment23836
Since joint only has formats of type media_type, would specifying
media_type instead of AST_MEDIA_TYPE_UNKNOWN make more sense here?
- Mark Michelson
On Sept. 18, 2014, 6:26 p.m., rmudgett wrote
On Sept. 11, 2014, 3:16 p.m., Joshua Colp wrote:
/branches/13/res/res_pjsip.c, lines 2488-2501
https://reviewboard.asterisk.org/r/3954/diff/4/?file=67305#file67305line2488
Looking at the pjproject code why wouldn't the following return values
cover these cases for when the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3980/#review13353
---
Ship it!
Ship It!
- Mark Michelson
On Sept. 5, 2014, 7:54
are being written against an unimplemented feature. There are almost certainly
some mistakes made in these tests, so I figured I'd get those caught by
reviewers early.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation
On Sept. 18, 2014, 9:35 p.m., Mark Michelson wrote:
/branches/13/res/res_pjsip_sdp_rtp.c, line 259
https://reviewboard.asterisk.org/r/4000/diff/1/?file=67396#file67396line259
Since joint only has formats of type media_type, would specifying
media_type instead
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4000/#review13356
---
Ship it!
Ship It!
- Mark Michelson
On Sept. 18, 2014, 6:26
://reviewboard.asterisk.org/r/3995/#comment23809
Print current_string instead of var-value here.
- Mark Michelson
On Sept. 17, 2014, 10:29 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
in
channels/pjsip/ami/show_endpoint/test-config.yaml and scroll all the way to the
bottom, you'll see a XXX comment there explaining the problem. Right now, the
test expects ListItems: '6', but that should be changed to ListItems: '7' after
this patch goes in.
- Mark Michelson
On Sept. 17
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3991/#review13291
---
Ship it!
Ship It!
- Mark Michelson
On Sept. 12, 2014, 12
is past the end of
the string and likely lead to a segfault.
- Mark Michelson
On Sept. 12, 2014, 6:12 a.m., George Joseph wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3989
by me.
- Mark Michelson
On Sept. 8, 2014, 6:21 p.m., Jason Parker wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3984
/off_nominal/large_notify/configs/ast1/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3978/diff/
Testing
---
Without the patch on /r/3977, this test fails since Asterisk cannot send the
large NOTIFY. With the patch applied, this test succeeds.
Thanks,
Mark Michelson
/pjsip.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3951/diff/
Testing
---
The test passes as written. I tried messing with values sent and expected
received values to ensure that misconfigurations would fail as well.
Thanks,
Mark Michelson
---
See /r/3978 for a testsuite test that exercises this.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
://reviewboard.asterisk.org/r/3981/#comment23734
Should this also call ast_rtp_instance_stop() before
ast_rtp_instance_destroy()?
- Mark Michelson
On Sept. 7, 2014, 3:07 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail
On 09/05/2014 05:50 PM, Jonathan Rose wrote:
So a little bit of background before I jump into this...
In Asterisk 11, I worked on a feature known as call identifier logging.
https://wiki.asterisk.org/wiki/display/AST/Call+Identifier+Logging
It's a somewhat clingy concept where channels are
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3983/#review13262
---
Ship it!
Ship It!
- Mark Michelson
On Sept. 8, 2014, 4:15
the subscription as well.
Diffs
-
/branches/13/res/res_pjsip_pubsub.c 422576
Diff: https://reviewboard.asterisk.org/r/3977/diff/
Testing
---
See /r/3978 for a testsuite test that exercises this.
Thanks,
Mark Michelson
., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3977/
---
(Updated Sept. 4, 2014, 8:11 p.m.)
Review
On Sept. 4, 2014, 8:49 p.m., Matt Jordan wrote:
This is a loaded question but... how much does 64k buy us? That is, how
many different list elements can we typically embed in a 64k body?
Mark Michelson wrote:
The list used in the test on /r/3978/ has 20 presence resources. The full
been altered to deal with an external deletion of the currently
running task.
Also, switching from a variable scheduler callback means that if the
qualify frequency of a contact is changed, we will not switch to the new
qualify frequency.
- Mark Michelson
On Sept. 3, 2014, 2:40 p.m
/nominal/mwi/batched/basic/configs/ast1/pjsip.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3966/diff/
Testing
---
Ran all tests many many times to ensure they consistently pass.
Thanks,
Mark Michelson
applying the patch, I would usually encounter a test failure within an hour or
two. After applying this patch, I left the test running in a loop for over 24
hours and never had a test failure.
Thanks,
Mark Michelson
/mwi/batched/basic/configs/ast1/pjsip.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3966/diff/
Testing
---
Ran all tests many many times to ensure they consistently pass.
Thanks,
Mark Michelson
expected.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
can just return whatever
handler-notifier-new_subscribe() returns.
- Mark Michelson
On Aug. 28, 2014, 9:59 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r
with values sent and expected
received values to ensure that misconfigurations would fail as well.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
while the patch attached here may not necessarily be
enough to close the referenced issue, it is fixing one of the reasons for test
failure.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api
---
On Aug. 24, 2014, 11:37 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3930
the test running in a loop for over 24
hours and never had a test failure.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3930/#review13157
---
On Aug. 24, 2014, 3:52 p.m., Mark Michelson wrote
. Before
applying the patch, I would usually encounter a test failure within an hour or
two. After applying this patch, I left the test running in a loop for over 24
hours and never had a test failure.
Thanks,
Mark Michelson
not necessarily be
enough to close the referenced issue, it is fixing one of the reasons for test
failure.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing
.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
to resolve the hostname to a different IP address, that IP address appeared
in the SDP origin line instead.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev
$ ping `hostname -f`
PING ns1.osso.xx (127.0.1.1) 56(84) bytes of data.
$ host `hostname -f`
ns1.osso.xx has address 91.194.xx.xx
Is this going to be configurable somehow? Because 127.0.1.1 is worse
than my hostname.
Mark Michelson wrote:
Yes, it's configurable
$ ping `hostname -f`
PING ns1.osso.xx (127.0.1.1) 56(84) bytes of data.
$ host `hostname -f`
ns1.osso.xx has address 91.194.xx.xx
Is this going to be configurable somehow? Because 127.0.1.1 is worse
than my hostname.
Mark Michelson wrote:
Yes, it's configurable
, that IP address appeared in the
SDP origin line instead.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
On Aug. 19, 2014, 6:05 p.m., rmudgett wrote:
branches/1.8/tests/test_callerid.c, line 608
https://reviewboard.asterisk.org/r/3923/diff/1/?file=66615#file66615line608
Rather than a bunch of redundant tests checking minor variations in the
string. How about one test that works
.
Bridge(Alice,F): Channel moved to the priority after the Bridge() application
when the non-Stasis bridge dissolved.
Bridge(Alice,x): Channel was hung up after the non-Stasis bridge dissolved.
Thanks,
Mark Michelson
instead of a hostname. When I modified /etc/hosts to
resolve the hostname to a different IP address, that IP address appeared in the
SDP origin line instead.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided
line instead.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
after the Bridge() application
when the non-Stasis bridge dissolved.
Bridge(Alice,x): Channel was hung up after the non-Stasis bridge dissolved.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http
moved to the priority after the Bridge() application
when the non-Stasis bridge dissolved.
Bridge(Alice,x): Channel was hung up after the non-Stasis bridge dissolved.
Thanks,
Mark Michelson
--
_
-- Bandwidth
was hung up after the non-Stasis bridge dissolved.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
forwarded.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
as well.
Finally, I connected an AMI session when running the test and ensured that the
Forward: header was present in the DialEnd when the call got forwarded.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided
RLS-specific tests
since there is still no method of generating multipart/related or RLMI bodies.
However, with these changes, I did run the gamut of subscription tests in the
testsuite and they all pass. This at least means that there are no detectable
regressions at this point.
Thanks,
Mark
at this point.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
it!
trunk/configs/samples/voicemail.conf.sample
https://reviewboard.asterisk.org/r/3833/#comment23487
Remove the trailing semicolon
- Mark Michelson
On Aug. 7, 2014, 3:07 p.m., Jason Parker wrote:
---
This is an automatically
be reflected in
a single batched notification, and that operations that should cancel a batch
did so properly.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev
to be shipped.
branches/12/main/stasis_bridges.c
https://reviewboard.asterisk.org/r/3892/#comment23488
Need to add ast_json_unref(out) in this off-nominal path.
- Mark Michelson
On Aug. 7, 2014, 7:57 p.m., opticron wrote
regressions at this point.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
/res_pjsip_outbound_publish.c
https://reviewboard.asterisk.org/r/3780/#comment23436
Re
- Mark Michelson
On Aug. 5, 2014, 5:37 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
have a reasonable guess at this by checking for the destroy flag in the
callback and for checking if the response has an Expires: 0 header in it.
- Mark Michelson
On Aug. 5, 2014, 5:37 p.m., Joshua Colp wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13037
---
Ship it!
Ship It!
- Mark Michelson
On Aug. 6, 2014, 6:23
/message_modules.py
https://reviewboard.asterisk.org/r/3864/#comment23473
passed = all(r[0] for r in result)
This saves construction of a list and is, imo, more readable.
- Mark Michelson
On July 28, 2014, 2:19 a.m., Matt Jordan wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3890/#review13043
---
Ship it!
Ship It!
- Mark Michelson
On Aug. 5, 2014, 10:51
, 2014, 3:44 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3723/
---
(Updated Aug. 6, 2014, 3:44
there is still no method of generating multipart/related or RLMI bodies.
However, with these changes, I did run the gamut of subscription tests in the
testsuite and they all pass. This at least means that there are no detectable
regressions at this point.
Thanks,
Mark Michelson
.
remove_subscription() also does a module unref which would need to be
moved to unlink the subscription from the list first.
Mark Michelson wrote:
I'm getting a parse error on your second sentence, specificallly which
would need to be moved to unlink the subscription from the list first
regressions at this point.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
the ast_sip_create_serializer() function
use a UUID [1] to name their taskprocessors. The output that you have
pasted shows many taskprocessors with UUIDs as names, which likely are
all serializers in the SIP stack.
I hope that answers your question.
Mark Michelson
[1] http://www.ietf.org/rfc/rfc4122.txt
generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3723/#review12986
---
On July 25, 2014, 8:57 p.m., Mark Michelson wrote:
---
This is an automatically generated e
generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3723/#review12993
---
On July 25, 2014, 8:57 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail
in the
testsuite and they all pass. This at least means that there are no detectable
regressions at this point.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
---
On July 25, 2014, 10 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3741/
---
(Updated July 25, 2014
that
the notification was batched, that multiple state changes would be reflected in
a single batched notification, and that operations that should cancel a batch
did so properly.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3723/#review13005
---
On Aug. 5, 2014, 6:30 p.m., Mark Michelson wrote
since there is still no method of generating multipart/related or RLMI bodies.
However, with these changes, I did run the gamut of subscription tests in the
testsuite and they all pass. This at least means that there are no detectable
regressions at this point.
Thanks,
Mark Michelson
/res_pjsip_outbound_publish.c
https://reviewboard.asterisk.org/r/3780/#comment23366
s/402/423/
- Mark Michelson
On Aug. 3, 2014, 10:58 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
this for
MySQL
3) some reassurance that this will not do something awful for other DBMSs.
As it looks, every voicemail message is going to have 4GB set aside for it.
- Mark Michelson
On July 30, 2014, 2:52 p.m., rmudgett wrote
contacts and ensured that the output
looked correct for each.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3888/#review12961
---
Ship it!
Ship It!
- Mark Michelson
On Aug. 1, 2014, 12:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3854/#review12962
---
Ship it!
Ship It!
- Mark Michelson
On Aug. 1, 2014, 6:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3885/#review12963
---
Ship it!
- Mark Michelson
On July 31, 2014, 9:40 p.m
,
Mark Michelson
[1] https://issues.asterisk.org/jira/browse/ASTERISK-24136
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
onto the peer. Any peer-specific
value encountered in the configuration will be copied onto the peer by
ast_rtp_dtls_cfg_parse().
- Mark Michelson
On July 30, 2014, 9:15 a.m., Michael K. wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3607/#review12926
---
Ship it!
Ship It!
- Mark Michelson
On July 30, 2014, 3:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3807/#review12927
---
Ship it!
Ship It!
- Mark Michelson
On July 28, 2014, 7:03
penalty rules
is not severe enough to warrant a shutdown of Asterisk.
- Mark Michelson
On June 30, 2014, 1:26 p.m., Michael K. wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r
401 - 500 of 927 matches
Mail list logo
