Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/ --- (Updated Dec. 9, 2013, 10:43 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-26 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/ --- (Updated Nov. 26, 2013, 5:07 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/#review10284 --- Ship it! Ship It! - Matt Jordan On Nov. 26, 2013, 5:07

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-25 Thread Matt Jordan
On Nov. 21, 2013, 4:40 p.m., Tilghman Lesher wrote: Shouldn't something like this be a channel function from which you retrieve the value, instead of specifying a variable into which the name is placed? Seems like a significant regression in spitting things out to channel variables,

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-21 Thread Tilghman Lesher
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/#review10242 --- Shouldn't something like this be a channel function from which

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/#review10235 --- Ship it! Ship It! - Joshua Colp On Nov. 20, 2013, 9:12

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-21 Thread Mark Michelson
On Nov. 21, 2013, 2:17 p.m., Joshua Colp wrote: The code itself looks fine, the only nagging question I have is why not just treat the variable as a temporary return variable in the case when you have multiple MixMonitor instances and use Set in the dialplan to set another variable

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-21 Thread Mark Michelson
On Nov. 21, 2013, 4:40 p.m., Tilghman Lesher wrote: Shouldn't something like this be a channel function from which you retrieve the value, instead of specifying a variable into which the name is placed? Seems like a significant regression in spitting things out to channel variables,

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/#review10231 --- The code itself looks fine, the only nagging question I have

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-21 Thread Tilghman Lesher
On Nov. 21, 2013, 4:40 p.m., Tilghman Lesher wrote: Shouldn't something like this be a channel function from which you retrieve the value, instead of specifying a variable into which the name is placed? Seems like a significant regression in spitting things out to channel variables,