Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/ --- (Updated March 23, 2014, 6:50 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-20 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/ --- (Updated March 20, 2014, 11:40 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-20 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/#review11298 --- Ship it!

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-19 Thread Joshua Colp
On March 18, 2014, 4:22 p.m., Matt Jordan wrote: /team/group/media_formats-reviewed/main/format.c, lines 292-296 https://reviewboard.asterisk.org/r/3319/diff/1/?file=55696#file55696line292 Where is this getting used? I think... only musiconhold presently. On March 18, 2014, 4:22

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-19 Thread Matt Jordan
On March 18, 2014, 11:22 a.m., Matt Jordan wrote: /team/group/media_formats-reviewed/include/asterisk/frame.h, lines 131-141 https://reviewboard.asterisk.org/r/3319/diff/1/?file=55694#file55694line131 This feels a bit odd. ast_frame_video is basically just the same as ast_format,