Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/ --- (Updated March 23, 2014, 6:50 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-20 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/#review11298 --- Ship it! /team/group/media_formats-reviewed/include/asterisk/

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-20 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/ --- (Updated March 20, 2014, 11:40 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-19 Thread Matt Jordan
> On March 18, 2014, 11:22 a.m., Matt Jordan wrote: > > /team/group/media_formats-reviewed/include/asterisk/frame.h, lines 131-141 > > > > > > This feels a bit odd. ast_frame_video is basically just the same as > >

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-19 Thread Joshua Colp
> On March 18, 2014, 4:22 p.m., Matt Jordan wrote: > > /team/group/media_formats-reviewed/main/format.c, lines 292-296 > > > > > > Where is this getting used? I think... only musiconhold presently. > On March 18,

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/#review11278 --- /team/group/media_formats-reviewed/include/asterisk/frame.h

[asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/ --- Review request for Asterisk Developers. Repository: Asterisk Description