Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-06-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3363/#review12197 --- Ship it! Ship It! - opticron On June 15, 2014, 2:43 p.m.,

Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-06-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3363/ --- (Updated June 19, 2014, 4:34 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-06-17 Thread Scott Griepentrog
On June 5, 2014, 10:36 a.m., Scott Griepentrog wrote: /asterisk/trunk/lib/python/asterisk/realtime_test_module.py, lines 247-248 https://reviewboard.asterisk.org/r/3363/diff/1/?file=56114#file56114line247 This has an exception on non-string types. Recommend wrapping val prior to

Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-06-15 Thread Mark Michelson
On June 5, 2014, 3:36 p.m., Scott Griepentrog wrote: /asterisk/trunk/lib/python/asterisk/realtime_test_module.py, line 489 https://reviewboard.asterisk.org/r/3363/diff/1/?file=56114#file56114line489 I like the idea of having the extconfig.conf built automatically from configured

Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-06-15 Thread Mark Michelson
On April 8, 2014, 7:24 p.m., Corey Farrell wrote: /asterisk/trunk/lib/python/asterisk/realtime_test_module.py, line 489 https://reviewboard.asterisk.org/r/3363/diff/1/?file=56114#file56114line489 Port 8000 is commonly used as the alternate/unprivileged port 80, so this increases

Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-06-15 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3363/ --- (Updated June 15, 2014, 7:43 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-06-05 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3363/#review12051 --- /asterisk/trunk/lib/python/asterisk/realtime_test_module.py

Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-04-08 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3363/#review11516 --- /asterisk/trunk/lib/python/asterisk/realtime_test_module.py

Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-04-03 Thread Mark Michelson
On March 25, 2014, 5:42 p.m., opticron wrote: /asterisk/trunk/lib/python/asterisk/realtime_test_module.py, line 322 https://reviewboard.asterisk.org/r/3363/diff/1/?file=56114#file56114line322 Just to make sure I'm clear here, we're throwing away wildcards (%) and treating them as

Re: [asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-03-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3363/#review11365 --- /asterisk/trunk/lib/python/asterisk/realtime_test_module.py

[asterisk-dev] [Code Review] 3363: Testsuite: Pluggable module for testing realtime

2014-03-15 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3363/ --- Review request for Asterisk Developers. Repository: testsuite