Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/ --- (Updated May 9, 2014, 11:10 a.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/#review11860 --- Ship it! Ship It! - Joshua Colp On May 8, 2014, 7:31 p.m.,

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-08 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/ --- (Updated May 8, 2014, 2:31 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/#review11842 --- So either I'm crazy or... I don't see a difference between the

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-07 Thread Jonathan Rose
> On May 1, 2014, 1:37 p.m., Mark Michelson wrote: > > Ship It! It's too bad Reviewboard doesn't have a method for cancelling a ship it since this applied to an older version of the patch. - Jonathan --- This is an automatically genera

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-02 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/ --- (Updated May 2, 2014, 3:35 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-02 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/#review11818 --- /branches/11/apps/app_chanspy.c

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-02 Thread Jonathan Rose
> On May 1, 2014, 1:14 p.m., Joshua Colp wrote: > > /branches/11/apps/app_chanspy.c, lines 664-668 > > > > > > Can you explain why the audiohook would not already be attached by the > > previous code here? > > Jos

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/#review11801 --- Ship it! Ship It! - Mark Michelson On April 29, 2014, 10:07

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/#review11799 --- /branches/11/apps/app_chanspy.c

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-01 Thread Joshua Colp
> On May 1, 2014, 6:14 p.m., Joshua Colp wrote: > > /branches/11/apps/app_chanspy.c, lines 664-668 > > > > > > Can you explain why the audiohook would not already be attached by the > > previous code here? Or to b

[asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-04-29 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23381 https://i