Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/ --- (Updated Sept. 18, 2014, 10:32 p.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12912 --- http://pastebin.com/LtPH0bSY -- new diff addresses the last fi

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

> On July 28, 2014, 12:17 p.m., Jonathan Rose wrote: > > /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/full_state.py, > > lines 20-22 > > > > > > This may or may not need t

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12887 --- /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/n

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/ --- (Updated July 25, 2014, 10:54 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12841 --- http://pastebin.com/4617yxRq This has an updated diff that sho

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12840 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12838 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

> On July 17, 2014, 10:48 a.m., opticron wrote: > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/rls_integrity.py, > > lines 57-58 > > > > > > I don't think this is what you intended when at

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12836 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12822 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12815 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12814 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12799 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12797 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12710 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/ --- (Updated July 7, 2014, 3:43 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12466 --- The findings I have are pretty minor, but I'm not sure we shoul

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12366 --- /asterisk/team/group/rls-tests/tests/channels/pjsip/subscripti

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/ --- (Updated June 26, 2014, 10:40 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

> On June 26, 2014, 9:48 p.m., Matt Jordan wrote: > > I think you're missing the pcap portion of the tests (VOIPListener?) Ah, that's because I committed the changes to lib/python/asterisk/pcap.py in revision 5169 of the rls-tests branch. The changes posted here are working copy changes in the

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12358 --- I think you're missing the pcap portion of the tests (VOIPListe

[asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23870 https://i