---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated Aug. 7, 2014, 9:35 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13027
---
/trunk/res/res_pjsip_outbound_publish.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13013
---
/trunk/res/res_pjsip_outbound_publish.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13030
---
/trunk/res/res_pjsip_outbound_publish.c
On Aug. 6, 2014, 5:39 p.m., opticron wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 524-528
https://reviewboard.asterisk.org/r/3780/diff/7/?file=66217#file66217line524
This feels like another implementation of string fields where the
allocation is embedded in the struct.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated Aug. 6, 2014, 6:23 p.m.)
Review request for Asterisk Developers.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13032
---
Ship it!
/trunk/res/res_pjsip_outbound_publish.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13037
---
Ship it!
Ship It!
- Mark Michelson
On Aug. 6, 2014, 6:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated Aug. 5, 2014, 5:37 p.m.)
Review request for Asterisk Developers.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review12969
---
There appears to be the potential for some refcounting badness
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated Aug. 3, 2014, 10:58 p.m.)
Review request for Asterisk
Olle E. Johansson wrote:
On 31 Jul 2014, at 17:28, Joshua Colp reviewbo...@asterisk.org
mailto:reviewbo...@asterisk.org wrote:
This adds two PJSIP modules which add outbound PUBLISH support and an
'asterisk' event type.
I don't think it's a good idea to mix different events in one event
On 31 Jul 2014, at 17:28, Joshua Colp reviewbo...@asterisk.org wrote:
This adds two PJSIP modules which add outbound PUBLISH support and an
'asterisk' event type.
I don't think it's a good idea to mix different events in one event tag. Will
make it hard to handle in proxys and stuff. We
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated July 31, 2014, 3:28 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated July 29, 2014, 2:40 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review12915
---
/trunk/res/res_pjsip_outbound_publish.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review12888
---
/trunk/res/res_pjsip_outbound_publish.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated July 22, 2014, 12:11 p.m.)
Review request for Asterisk
On July 16, 2014, 4:54 p.m., Kevin Harwell wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 203-212
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line203
Should be able to remove the RAII_VAR here and just return the value
from sorcery (no reason for
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated July 21, 2014, 12:14 p.m.)
Review request for Asterisk
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 530-568
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line530
None of this is necessary. pjsip_publishc_init() parses URIs and will
return PJSIP_EINVALIDURI if
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
On July 17, 2014, 4:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_publish_asterisk.c, lines 428-430
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63304#file63304line428
Is there some sort of stasis cache removal you could perform here?
Joshua Colp wrote:
So the
28 matches
Mail list logo
