---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4010/
---
(Updated Sept. 25, 2014, 3:49 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4010/#review13381
---
Almost what I meant.
- The code could use some coding
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4010/
---
(Updated Sept. 24, 2014, 12:54 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4010/#review13382
---
Ship it!
LGTM, other than this minor nit below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4010/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24276
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4010/#review13370
---
Your explanation wasn't immediately obvious to me, but
On Sept. 22, 2014, 8:48 a.m., wdoekes wrote:
/trunk/res/res_musiconhold.c, lines 1428-1433
https://reviewboard.asterisk.org/r/4010/diff/1/?file=67441#file67441line1428
(A) If !MOH_APPOVERRIDECHANNEL, then you're loading this twice. Don't
do that, especially not when there is
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4010/
---
(Updated Sept. 22, 2014, 12:23 p.m.)
Review request for Asterisk
On Sept. 22, 2014, 8:48 a.m., wdoekes wrote:
/trunk/res/res_musiconhold.c, lines 1428-1433
https://reviewboard.asterisk.org/r/4010/diff/1/?file=67441#file67441line1428
(A) If !MOH_APPOVERRIDECHANNEL, then you're loading this twice. Don't
do that, especially not when there is
