Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-10-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4032/ --- (Updated Oct. 1, 2014, 7:13 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-09-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4032/ --- (Updated Sept. 30, 2014, 7:19 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-09-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4032/#review13405 --- Ship it! branches/12/res/res_pjsip_nat.c

[asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-09-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4032/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-09-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4032/#review13400 --- branches/12/res/res_pjsip_nat.c

Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-09-29 Thread opticron
On Sept. 29, 2014, 2:47 p.m., Joshua Colp wrote: branches/12/res/res_pjsip_nat.c, line 49 https://reviewboard.asterisk.org/r/4032/diff/1/?file=67680#file67680line49 What will this do for UDP transport? For those the transport should be empty. udp is also a valid transport along

Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-09-29 Thread Joshua Colp
On Sept. 29, 2014, 7:47 p.m., Joshua Colp wrote: branches/12/res/res_pjsip_nat.c, line 49 https://reviewboard.asterisk.org/r/4032/diff/1/?file=67680#file67680line49 What will this do for UDP transport? For those the transport should be empty. opticron wrote: udp is also a

Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-09-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4032/ --- (Updated Sept. 29, 2014, 6:53 p.m.) Review request for Asterisk