Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/ --- (Updated Oct. 9, 2014, 4:26 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/#review13475 --- Ship it! Ship It! - Joshua Colp On Oct. 9, 2014, 3:44 p.m.,

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/ --- (Updated Oct. 9, 2014, 10:44 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-08 Thread Joshua Colp
> On Oct. 7, 2014, 6:45 p.m., Joshua Colp wrote: > > I don't think this goes far enough. What if I receive no candidates for > > RTCP? It would still crash. > > Kevin Harwell wrote: > I tested for this. The only time it crashes is when there are no RTP > candidates in the list. If there

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-07 Thread Kevin Harwell
> On Oct. 3, 2014, 2:52 p.m., Corey Farrell wrote: > > This patch applies cleanly to Asterisk 11, should it be applied to that > > version as well? yeah it probably should be applied to 11 then as well. - Kevin --- This is an automatic

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-07 Thread Kevin Harwell
> On Oct. 7, 2014, 1:45 p.m., Joshua Colp wrote: > > I don't think this goes far enough. What if I receive no candidates for > > RTCP? It would still crash. I tested for this. The only time it crashes is when there are no RTP candidates in the list. If there are no RTCP candidates in the lis

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/#review13462 --- I don't think this goes far enough. What if I receive no candid

Re: [asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-03 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/#review13449 --- This patch applies cleanly to Asterisk 11, should it be applied

[asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-01 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/ --- Review request for Asterisk Developers and Joshua Colp. Bugs: ASTERISK-243