Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-10 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/ --- (Updated Oct. 10, 2014, 2:29 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread Matt Jordan
> On Oct. 9, 2014, 7:12 a.m., Matt Jordan wrote: > > /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/run-test, line 42 > > > > > > nitpick: As this is a global, it should be LOGGER, not logger. > > > >

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/#review13474 --- Ship it! Ship It! - Matt Jordan On Oct. 9, 2014, 8:49 a.m.,

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread wdoekes
> On Oct. 9, 2014, 12:12 p.m., Matt Jordan wrote: > > /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/run-test, line 42 > > > > > > nitpick: As this is a global, it should be LOGGER, not logger. > > > >

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/ --- (Updated Oct. 9, 2014, 1:49 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/#review13471 --- /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/run-t

Re: [asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-08 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/ --- (Updated Oct. 8, 2014, 4:13 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4051: testsuite: chan_sip: Test dialog leak reported in ASTERISK-20784.

2014-10-08 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/ --- Review request for Asterisk Developers. Bugs: ASTERISK-20784 https://i