Re: [asterisk-dev] [Code Review] 4061: testsuite: Initial test for res_phoneprov

2014-10-09 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4061/ --- (Updated Oct. 9, 2014, 1:03 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4061: testsuite: Initial test for res_phoneprov

2014-10-09 Thread George Joseph
> On Oct. 9, 2014, 11:02 a.m., Matt Jordan wrote: > > asterisk/trunk/tests/phoneprov/res_phoneprov/run-test, lines 49-50 > > > > > > You may want to use a LOGGER.error() here before re-raising the > > exception. > >

Re: [asterisk-dev] [Code Review] 4061: testsuite: Initial test for res_phoneprov

2014-10-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4061/#review13476 --- Ship it! Both of these findings are minor, and I don't think t

[asterisk-dev] [Code Review] 4061: testsuite: Initial test for res_phoneprov

2014-10-08 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4061/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio