Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- (Updated March 24, 2015, 2:26 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/#review14796 --- Ship it! Ship It! - Matt Jordan On March 23, 2015, 4:52 p.m

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- (Updated March 23, 2015, 4:52 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 20, 2015, 11:50 p.m., Corey Farrell wrote: > > /branches/13/include/asterisk/res_pjsip.h, lines 418-419 > > > > > > Is this an ABI issue? Maybe this member should be last in the > > structure for v13 to

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 20, 2015, 11:50 p.m., Corey Farrell wrote: > > /branches/13/include/asterisk/res_pjsip.h, lines 418-419 > > > > > > Is this an ABI issue? Maybe this member should be last in the > > structure for v13 to

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 20, 2015, 11:50 p.m., Corey Farrell wrote: > > /branches/13/include/asterisk/res_pjsip.h, lines 418-419 > > > > > > Is this an ABI issue? Maybe this member should be last in the > > structure for v13 to

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/#review14761 --- /branches/13/include/asterisk/res_pjsip.h

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- (Updated March 20, 2015, 3:50 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- (Updated March 20, 2015, 12:35 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- (Updated March 19, 2015, 10:59 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 13, 2015, 5:19 p.m., gareth wrote: > > Ship It! Well, if we're okay with the patch, then my initial comments still stand :-) {quote} 1. For this to go into Asterisk 13, tests will need to be provided that cover the new parameter. (Really, those tests should be written regardless) 2.

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 8:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. > > rmudgett wrote

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/#review14690 --- Ship it! Ship It! - gareth On March 13, 2015, 5:13 p.m., rm

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 3:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. > > rmudgett wrote

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 3:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. > > rmudgett wrote

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 3:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. > > rmudgett wrote

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- (Updated March 13, 2015, 12:13 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 8:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. > > rmudgett wrote

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 3:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. Actually I'd prefe

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/#review14669 --- 1. For this to go into Asterisk 13, tests will need to be provi

[asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24781 https://i