Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-12-13 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/ --- (Updated Dec. 13, 2013, 10:40 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/#review10402 --- Ship it! Ship It! - opticron On Nov. 21, 2013, 2:24 p.m., K

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-12-12 Thread Kevin Harwell
On Dec. 12, 2013, 9:16 a.m., Kevin Harwell wrote: > > There are other places as well where functions or parameters should return > > the enum instead of a bare int. After speaking with opticron it was decided that for now the items mentioned should remain ints and not be changed to an enumerat

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/#review10390 --- For the most part, this looks good to go. branches/12/res/sta

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-11-21 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/ --- (Updated Nov. 21, 2013, 2:24 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-11-21 Thread opticron
> On Nov. 21, 2013, 12:53 p.m., opticron wrote: > > branches/12/include/asterisk/stasis_app.h, line 180 > > > > > > This should return the enum instead of int. > > Kevin Harwell wrote: > The problem with making

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-11-21 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/ --- (Updated Nov. 21, 2013, 1:50 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-11-21 Thread Kevin Harwell
> On Nov. 21, 2013, 12:53 p.m., opticron wrote: > > branches/12/include/asterisk/stasis_app.h, line 180 > > > > > > This should return the enum instead of int. The problem with making this an enum is currently it i

Re: [asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

2013-11-21 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/#review10246 --- branches/12/include/asterisk/stasis_app.h