Re: [asterisk-dev] [Code Review] 4362: chan_sip Invite: Replaces hangup bug fix

2015-01-27 Thread Joshua Colp
On Jan. 23, 2015, 3:30 p.m., Matt Jordan wrote: After reading through the analysis on the underlying ASTERISK issue, I don't have any findings with the patch. I'm always a little concerned when we have to add a new state to keep track of on the sip_pvt, but right now I can't think of

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
in the path. Previously media would go via the wrong route or not at all. With patch reinvites occur as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
route or not at all. With patch reinvites occur as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
or not at all. With patch reinvites occur as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] PJSIP_AOR and PJSIP_CONTACT Dialplan Functions

2015-01-05 Thread Joshua Colp
exists across different AORs then all channels will show up on all of them (even if different endpoint/AOR). This may be right, this may be wrong. It depends. It also means we would have to make the rules for matching of the Contact between the one on the AOR and the one in the session. -- Joshua

[asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-12 Thread Joshua Colp
://reviewboard.asterisk.org/r/4328/diff/ Testing --- I opened the wiki page. It opened. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 4329: chan_pjsip: Add configure check for presence of 'pjsip_get_dest_info' function.

2015-01-12 Thread Joshua Colp
:26 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4329/ --- (Updated Jan. 12, 2015, 4:26 p.m

Re: [asterisk-dev] [Code Review] 4325: PJSIP: Prevent slow graceful shutdown when outbound publications have not started

2015-01-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4325/#review14145 --- Ship it! Ship It! - Joshua Colp On Jan. 9, 2015, 3:45 p.m

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-09 Thread Joshua Colp
with regards to qualify/contact_status and contacts themselves are stored in the astdb (location.c) Joshua Colp wrote: I think res_sorcery_memory is fine being a dependency because it is actually required by stuff internally. res_sorcery_astdb on the other hand is only required if you

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-09 Thread Joshua Colp
with regards to qualify/contact_status and contacts themselves are stored in the astdb (location.c) Joshua Colp wrote: I think res_sorcery_memory is fine being a dependency because it is actually required by stuff internally. res_sorcery_astdb on the other hand is only required if you

Re: [asterisk-dev] [Code Review] 4285: Bug fixes for ARI Originate/Continue with label support (Continuation of /r/4101)

2015-01-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4285/#review14098 --- Ship it! Ship It! - Joshua Colp On Jan. 6, 2015, 10:21 p.m

[asterisk-dev] [Code Review] 4335: res_pjsip_multihomed: Test to ensure correct message contents when multiple transports exist

2015-01-13 Thread Joshua Colp
it. It passed. Sabotaged it. It failed. Rolled back fix. It failed. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

[asterisk-dev] [Code Review] 4331: res_pjsip_multihomed: Account for when the transport on a message is already correct

2015-01-13 Thread Joshua Colp
- /branches/13/res/res_pjsip_multihomed.c 430545 Diff: https://reviewboard.asterisk.org/r/4331/diff/ Testing --- Ran test and confirmed it failed without patch, passed with patch. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-13 Thread Joshua Colp
--- On Jan. 12, 2015, 1:33 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4328

Re: [asterisk-dev] [Code Review] 4329: chan_pjsip: Add configure check for presence of 'pjsip_get_dest_info' function.

2015-01-13 Thread Joshua Colp
/branches/13/configure UNKNOWN /branches/13/channels/pjsip/dialplan_functions.c 430491 Diff: https://reviewboard.asterisk.org/r/4329/diff/ Testing --- Ran configure check, confirmed it found the support. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-13 Thread Joshua Colp
--- On Jan. 12, 2015, 1:33 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4328

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-13 Thread Joshua Colp
. Joshua Colp wrote: That's not the transport being spoken of. It literally means a SIP URI such as sip:1000@127.0.0.1;transport=tcp I've tweaked things some, added some endpoints, and referenced the applicable section that will be used depending on their configuration. - Joshua

Re: [asterisk-dev] [Code Review] 4325: PJSIP: Prevent slow graceful shutdown when outbound publications have not started

2015-01-09 Thread Joshua Colp
://reviewboard.asterisk.org/r/4325/#comment24628 explicit_publish_destroy? - Joshua Colp On Jan. 9, 2015, 12:07 a.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-09 Thread Joshua Colp
On Jan. 8, 2015, 9:13 p.m., Mark Michelson wrote: branches/13/res/res_pjsip.c, lines 43-45 https://reviewboard.asterisk.org/r/4311/diff/1-2/?file=70130#file70130line43 What caused these dependencies to be added? Kevin Harwell wrote: pjsip_options uses sorcery_memory with

Re: [asterisk-dev] [Code Review] 4336: app_dial: Don't publish DialEnd events twice if GOSUB_RESULT or MACRO_RESULT return an unexpected value

2015-01-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4336/#review14175 --- Ship it! Ship It! - Joshua Colp On Jan. 14, 2015, 3 a.m

Re: [asterisk-dev] [Code Review] 4337: testsuite: Verify that bad MACRO_RESULT/GOSUB_RESULT values don't create multiple DialEnd events

2015-01-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4337/#review14176 --- Ship it! Ship It! - Joshua Colp On Jan. 14, 2015, 3 a.m

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14173 --- Ship it! Ship It! - Joshua Colp On Jan. 9, 2015, 3:37 p.m

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-12 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4328/#review14156 --- On Jan. 12, 2015, 1:33 p.m., Joshua Colp wrote

[asterisk-dev] [Code Review] 4329: chan_pjsip: Add configure check for presence of 'pjsip_get_dest_info' function.

2015-01-12 Thread Joshua Colp
/ Testing --- Ran configure check, confirmed it found the support. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-12 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4328/#review14158 --- On Jan. 12, 2015, 1:33 p.m., Joshua Colp wrote

[asterisk-dev] DNS Support in Asterisk

2015-02-09 Thread Joshua Colp
. Thoughts? Cheers, [1] https://wiki.asterisk.org/wiki/display/AST/AstriDevCon+2014 [2] https://wiki.asterisk.org/wiki/display/~jcolp/DNS+Support+in+Asterisk -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com

Re: [asterisk-dev] DNS Support in Asterisk

2015-02-09 Thread Joshua Colp
, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] DNS Support in Asterisk

2015-02-09 Thread Joshua Colp
Agreed. I'd also add Package Availability to your list. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

[asterisk-dev] [Code Review] 4423: res_sorcery_config: Improve object lookup times using SCIENCE!

2015-02-14 Thread Joshua Colp
was chosen using the debug message depending on the number of objects. Confirmed that objects can still be looked up. Did some spot checking with 10,000+ endpoints to see performance impact. Thanks, Joshua Colp -- _ -- Bandwidth

[asterisk-dev] [Code Review] 4424: res_pjsip: Add show version CLI command.

2015-02-14 Thread Joshua Colp
for this. Diffs - /branches/13/res/res_pjsip/pjsip_cli.c 431750 Diff: https://reviewboard.asterisk.org/r/4424/diff/ Testing --- Ran CLI command. Confirmed it returns the version. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4412: res_http_websocket: websocket write timeout fails to fully disconnect underlying socket

2015-02-10 Thread Joshua Colp
://reviewboard.asterisk.org/r/4412/#comment24958 Add a comment with a description of what 1011 is. I had to look it up, myself. - Joshua Colp On Feb. 10, 2015, 6:06 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply

Re: [asterisk-dev] [Code Review] 4409: res_pjsip: dtls_handler causes Asterisk to crash

2015-02-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4409/#review14434 --- Ship it! Ship It! - Joshua Colp On Feb. 7, 2015, 12:25 a.m

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread Joshua Colp
://reviewboard.asterisk.org/r/4383/#comment24955 App and data could still be empty after this. Besides the minor finding looks good to me. - Joshua Colp On Feb. 4, 2015, 5:31 p.m., George Joseph wrote: --- This is an automatically

Re: [asterisk-dev] DNS Support in Asterisk

2015-02-12 Thread Joshua Colp
, and has a cache. Cheers, [1] https://wiki.asterisk.org/wiki/display/~jcolp/DNS+Support+in+Asterisk#DNSSupportinAsterisk-c-ares [2] https://wiki.asterisk.org/wiki/display/~jcolp/DNS+Support+in+Asterisk#DNSSupportinAsterisk-libunbound -- Joshua Colp Digium, Inc. | Senior Software Developer 445

Re: [asterisk-dev] [Code Review] 4424: res_pjsip: Add show version CLI command.

2015-02-15 Thread Joshua Colp
it returns the version. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4423: res_sorcery_config: Improve object lookup times using SCIENCE!

2015-02-15 Thread Joshua Colp
+ endpoints to see performance impact. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4297: config: Add option to NOT preserve the effective context when changing a template.

2015-01-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4297/#review14100 --- Ship it! Ship It! - Joshua Colp On Dec. 30, 2014, 9:45 p.m

Re: [asterisk-dev] [Code Review] 4272: Testsuite: Verify that bridged channels originated into Stasis and AMI Redirect interoperate properly

2015-01-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4272/#review14101 --- Ship it! Ship It! - Joshua Colp On Dec. 29, 2014, 4:17 p.m

Re: [asterisk-dev] [Code Review] 4308: pjsip: Add PJSIP_AOR and PJSIP_CONTACT dialplan functions

2015-01-05 Thread Joshua Colp
/pjsip/dialplan_functions.c 430178 Diff: https://reviewboard.asterisk.org/r/4308/diff/ Testing --- Ran tests, they're happy. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

2015-01-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4304/#review14121 --- Ship it! Ship It! - Joshua Colp On Jan. 7, 2015, 3:52 p.m

Re: [asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

2015-01-07 Thread Joshua Colp
/res_pjsip_outbound_registration.c https://reviewboard.asterisk.org/r/4304/#comment24602 Calling sip_outbound_registration_apply here is overkill. You should only need to push a sip_outbound_registration_perform task using the existing state. - Joshua Colp On Dec. 31, 2014, 1:41 a.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 4310: pjsip :Add tests for PJSIP_AOR and PJSIP_CONTACT dialplan functions

2015-01-07 Thread Joshua Colp
--- Ran... so far away. Er I mean they passed. Sabotaged some things and confirmed they then failed. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

Re: [asterisk-dev] [Code Review] 4313: func_config: Add ability to retrieve specific occurrence of a variable

2015-01-07 Thread Joshua Colp
the index. It may even be useful to show the highest index it got to. - Joshua Colp On Jan. 2, 2015, 6:39 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4313

Re: [asterisk-dev] [Code Review] 4284: Testsuite: Update ARI test for continuation and add new ARI test for origination to dialplan location

2015-01-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4284/#review14099 --- Ship it! Nice naming of things. - Joshua Colp On Dec. 19

Re: [asterisk-dev] [Code Review] 4306: res_pjsip_mwi: Change MWI Subscription failed message from warning to verb/4.

2015-01-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4306/#review14113 --- Ship it! Ship It! - Joshua Colp On Jan. 7, 2015, 6:09 p.m

Re: [asterisk-dev] [Code Review] 4307: res_pjsip_exten_state: Change 'does not exist' warning to verb/4

2015-01-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4307/#review14114 --- Ship it! Ship It! - Joshua Colp On Jan. 7, 2015, 6:07 p.m

Re: [asterisk-dev] [Code Review] 4306: res_pjsip_mwi: Change MWI Subscription failed message from warning to verb/4.

2015-01-07 Thread Joshua Colp
review. - Joshua Colp On Jan. 1, 2015, 11:29 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4306

Re: [asterisk-dev] [Code Review] 4307: res_pjsip_exten_state: Change 'does not exist' warning to verb/4

2015-01-07 Thread Joshua Colp
review. - Joshua Colp On Jan. 2, 2015, 2:21 a.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4307

Re: [asterisk-dev] [Code Review] 4313: func_config: Add ability to retrieve specific occurrence of a variable

2015-01-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4313/#review14109 --- Ship it! Ship It! - Joshua Colp On Jan. 7, 2015, 4:29 p.m

Re: [asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

2015-01-07 Thread Joshua Colp
://reviewboard.asterisk.org/r/4304/#comment24608 Did you test this? It was a should be fine statement. - Joshua Colp On Jan. 7, 2015, 3:52 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-18 Thread Joshua Colp
-CREATION /trunk/include/asterisk/dns_internal.h PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua Colp

[asterisk-dev] [Code Review] 4512: dns: Add res_resolver_unbound module with unit tests.

2015-03-18 Thread Joshua Colp
. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-16 Thread Joshua Colp
--- On March 13, 2015, 4:04 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-16 Thread Joshua Colp
PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-16 Thread Joshua Colp
PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-16 Thread Joshua Colp
() could be passed to ast_dns_resolve_cancel(), and that's it. This would be similar to how ast_dns_resolve_recurring() works. Joshua Colp wrote: I'm not sure how that would stop the reading of results though. We'd need to add a lock in, which is something I was trying to avoid

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-16 Thread Joshua Colp
., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/ --- (Updated March 16, 2015, 2:33 p.m.) Review request

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-16 Thread Joshua Colp
PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-16 Thread Joshua Colp
PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-16 Thread Joshua Colp
PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] Possible bug: PJSIP stateless behavior when transport=tcp

2015-03-17 Thread Joshua Colp
the underlying issue for the particular configuration. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [Code Review] 4514: Add raw DNS answer to DNS results

2015-03-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4514/#review14738 --- Ship it! Ship It! - Joshua Colp On March 18, 2015, 10:33

Re: [asterisk-dev] [Code Review] 4512: dns: Add res_resolver_unbound module with unit tests.

2015-03-19 Thread Joshua Colp
ran the unit tests and confirmed they pass. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

2015-03-17 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4504/#review14715 --- Ship it! Ship It! - Joshua Colp On March 16, 2015, 5:48

Re: [asterisk-dev] [Code Review] 4499: Support in dialog OPTIONS

2015-03-17 Thread Joshua Colp
not have any impact on the dialog. - Joshua Colp On March 15, 2015, 8:02 a.m., yaron nahum wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4499

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Joshua Colp
On March 9, 2015, 1:19 p.m., Corey Farrell wrote: /branches/13/main/utils.c, line 614 https://reviewboard.asterisk.org/r/4463/diff/2/?file=71877#file71877line614 This looks like it should be applied to 11 as well. I'd go so far as to say that bug fixes as a result of this should be

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Joshua Colp
is really just memory allocation failures, nothing outside the scope of that. - Joshua Colp On March 7, 2015, 6:01 a.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4460/#review14611 --- Ship it! Ship It! - Joshua Colp On March 6, 2015, 11:27

Re: [asterisk-dev] [Code Review] 4456: testsuite: res_pjsip - conflicting endpoint identifiers test

2015-03-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4456/#review14612 --- Ship it! Ship It! - Joshua Colp On March 5, 2015, 11:34

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-10 Thread Joshua Colp
? The timing module was originally written for both, do these changes work for both? - Joshua Colp On March 9, 2015, 6:21 p.m., Justin T. Gibbs wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread Joshua Colp
? - Joshua Colp On March 9, 2015, 7:43 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467

[asterisk-dev] [Code Review] 4469: core: Don't allocate snapshots with locks

2015-03-10 Thread Joshua Colp
/endpoints.c 432666 Diff: https://reviewboard.asterisk.org/r/4469/diff/ Testing --- Did some basic scenarios and confirmed that stuff did not explode. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4475: audiohooks: Update internal sample rate on reads to prevent miscalculation of expected samples

2015-03-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4475/#review14640 --- Ship it! Ship It! - Joshua Colp On March 11, 2015, 5:30

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-03-06 Thread Joshua Colp
://reviewboard.asterisk.org/r/4437/diff/ Testing --- I've logically run through the API and examples to ensure they provide what is needed for the future, to make them as easy as possible to use, and to ensure higher level APIs can be created. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4489: res_pjsip: allow configuration of endpoint identifier query order

2015-03-13 Thread Joshua Colp
, but that's just me - Joshua Colp On March 13, 2015, 5:15 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4489

[asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-11 Thread Joshua Colp
/trunk/include/asterisk/dns_naptr.h PRE-CREATION /trunk/include/asterisk/dns_internal.h PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-13 Thread Joshua Colp
, visit: https://reviewboard.asterisk.org/r/4474/#review14641 --- On March 11, 2015, 11:42 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 4462: DNS core unit tests

2015-03-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4462/#review14679 --- Ship it! Ship It! - Joshua Colp On March 6, 2015, 9:02 p.m

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-13 Thread Joshua Colp
PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4471: Recurring asynchronous DNS query unit tests.

2015-03-13 Thread Joshua Colp
these look good to go. - Joshua Colp On March 10, 2015, 8:53 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4471

Re: [asterisk-dev] [Code Review] 4471: Recurring asynchronous DNS query unit tests.

2015-03-13 Thread Joshua Colp
to the recurring query, causing it to get left behind. - Joshua Colp On March 10, 2015, 8:53 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4471

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-12 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/#review14660 --- On March 11, 2015, 11:42 a.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 4469: core: Don't allocate snapshots with locks

2015-03-10 Thread Joshua Colp
. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4512: dns: Add res_resolver_unbound module with unit tests.

2015-03-24 Thread Joshua Colp
Colp On March 19, 2015, 6:36 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4512/ --- (Updated March 19

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-24 Thread Joshua Colp
On March 23, 2015, 9:45 p.m., Matt Jordan wrote: ./branches/13/apps/app_stasis.c, lines 75-79 https://reviewboard.asterisk.org/r/4519/diff/1/?file=72716#file72716line75 You'll want to document this new channel variable in the XML documentation at the top of the file. Something

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-24 Thread Joshua Colp
://reviewboard.asterisk.org/r/4519/#comment25382 +1 to this. I think following the pattern for other applications that do this is good - they just do success/failed. Just a comment on the code review itself: Please always fill in the Testing Done field with the testing you've done. - Joshua Colp On March 23

Re: [asterisk-dev] res_pjsip_acl: endpoint specific ACL

2015-03-24 Thread Joshua Colp
endpont independence of the ACL, not require additional search endpoint checking ACL. I don't understand what you mean here. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [Code Review] 4518: testsuite: Add PJSIP test for new rpid_immediate option.

2015-03-24 Thread Joshua Colp
on use of transport=, it's not needed here. /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf https://reviewboard.asterisk.org/r/4518/#comment25379 Same for contacts when udp is wanted. The transport= isn't needed. - Joshua Colp On March 23, 2015, 9:55 p.m., rmudgett

Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-03-24 Thread Joshua Colp
configuration for this module also needs to exist somewhere. I think it should also be turned off by default because in some deployments it could start breaking things. (Matching on an endpoint that wasn't expected to previously) - Joshua Colp On March 11, 2015, 4:30 p.m., Dmitriy Serov wrote

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/#review14786 --- Ship it! Ship It! - Joshua Colp On March 19, 2015, 9:59

Re: [asterisk-dev] [Code Review] 4496: res_xmpp: Buddies are always auto-registered when processing the roster

2015-03-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4496/#review14784 --- Ship it! Ship It! - Joshua Colp On March 14, 2015, 3:21

Re: [asterisk-dev] [Code Review] 4512: dns: Add res_resolver_unbound module with unit tests.

2015-03-25 Thread Joshua Colp
/r/4512/diff/ Testing --- Hacked in a query to my own domain and confirmed it worked. Also ran the unit tests and confirmed they pass. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-03-25 Thread Joshua Colp
On March 24, 2015, 3:39 p.m., Mark Michelson wrote: I'm not a big fan of this module for a couple of reasons: 1) The data in the request URI is intended to describe who the call is destined to be sent to, not who the call originated from. There are systems out there where the

Re: [asterisk-dev] PJSIP Realtime Save Contact Info To Database

2015-03-25 Thread Joshua Colp
registered to in the same way that chan_sip used the 'regserver' field. This functionality does not currently exist. [1] https://wiki.asterisk.org/wiki/display/AST/Setting+up+PJSIP+Realtime -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check

Re: [asterisk-dev] PJSIP Realtime Save Contact Info To Database

2015-03-25 Thread Joshua Colp
but no guarantees. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines#AsteriskIssueGuidelines-Howtorequestafeature -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] PJSIP Realtime Save Contact Info To Database

2015-03-25 Thread Joshua Colp
-- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] RFC: Refactor qualify and res_pjsip/endpt_send_request

2015-03-28 Thread Joshua Colp
. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] RFC: Refactor qualify and res_pjsip/endpt_send_request

2015-03-28 Thread Joshua Colp
snip all the things G, it requires an rdata. I'll ponder further. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] RFC: Refactor qualify and res_pjsip/endpt_send_request

2015-03-28 Thread Joshua Colp
, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4557: Tell menuselect that MALLOC_DEBUG conflicts with DEBUG_CHAOS.

2015-03-31 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4557/#review14969 --- Ship it! Ship It! - Joshua Colp On March 29, 2015, 6:30

<    4   5   6   7   8   9   10   11   12   13   >