Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-23 Thread Seth Remington
On Mon, 2004-11-22 at 17:03, Peter Svensson wrote: Shouldn't the echo canceler cut out when it detects the 2.1kHz guard tone? The comments in ecdis.h and zaptel.c seens to indicate that. Yes it does. I see CLI output telling me so every time I receive a fax. -Seth -- Seth Remington

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Seth Remington
On Mon, 2004-11-22 at 14:38, Eric Rees wrote: When I try to patch the Makefile for asterisk with the Apps_makefile.patch from Spandsp I get the following error. patching file Makefile Hunk #1 FAILED at 47. Hunk #2 FAILED at 76. 2 out of 2 hunks FAILED I haven't updated this in a while

RE: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Eric Rees
, 2004 2:10 PM To: Asterisk Users Mailing List - Non-Commercial Discussion Subject: Re: [Asterisk-Users] Patching asterisk for spandsp On Mon, 2004-11-22 at 14:38, Eric Rees wrote: When I try to patch the Makefile for asterisk with the Apps_makefile.patch from Spandsp I get the following error

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Steve Prior
I just ran into this last weekend. I believe that you are using a version of spandsp which is for an older version of Asterisk. First I had to use the most recent version of spandsp from the source (if there is anything later by the time you get there use it):

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Gregory Junker
I was able to patch the apps/Makefile from the v1-0 branch (use -r v1-0 on the CVS command line) with Steve's patchfile, without issues. I included his patchfile for convenience. Which version of the source are you working with? Worst case, you can just look at the patch file too see what

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Gregory Junker
Steve Prior wrote: I just ran into this last weekend. I believe that you are using a version of spandsp which is for an older version of Asterisk. The patch file is not part of the tarball; it's a separate download on the site. I had issues with non-1-0 CVS versions; the v1-0 branch worked

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Steve Prior
Steve Prior wrote: I just ran into this last weekend. I believe that you are using a version of spandsp which is for an older version of Asterisk. ... Good luck Steve I forgot to mention that I didn't yet get fax tone detection working, my success so far has been setting up an extension for

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Gregory Junker
Just for sanity's sake, I went back and read the README on the site again, and it does say: Add the files rxfax.c, txfax.c and dtmftotext.c (the last one has nothing to do with the fax machine, but my makefile patch expects it to be present) You have to grab the dtmftotext.c file as well,

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Steve Prior
Gregory Junker wrote: Just for sanity's sake, I went back and read the README on the site again, and it does say: Add the files rxfax.c, txfax.c and dtmftotext.c (the last one has nothing to do with the fax machine, but my makefile patch expects it to be present) You have to grab the

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Michael Welter
Steve Prior wrote: Steve Prior wrote: I just ran into this last weekend. I believe that you are using a version of spandsp which is for an older version of Asterisk. ... Good luck Steve Just read the patch file and update Makefile by hand. In the patch file, the statements with '+' in column

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Tom Neville
I think I found the problem with the patch.. are you applying that patch to the Makefile in your asterisk source directory?? or to the Makefile in the asterisk/apps directory? I got the same error until I applied it against the asterisk/apps/Makefile. Tom On Nov 22, 2004, at 4:15 PM, Steve

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Steve Prior
Michael Welter wrote: echocancel=yes echocancelwhenbridged=yes Steve Underwood says not to use echo cancel on a fax line. Mike Oops, you're right. I knew I was not supposed to use echocancel, but somehow got these two lines backwards. Steve ___

Re: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Peter Svensson
On Mon, 22 Nov 2004, Steve Prior wrote: Michael Welter wrote: echocancel=yes echocancelwhenbridged=yes Steve Underwood says not to use echo cancel on a fax line. Oops, you're right. I knew I was not supposed to use echocancel, but somehow got these two lines backwards. Shouldn't

RE: [Asterisk-Users] Patching asterisk for spandsp

2004-11-22 Thread Eric Rees
- Non-Commercial Discussion Subject: Re: [Asterisk-Users] Patching asterisk for spandsp I think I found the problem with the patch.. are you applying that patch to the Makefile in your asterisk source directory?? or to the Makefile in the asterisk/apps directory? I got the same error until I