Re: [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling

2018-10-01 Thread Rajkumar Manoharan
On 2018-09-29 03:06, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: - ath10k_htt_tx_txq_update(hw, f_txq); + if (ret == -EBUSY) { + ieee80211_txq_schedule_start(hw, ac); + ieee80211_return_txq(hw, txq); +

Re: [PATCH] ath10k: add missing sanity check on diag download

2018-10-01 Thread Kalle Valo
Brian Norris wrote: > ath10k_hw_diag_fast_download() generally has good boundary checking, but > it misses verifying that the next metadata header actually fits in the > remaining buffer space. Add such a check. > > Fixes: 39501ea64116 ("ath10k: download firmware via diag Copy Engine for >

Re: [PATCH v2] ath10k: Add support for configuring management packet rate

2018-10-01 Thread Kalle Valo
Sriram R wrote: > By default the firmware uses 1Mbps and 6Mbps rate for management packets > in 2G and 5G bands respectively. But when the user selects different > basic rates from the userspace, we need to send the management > packets at the lowest basic rate selected by the user. > > This

Re: [PATCH v3] ath10k: management tx ack rssi capability check

2018-10-01 Thread Kalle Valo
kbuild test robot writes: > Hi Balaji, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on ath6kl/ath-next] > [cannot apply to v4.19-rc3 next-20180910] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > >

Re: [PATCH] ath10k: utilize random MAC address if none is provided

2018-10-01 Thread Kalle Valo
Brian Norris wrote: > Since commit 9d5804662ce1 ("ath10k: retrieve MAC address from system > firmware if provided"), we support pulling our MAC address from system > firmware. Along with this, we should admit that it's possible for system > firmware to be screwed up as well, omitting the MAC

Re: [PATCH] ath10k: Add debugfs support to get power save state change of STA

2018-10-01 Thread Kalle Valo
Maharaja Kennadyrajan wrote: > This patch helps to get the power save state change of each peer > connected to the AP. With WMI_10_4_PEER_STA_PS_STATECHG_EVENTID > event, ps state of each peer is reported to user space via > debugfs. > > Use the below command to get the ps state of each sta: >

Re: [PATCH 1/2] ath10k: Move napi_enable to hif_start for consistent pairing

2018-10-01 Thread Kalle Valo
Govind Singh wrote: > There is unbalanced napi_{enable,disable}() behavior as they > are being called from hif_snoc_{power_up/stop). > > The fix is to call napi_enable() from ath10k_snoc_hif_start() > so that it matches with napi_disable() being called from > ath10k_snoc_hif_stop(). > >

Re: [PATCHv2] ath10k: Advertize beacon_int_min_gcd as 100 while bring up multi vaps

2018-10-01 Thread Kalle Valo
Maharaja Kennadyrajan wrote: > With the latest firmware design, the beacon interval should be > greater than 100 to bring the multiple vaps. > > Set beacon_int_min_gcd to 100, when the wmi service > WMI_SERVICE_VDEV_DIFFERENT_BEACON_INTERVAL_SUPPORT is enabled > in the firmware. If not,

Re: [PATCH] ath10k: Remove duplicated includes

2018-10-01 Thread Kalle Valo
YueHaibing wrote: > remove duplicated include from ath10k driver. > > Signed-off-by: YueHaibing > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 4be3b05e7a83 ath10k: remove duplicated includes -- https://patchwork.kernel.org/patch/10599605/

Re: [PATCH] ath10k: Add support for configuring management packet rate

2018-10-01 Thread Kalle Valo
Sriram R wrote: > By default the firmware uses 1Mbps and 6Mbps rate for management packets > in 2G and 5G bands respectively. But when the user selects different > basic rates from the userspace, we need to send the management > packets at the lowest basic rate selected by the user. > > This

Re: [PATCH 1/2] ath10k: add default value for num_peers in WMI TLV init

2018-10-01 Thread Kalle Valo
Erik Stromdahl wrote: > The hw_params value will only be used if it was explicitly set in the > global hw_params array. > > This makes it possible to have the num_peers member unset. > > Signed-off-by: Erik Stromdahl > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of

Re: [PATCH v2] ath10k: Fix tx status flag setting for management frames

2018-10-01 Thread Kalle Valo
Rakesh Pillai wrote: > The tx_status for management frames is being filled > incorrectly in the flags of skb_cb. This incorrect > flag setting causes the upper layers to consider that > the particular frame was not transmitted properly, > leading to improper behavior. > > Set the

Re: [PATCH v2] ath10k: fix vdev-start timeout on error

2018-10-01 Thread Kalle Valo
gree...@candelatech.com wrote: > The vdev-start-response message should cause the > completion to fire, even in the error case. Otherwise, > the user still gets no useful information and everything > is blocked until the timeout period. > > Add some warning text to print out the invalid status

Re: [PATCH 3/3] ath10k: Add support to configure ftm responder role

2018-10-01 Thread Kalle Valo
Sebastian Gottschall writes: > Am 15.08.2018 um 02:30 schrieb Pradeep Kumar Chitrapu: >> + if (test_bit(WMI_SERVICE_RTT, ar->wmi.svc_map)) >> +wiphy_ext_feature_set(ar->hw->wiphy, >> + NL80211_EXT_FEATURE_SET_FTM_RESPONDER); >> + > > not sure if

[PATCH v2 4/4] dts: arm64/sdm845: Enable iommu for WCN3990 wifi module device node

2018-10-01 Thread Govind Singh
WCN3990 wifi module can optionally make use of the IOMMU. Add phandle to the iommu and stream id of wifi iommu block. Signed-off-by: Govind Singh --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi

[PATCH v2 3/4] dt: bindings: add bindings for wifi iommu node

2018-10-01 Thread Govind Singh
WCN3990 wifi module can optionally make use of the IOMMU. Add binding documentation for phandle to the IOMMU and the stream id of wifi iommu block. Signed-off-by: Govind Singh --- .../devicetree/bindings/net/wireless/qcom,ath10k.txt| 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v2 1/4] dt: bindings: add missing dt properties for WCN3990 wifi node

2018-10-01 Thread Govind Singh
Add missing optional properties in WCN3990 wifi node. Signed-off-by: Govind Singh --- .../bindings/net/wireless/qcom,ath10k.txt | 28 ++- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt

[PATCH v2 2/4] dts: arm64/sdm845: Add WCN3990 WLAN module device node

2018-10-01 Thread Govind Singh
Add device node for the ath10k SNOC platform driver probe and add resources required for WCN3990 on SDM845 soc. Signed-off-by: Govind Singh --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 7 +++ arch/arm64/boot/dts/qcom/sdm845.dtsi| 26 + 2 files changed, 33

[PATCH v2 0/4] Enable ath10k wcn3990 wifi driver support on sdm845

2018-10-01 Thread Govind Singh
This series enables ath10k wifi driver support for WCN3990 target on sdm845 SOC. This series also updates the missing dt binding documentation and adds optional iommu property. sdm845 dtsi changes in this series are based on top of https://patchwork.kernel.org/cover/10573121/ change. Changes

Re: [PATCH v5 2/3] mac80211: support FTM responder configuration/statistics

2018-10-01 Thread Johannes Berg
On Thu, 2018-09-20 at 17:30 -0700, Pradeep Kumar Chitrapu wrote: > New bss param ftm_responder is used to notify the driver to > enable fine timing request (FTM) responder role in AP mode. > > Plumb the new cfg80211 API for FTM responder statistics through to > the driver API in mac80211. This

Re: [PATCH v5 1/3] cfg80211: support FTM responder configuration/statistics

2018-10-01 Thread Johannes Berg
On Thu, 2018-09-20 at 17:30 -0700, Pradeep Kumar Chitrapu wrote: > Allow userspace to enable fine timing measurement responder > functionality with configurable lci/civic parameters in AP mode. > This can be done at AP start or changing beacon parameters. > > A new EXT_FEATURE flag is introduced