Re: [PATCH 1/3] ath10k: Add wmi tlv vdev subtype for mesh in WCN3990

2019-05-07 Thread Kalle Valo
Surabhi Vishnoi wrote: > There is a disparity in wmi and wmi tlv vdev subtype > enum for WMI_VDEV_SUBTYPE_MESH_11S. > > Add different enum for wmi tlv vdev subtype to support > vdev of subtype mesh 11s for WCN3990. > > Tested HW: WCN3990 > > Signed-off-by: Surabhi Vishnoi > Signed-off-by:

Re: [PATCH v2] ath10k: add peer id check in ath10k_peer_find_by_id

2019-05-07 Thread Kalle Valo
Wen Gong wrote: > For some SDIO chip, the peer id is 65535 for MPDU with error status, > then test_bit will trigger buffer overflow for peer's memory, if kasan > enabled, it will report error. > > Reason is when station is in disconnecting status, firmware do not delete > the peer info since it

Re: [PATCH] ath10k: change swap mail box config for UTF mode of SDIO

2019-05-07 Thread Kalle Valo
Wen Gong wrote: > For SDIO chip, it does not have HTT connect step in boot phase of UTF > mode, so it does not need the swap configuration for UTF mode, otherwise > it will trigger UTF load fail. For normal mode, it is swap between HTT > and WMI, for UTF mode, it does not have HTT, so it can not

Re: [PATCH] ath10k: Check tx_stats before use it

2019-05-07 Thread Kalle Valo
Yingying Tang wrote: > tx_stats will be freed and set to NULL before debugfs_sta node is > removed in station disconnetion process. So if read the debugfs_sta > node there may be NULL pointer error. Add check for tx_stats before > use it to resove this issue. > > Signed-off-by: Yingying Tang >

Re: [PATCH v2] ath10k: fix different tx duration output

2019-05-07 Thread Kalle Valo
Lei Wang wrote: > TX duration output of tx_stats in debugfs and station dump had big > difference because they got tx duration value from different statistic > data. We should use the same statistic data. > > Tested: QCA988X with firmware ver 10.2.4-1.0-00043 > > Signed-off-by: Lei Wang >

Re: [PATCH] ath10k: Fix the wrong value of enums for wmi tlv stats id

2019-05-07 Thread Kalle Valo
Surabhi Vishnoi wrote: > The enum value for WMI_TLV_STAT_PDEV, WMI_TLV_STAT_VDEV > and WMI_TLV_STAT_PEER is wrong, due to which the vdev stats > are not received from firmware in wmi_update_stats event. > > Fix the enum values for above stats to receive all stats > from firmware in

Re: [PATCH][next] ath10k: coredump: use struct_size() helper

2019-05-07 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace code of the following form: > > sizeof(*ce_hdr) + CE_COUNT *

Re: [PATCH] ath10k: Fix encoding for protected management frames

2019-05-07 Thread Kalle Valo
Rakesh Pillai wrote: > Currently the protected management frames are > not appended with the MIC_LEN which results in > the protected management frames being encoded > incorrectly. > > Add the extra space at the end of the protected > management frames to fix this encoding error for > the

Re: [PATCH][next] ath10k: Use struct_size() helper

2019-05-07 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, change the following form: > > sizeof(*rx) + (sizeof(struct

Re: [PATCH] ath10k: rx_duration update for fw_stats debugfs entry

2019-05-07 Thread Kalle Valo
Balaji Pothunoori wrote: > Currently instant rx_duration always fetching as zero > in fw_stats debugfs entry if extended peer stats event > supports. > > This patch updates instant rx_duration in fw_stats entry > based on extended peer stats and maintaining backward > compatibility for

Re: [PATCH] ath10k: Fix the tx stats bytes & packets parsing

2019-05-07 Thread Kalle Valo
Brandon Huang wrote: > In tx_stats debugfs, txrate->flags may contain multiple bits. For > example, RATE_INFO_FLAGS_SHORT_GI could be set, and tx stats bytes > and packets will be not updated correctly. > > Fix this issue by using bit operation to check txrate->flags. > > Tested HW: QCA9984 >

Re: [PATCH] ath10k: Modify CE4 src buffer entries to 2048 for WCN3990

2019-05-07 Thread Kalle Valo
Govind Singh wrote: > CE4 is host to target HTT tx pipe, tx completion are not served > on time when CPU is loaded and this cause ce src ring full condition > due to less no of src buffer entries. > > To mitigate the issue increase CE4 src buffer entries to 2048. > > Testing: > Tested

Re: [PATCH] ath10k: Move board id and fw version logging to info level

2019-05-07 Thread Kalle Valo
Govind Singh wrote: > Board id and fw version is not printed by default in qmi > cap response message. Move board id and fw version logging > to info level for default logging. > > [ 34.005399] ath10k_snoc a00.wifi: qmi chip_id 0x30b chip_family 0x4001 > board_id 0xff soc_id 0x4007 >

Re: [PATCH 1/2] ath10k: Extended the HTT stats support to retrieve Mu-MIMO related stats

2019-05-07 Thread Kalle Valo
Maharaja Kennadyrajan wrote: > Extended the bit mask value of the HTT stats to get the Mu-MIMO > related stats via tracing. > > Signed-off-by: Maharaja Kennadyrajan > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 14bf9217d66d ath10k: Extended the HTT

Re: [PATCH v2] ath10k: fix different tx duration output

2019-05-07 Thread Toke Høiland-Jørgensen
le...@codeaurora.org writes: > On 2019-04-18 16:07, Toke Høiland-Jørgensen wrote: >> le...@codeaurora.org writes: >> >>> On 2019-04-17 17:26, Toke Høiland-Jørgensen wrote: Lei Wang writes: > TX duration output of tx_stats in debugfs and station dump had big > difference

Re: [PATCH v2] ath10k: fix different tx duration output

2019-05-07 Thread leiwa
On 2019-04-18 16:07, Toke Høiland-Jørgensen wrote: le...@codeaurora.org writes: On 2019-04-17 17:26, Toke Høiland-Jørgensen wrote: Lei Wang writes: TX duration output of tx_stats in debugfs and station dump had big difference because they got tx duration value from different statistic

Re: Re: [ath10k USB QCA9377] Driver fails to initialize Linksys device

2019-05-07 Thread Jose Saldana
Dear Vincent, I have seen your post about Linksys WUSB6100M USB (QCA9377), and I would like to know if you finally managed to make it work. http://lists.infradead.org/pipermail/ath10k/2018-September/012071.html I am using kernel 4.19. Thanks in advance! Jose

Re: [PATCH] ath11k:print firmware info during boot

2019-05-07 Thread Manikanta Pubbisetty
On 2019-05-07 15:14, Manikanta Pubbisetty wrote: Print fw info like version, time stamp and fw build info during boot. Signed-off-by: Manikanta Pubbisetty --- drivers/net/wireless/ath/ath11k/qmi.c | 20 drivers/net/wireless/ath/ath11k/qmi.h | 1 + 2 files changed, 17

[PATCH] ath11k:print firmware info during boot

2019-05-07 Thread Manikanta Pubbisetty
Print fw info like version, time stamp and fw build info during boot. Signed-off-by: Manikanta Pubbisetty --- drivers/net/wireless/ath/ath11k/qmi.c | 20 drivers/net/wireless/ath/ath11k/qmi.h | 1 + 2 files changed, 17 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] ath10k: remove mmc_hw_reset while hif power down

2019-05-07 Thread Kalle Valo
+ Ulf to give comments from SDIO point of view Wen Gong writes: >> -Original Message- >> From: ath10k On Behalf Of Grant >> Grundler >> Sent: Saturday, May 4, 2019 2:01 AM >> To: Wen Gong >> Cc: linux-wirel...@vger.kernel.org; ath10k@lists.infradead.org >> Subject: [EXT] Re: [PATCH]