Re: [PATCH 2/2] ath11k: use cumulative survey statistics

2020-05-04 Thread Markus Theil
Am 05.05.2020 um 01:37 schrieb Rajkumar Manoharan: On 2020-05-04 08:41, Markus Theil wrote: ath11k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead to unexpectedly small results, e.g. when hostapd

Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings

2020-05-04 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > On 5/4/20 06:54, Kalle Valo wrote: >> "Gustavo A. R. Silva" writes: >> >>> Hi Arnd, >>> >>> On 4/30/20 16:30, Arnd Bergmann wrote: gcc-10 started warning about out-of-bounds access for zero-length arrays: In file included from drivers/net/wire

[ath6kl:pending] BUILD SUCCESS f67211fa324660ac4dc2d5b57412ab8c2e826090

2020-05-04 Thread kbuild test robot
randconfig-a001-20200503 s390 randconfig-a001-20200504 xtensa randconfig-a001-20200504 sh randconfig-a001-20200504 openrisc randconfig-a001-20200504 csky randconfig-a001-20200504 s390 randconfig-a001-20200430 xtensa

[ath6kl:ath-next] BUILD SUCCESS 657680cc86ca4b5d49b5bb313b1320fb8439528c

2020-05-04 Thread kbuild test robot
randconfig-a001-20200504 xtensa randconfig-a001-20200504 sh randconfig-a001-20200504 openrisc randconfig-a001-20200504 csky randconfig-a001-20200504 s390 randconfig-a001-20200505 xtensa randconfig

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

2020-05-04 Thread Ben Greear
On 05/04/2020 04:52 PM, Rajkumar Manoharan wrote: On 2020-05-04 16:49, Ben Greear wrote: On 05/04/2020 04:46 PM, Rajkumar Manoharan wrote: On 2020-05-04 08:41, Markus Theil wrote: ath10k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

2020-05-04 Thread Rajkumar Manoharan
On 2020-05-04 16:49, Ben Greear wrote: On 05/04/2020 04:46 PM, Rajkumar Manoharan wrote: On 2020-05-04 08:41, Markus Theil wrote: ath10k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead to unexp

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

2020-05-04 Thread Ben Greear
On 05/04/2020 04:46 PM, Rajkumar Manoharan wrote: On 2020-05-04 08:41, Markus Theil wrote: ath10k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead to unexpectedly small results, e.g. when hostap

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

2020-05-04 Thread Rajkumar Manoharan
On 2020-05-04 08:41, Markus Theil wrote: ath10k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead to unexpectedly small results, e.g. when hostapd uses survey data and iw survey dump is invoked in p

Re: [PATCH 2/2] ath11k: use cumulative survey statistics

2020-05-04 Thread Rajkumar Manoharan
On 2020-05-04 08:41, Markus Theil wrote: ath11k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead to unexpectedly small results, e.g. when hostapd uses survey data and iw survey dump is invoked in p

[PATCH] ath10k: Replace zero-length array with flexible-array

2020-05-04 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

Re: [PATCH 2/2] ath11k: use cumulative survey statistics

2020-05-04 Thread Sven Eckelmann
On Monday, 4 May 2020 17:41:22 CEST Markus Theil wrote: [...] > diff --git a/drivers/net/wireless/ath/ath11k/wmi.c > b/drivers/net/wireless/ath/ath11k/wmi.c > index c2a972377687..322ddfda5bfd 100644 > --- a/drivers/net/wireless/ath/ath11k/wmi.c > +++ b/drivers/net/wireless/ath/ath11k/wmi.c > @@ -5

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

2020-05-04 Thread Markus Theil
On 5/4/20 6:29 PM, Sven Eckelmann wrote: > On Monday, 4 May 2020 17:41:21 CEST Markus Theil wrote: >> ath10k currently reports survey results for the last interval between each >> invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this >> can lead to unexpectedly small results, e.g.

Re: [PATCH 1/2] ath10k: use cumulative survey statistics

2020-05-04 Thread Sven Eckelmann
On Monday, 4 May 2020 17:41:21 CEST Markus Theil wrote: > ath10k currently reports survey results for the last interval between each > invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this > can lead to unexpectedly small results, e.g. when hostapd uses survey > data and iw survey

Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings

2020-05-04 Thread Gustavo A. R. Silva
On 5/4/20 06:54, Kalle Valo wrote: > "Gustavo A. R. Silva" writes: > >> Hi Arnd, >> >> On 4/30/20 16:30, Arnd Bergmann wrote: >>> gcc-10 started warning about out-of-bounds access for zero-length >>> arrays: >>> >>> In file included from drivers/net/wireless/ath/ath10k/core.h:18, >>>

[PATCH 1/2] ath10k: use cumulative survey statistics

2020-05-04 Thread Markus Theil
ath10k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead to unexpectedly small results, e.g. when hostapd uses survey data and iw survey dump is invoked in parallel. Fix this by returning cumulative re

[PATCH 2/2] ath11k: use cumulative survey statistics

2020-05-04 Thread Markus Theil
ath11k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this can lead to unexpectedly small results, e.g. when hostapd uses survey data and iw survey dump is invoked in parallel. Fix this by returning cumulative re

[PATCH] ath10k: Remove msdu from idr when management pkt send fails

2020-05-04 Thread Rakesh Pillai
Currently when the sending of any management pkt via wmi command fails, the packet is being unmapped freed in the error handling. But the idr entry added, which is used to track these packet is not getting removed. Hence, during unload, in wmi cleanup, all the entries in IDR are removed and the co

Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings

2020-05-04 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > Hi Arnd, > > On 4/30/20 16:30, Arnd Bergmann wrote: >> gcc-10 started warning about out-of-bounds access for zero-length >> arrays: >> >> In file included from drivers/net/wireless/ath/ath10k/core.h:18, >> from drivers/net/wireless/ath/ath10k/htt_

Re: [PATCH] Allow qca988x family to support ack rssi of tx data packets.

2020-05-04 Thread Kalle Valo
(Fixing top posting and adding Yibo) John Deere <24601dee...@gmail.com> writes: > On 4/30/20 6:28 PM, Kalle Valo wrote: >> John Deere <24601dee...@gmail.com> writes: >> >>> Hello, >>> Firmwares tested : 10.4-3.9.0.1-00036 >>> >>> The firmware above is unavailable anywhere. >> >> It's here: >

Re: [PATCH net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large()

2020-05-04 Thread Kalle Valo
Wei Yongjun wrote: > 'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed > before leaving from the error handling cases, otherwise it will cause > memory leak. > > Fixes: d58f466a5dee ("ath10k: add large size for BMI download data for SDIO") > Signed-off-by: Wei Yongjun > Signed