[PATCH] ath10k: add option for chip-id based BDF selection

2020-10-19 Thread Abhishek Kumar
In some devices difference in chip-id should be enough to pick the right BDF. Add another support for chip-id based BDF selection. With this new option, ath10k supports 2 fallback options. The board name with chip-id as option looks as follows board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320'

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-19 Thread Nick Desaulniers
On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote: > > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > From: Tom Rix > > > > This is a upcoming change to clean up a new warning treewide. > > I am wondering if the change could be one mega patch (see below) or > > normal patch

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-19 Thread Jason Gunthorpe
On Mon, Oct 19, 2020 at 12:42:15PM -0700, Nick Desaulniers wrote: > On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote: > > > > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This is a upcoming change to clean up a new warning treewide. > > > I am

Re: [PATCH] wireless: remove unneeded break

2020-10-19 Thread Gustavo A. R. Silva
On 10/19/20 11:20, Joe Perches wrote: > On Mon, 2020-10-19 at 10:54 -0500, Gustavo A. R. Silva wrote: >> On 10/19/20 10:21, Joe Perches wrote: >>> On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote: On 19/10/2020 17:05, t...@redhat.com wrote: > From: Tom Rix > > A

Re: [PATCH] wireless: remove unneeded break

2020-10-19 Thread Tom Rix
On 10/19/20 9:20 AM, Joe Perches wrote: > On Mon, 2020-10-19 at 10:54 -0500, Gustavo A. R. Silva wrote: >> On 10/19/20 10:21, Joe Perches wrote: >>> On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote: On 19/10/2020 17:05, t...@redhat.com wrote: > From: Tom Rix > > A

Re: [PATCH] wireless: remove unneeded break

2020-10-19 Thread Joe Perches
On Mon, 2020-10-19 at 10:54 -0500, Gustavo A. R. Silva wrote: > On 10/19/20 10:21, Joe Perches wrote: > > On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote: > > > On 19/10/2020 17:05, t...@redhat.com wrote: > > > > From: Tom Rix > > > > > > > > A break is not needed if it is preceded

Re: [PATCH] wireless: remove unneeded break

2020-10-19 Thread Gustavo A. R. Silva
On 10/19/20 10:21, Joe Perches wrote: > On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote: >> On 19/10/2020 17:05, t...@redhat.com wrote: >>> From: Tom Rix >>> >>> A break is not needed if it is preceded by a return or goto >>> >>> Signed-off-by: Tom Rix >>> diff --git

Re: [PATCH] wireless: remove unneeded break

2020-10-19 Thread Joe Perches
On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote: > On 19/10/2020 17:05, t...@redhat.com wrote: > > From: Tom Rix > > > > A break is not needed if it is preceded by a return or goto > > > > Signed-off-by: Tom Rix > > diff --git a/drivers/net/wireless/intersil/p54/eeprom.c > >

Re: [PATCH] wireless: remove unneeded break

2020-10-19 Thread Christian Lamparter
On 19/10/2020 17:05, t...@redhat.com wrote: From: Tom Rix A break is not needed if it is preceded by a return or goto Signed-off-by: Tom Rix diff --git a/drivers/net/wireless/intersil/p54/eeprom.c b/drivers/net/wireless/intersil/p54/eeprom.c index 5bd35c147e19..3ca9d26df174 100644 ---

[PATCH] wireless: remove unneeded break

2020-10-19 Thread trix
From: Tom Rix A break is not needed if it is preceded by a return or goto Signed-off-by: Tom Rix --- drivers/net/wireless/ath/ath10k/htt_rx.c | 1 - drivers/net/wireless/ath/ath6kl/testmode.c | 1 - drivers/net/wireless/ath/ath9k/hw.c | 1 -