Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-12-18 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Thu, 2018-11-15 at 09:10 -0800, Toke Høiland-Jørgensen wrote: >> Louie Lu writes: >> >> > Hi Rajkumar, Toke, >> > >> > I found the series (v3,4/6) remove the debugfs remove reset station's >> > airtime method, and didn't added at here. >> > >> > Not sure how to

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-12-18 Thread Dave Taht
Johannes Berg writes: > On Thu, 2018-11-15 at 09:10 -0800, Toke Høiland-Jørgensen wrote: >> Louie Lu writes: >> >> > Hi Rajkumar, Toke, >> > >> > I found the series (v3,4/6) remove the debugfs remove reset >> > station's >> > airtime method, and didn't added at here. >> > >> > Not sure how

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-12-18 Thread Johannes Berg
On Thu, 2018-11-15 at 09:10 -0800, Toke Høiland-Jørgensen wrote: > Louie Lu writes: > > > Hi Rajkumar, Toke, > > > > I found the series (v3,4/6) remove the debugfs remove reset station's > > airtime method, and didn't added at here. > > > > Not sure how to help this kind of situation, do I

Re: [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-12-04 Thread Toke Høiland-Jørgensen
Felix Fietkau writes: >> diff --git a/net/mac80211/status.c b/net/mac80211/status.c >> index aa4afbf0abaf..a1f1256448f5 100644 >> --- a/net/mac80211/status.c >> +++ b/net/mac80211/status.c >> @@ -818,6 +818,12 @@ static void __ieee80211_tx_status(struct ieee80211_hw >> *hw, >>

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread David Lang
On Mon, 19 Nov 2018, Dave Taht wrote: I'm not sure if this was a fluke or not, but at Starbucks recently I sat outside, right next to their window, and could not scan their AP at all. Previously, I sat inside, 3 feet away through the glass, and got great signal. I wonder what that was all

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Dave Taht
On Mon, Nov 19, 2018 at 4:52 PM Simon Barber wrote: > > Low-e glass, it’s a thin metallic film used to reflect infra-red to keep heat > in or out. Totally blocks/reflects RF. Very cool. I imagine it's hell on cell too? I can see this stuff becoming very popular in places where keeping the good

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Dave Taht
On Mon, Nov 19, 2018 at 4:20 PM Ben Greear wrote: > > On 11/19/2018 04:13 PM, Dave Taht wrote: > > On Mon, Nov 19, 2018 at 3:56 PM Ben Greear wrote: > >> > >> On 11/19/2018 03:47 PM, Dave Taht wrote: > >>> On Mon, Nov 19, 2018 at 3:30 PM Simon Barber wrote: > > > > On Nov

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Ben Greear
On 11/19/2018 04:13 PM, Dave Taht wrote: On Mon, Nov 19, 2018 at 3:56 PM Ben Greear wrote: On 11/19/2018 03:47 PM, Dave Taht wrote: On Mon, Nov 19, 2018 at 3:30 PM Simon Barber wrote: On Nov 19, 2018, at 2:44 PM, Toke Høiland-Jørgensen wrote: Dave Taht writes: Toke Høiland-Jørgensen

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Dave Taht
On Mon, Nov 19, 2018 at 3:56 PM Ben Greear wrote: > > On 11/19/2018 03:47 PM, Dave Taht wrote: > > On Mon, Nov 19, 2018 at 3:30 PM Simon Barber wrote: > >> > >> > >> > >> On Nov 19, 2018, at 2:44 PM, Toke Høiland-Jørgensen wrote: > >> > >> Dave Taht writes: > >> > >> Toke Høiland-Jørgensen

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Ben Greear
On 11/19/2018 03:47 PM, Dave Taht wrote: On Mon, Nov 19, 2018 at 3:30 PM Simon Barber wrote: On Nov 19, 2018, at 2:44 PM, Toke Høiland-Jørgensen wrote: Dave Taht writes: Toke Høiland-Jørgensen writes: Felix Fietkau writes: On 2018-11-14 18:40, Toke Høiland-Jørgensen wrote: This

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Dave Taht
On Mon, Nov 19, 2018 at 3:30 PM Simon Barber wrote: > > > > On Nov 19, 2018, at 2:44 PM, Toke Høiland-Jørgensen wrote: > > Dave Taht writes: > > Toke Høiland-Jørgensen writes: > > Felix Fietkau writes: > > On 2018-11-14 18:40, Toke Høiland-Jørgensen wrote: > > This part doesn't really make

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Dave Taht
Toke Høiland-Jørgensen writes: > Dave Taht writes: > >> Toke Høiland-Jørgensen writes: >> >>> Felix Fietkau writes: >>> On 2018-11-14 18:40, Toke Høiland-Jørgensen wrote: >> This part doesn't really make much sense to me, but maybe I'm >> misunderstanding how the code works.

Re: [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Toke Høiland-Jørgensen
Hi Felix Thinking a bit more about this, I think that rather than having the driver work around the API as in your example... > do { > struct ieee80211_txq *pending_txq[4]; > int n_pending_txq = 0; > int i; > > if (hwq->pending < 4) > break;p > >

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Toke Høiland-Jørgensen
Dave Taht writes: > Toke Høiland-Jørgensen writes: > >> Felix Fietkau writes: >> >>> On 2018-11-14 18:40, Toke Høiland-Jørgensen wrote: > This part doesn't really make much sense to me, but maybe I'm > misunderstanding how the code works. > Let's assume we have a driver like ath9k

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-19 Thread Dave Taht
Toke Høiland-Jørgensen writes: > Felix Fietkau writes: > >> On 2018-11-14 18:40, Toke Høiland-Jørgensen wrote: This part doesn't really make much sense to me, but maybe I'm misunderstanding how the code works. Let's assume we have a driver like ath9k or mt76, which tries to keep

Re: [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-15 Thread Toke Høiland-Jørgensen
Felix Fietkau writes: > On 2018-11-14 18:40, Toke Høiland-Jørgensen wrote: >>> This part doesn't really make much sense to me, but maybe I'm >>> misunderstanding how the code works. >>> Let's assume we have a driver like ath9k or mt76, which tries to keep a >>> number of aggregates in the

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-15 Thread Toke Høiland-Jørgensen
Louie Lu writes: > Hi Rajkumar, Toke, > > I found the series (v3,4/6) remove the debugfs remove reset station's > airtime method, and didn't added at here. > > Not sure how to help this kind of situation, do I need a separate > patch to fix this, or posting the patch here is fine? This is fine;

Re: [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-15 Thread Felix Fietkau
On 2018-11-14 18:40, Toke Høiland-Jørgensen wrote: >> This part doesn't really make much sense to me, but maybe I'm >> misunderstanding how the code works. >> Let's assume we have a driver like ath9k or mt76, which tries to keep a >> number of aggregates in the hardware queue, and the hardware

Re: [Make-wifi-fast] [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-15 Thread Louie Lu
Hi Rajkumar, Toke, I found the series (v3,4/6) remove the debugfs remove reset station's airtime method, and didn't added at here. Not sure how to help this kind of situation, do I need a separate patch to fix this, or posting the patch here is fine? From

Re: [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-14 Thread Toke Høiland-Jørgensen
Felix Fietkau writes: > On 2018-11-12 23:51, Rajkumar Manoharan wrote: >> From: Toke Høiland-Jørgensen >> >> This adds airtime accounting and scheduling to the mac80211 TXQ >> scheduler. A new callback, ieee80211_sta_register_airtime(), is added >> that drivers can call to report airtime usage

Re: [PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-14 Thread Felix Fietkau
On 2018-11-12 23:51, Rajkumar Manoharan wrote: > From: Toke Høiland-Jørgensen > > This adds airtime accounting and scheduling to the mac80211 TXQ > scheduler. A new callback, ieee80211_sta_register_airtime(), is added > that drivers can call to report airtime usage for stations. > > When

[PATCH v3 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-12 Thread Rajkumar Manoharan
From: Toke Høiland-Jørgensen This adds airtime accounting and scheduling to the mac80211 TXQ scheduler. A new callback, ieee80211_sta_register_airtime(), is added that drivers can call to report airtime usage for stations. When airtime information is present, mac80211 will schedule TXQs