Re: [ath5k-devel] A humble request - LED support for Compaq

2009-02-28 Thread Bob Copeland
On Fri, Feb 27, 2009 at 11:27:19PM +0100, Paride Legovini wrote: But I suppose that placing this in debugfs is temporary, as the end users (afaik) are not supposed to use it. Am I wrong? Well, we could leave it in debugfs forever to make it easy for users to test out the combinations without

Re: [ath5k-devel] [PATCH/RFC 1/3] ath5k: add debug files for led pin and polarity

2009-02-28 Thread Dave Taggart
Thanks Bob. I'll make this patch as soon as I have time. -- dave -- Bob Copeland wrote: Add two new debugfs files, led_pin and led_polarity, to make it easier for users to find the right numbers for their system. Signed-off-by: Bob Copeland m...@bobcopeland.com --- Dave, Please

Re: [ath5k-devel] [PATCH/RFC 3/3] ath5k: use a table for LED parameters

2009-02-28 Thread Bob Copeland
On Sat, Feb 28, 2009 at 07:13:03PM +0100, Jiri Slaby wrote: +(id-subdevice == (u16) PCI_ANY_ID || + id-subdevice == dev-subsystem_device)); +} This is wrong. Subids might legally be 0x which is (u16)PCI_ANY_ID. Why not use pci_device_id table with pci_match_id

Re: [ath5k-devel] [PATCH 1/1] ath5k: fix hw rate index condition

2009-02-28 Thread Jiri Slaby
On 15.2.2009 14:47, Bob Copeland wrote: On Mon, Feb 02, 2009 at 01:27:39PM +0530, Dhaval Giani wrote: So I finally managed to hit this on 2.6.29-rc3. It is hard to reproduce, so I hope so much information is enough to give you a good guess. This time it hit while trying to connect to an open

Re: [ath5k-devel] [PATCH 1/1] ath5k: fix hw rate index condition

2009-02-28 Thread Pavel Roskin
On Thu, 2009-02-26 at 21:27 -0500, Bob Copeland wrote: Actually, I remembered in the dark recesses of my moldering brain that someone had a lost patch for this a while ago, so I searched the archives. Pavel, ok to add your s-o-b? Since my patch was dropped and the new patch was implemented