Re: [ath5k-devel] ath5k on 2.6.32 report different regdom a crash kernel on onload

2010-03-28 Thread Luis R. Rodriguez
On Sun, Mar 28, 2010 at 7:26 PM, Bob Copeland wrote: > On Sun, Mar 28, 2010 at 12:50:52PM +0200, Jiri Moravec wrote: >> country 98: >>         (2402 - 2482 @ 40), (N/A, 20) >>         (5170 - 5250 @ 40), (N/A, 20), NO-OUTDOOR >>         (5250 - 5330 @ 40), (N/A, 20), NO-OUTDOOR, DFS >>         (54

Re: [ath5k-devel] ath5k on 2.6.32 report different regdom a crash kernel on onload

2010-03-28 Thread Bob Copeland
On Sun, Mar 28, 2010 at 12:50:52PM +0200, Jiri Moravec wrote: > country 98: > (2402 - 2482 @ 40), (N/A, 20) > (5170 - 5250 @ 40), (N/A, 20), NO-OUTDOOR > (5250 - 5330 @ 40), (N/A, 20), NO-OUTDOOR, DFS > (5490 - 5710 @ 40), (N/A, 27), DFS > > ~ # crda > COUNTRY envir

Re: [ath5k-devel] [PATCH 10/10] ath5k: Adaptive Noise Immunity (ANI) Implementation

2010-03-28 Thread Bruno Randolf
On Monday 29 March 2010 11:02:12 Bob Copeland wrote: > On Thu, Mar 25, 2010 at 02:49:52PM +0900, Bruno Randolf wrote: > > + } else if (strncmp(buf, "noise-low", 8) == 0) { > > + ath5k_ani_set_noise_immunity_level(sc->ah, 0); > > + } else if (strncmp(buf, "noise-high", 9) == 0) { > >

Re: [ath5k-devel] Making changes in source code & check working

2010-03-28 Thread Bob Copeland
On Mon, Mar 29, 2010 at 02:52:11AM +0530, anmol khurana wrote: > I mean ,in most softwares ,we have the source code which can be simply > compiled and run to see the changes made in the source code . > Is it the same with driver's or do I need to do something different ? Yes, just change and reloa

Re: [ath5k-devel] [PATCH 10/10] ath5k: Adaptive Noise Immunity (ANI) Implementation

2010-03-28 Thread Bob Copeland
On Thu, Mar 25, 2010 at 02:49:52PM +0900, Bruno Randolf wrote: > + } else if (strncmp(buf, "noise-low", 8) == 0) { > + ath5k_ani_set_noise_immunity_level(sc->ah, 0); > + } else if (strncmp(buf, "noise-high", 9) == 0) { The number of characters here is off-by-one. I also tried

[ath5k-devel] [PATCH 3/5] ath5k: clean up queue manipulation

2010-03-28 Thread Bob Copeland
Review spotted a couple of strange invocations to ieee80211_wake_queues that could potentially cause problems: - queues are awakened in the calibration tasklet before phy calibration, and then again after calibration - queues are awakened inside reset when we're trying to drain the ath5k

[ath5k-devel] [PATCH 5/5] ath5k: add bounds check to pdadc table

2010-03-28 Thread Bob Copeland
We check the bounds on pdadc once when correcting for negative curves but not when we later copy values from from the pdadc_tmp array, leading to a potential overrun. Although we shouldn't hit this case in practice, let's be consistent. Reported-by: Dan Carpenter Signed-off-by: Bob Copeland ---

[ath5k-devel] [PATCH 4/5] ath5k: fix race condition in tx desc processing

2010-03-28 Thread Bob Copeland
From: Bob Copeland As pointed out by Benoit Papillault, there is a potential race condition between the host and the hardware in reading the next link in the transmit descriptor list: cpu0 hw tx for buf completed raise tx_ok interrupt process buf

[ath5k-devel] [PATCH 1/5] ath5k: fix off-by-one in pilot magnitude mask

2010-03-28 Thread Bob Copeland
If the symbol offset is 46, it will be counted in both the third and fourth bytes of the mask, and in this case the shift will be negative which can pollute high order bits in the mask. This may negatively impact OFDM symbol detection. Signed-off-by: Bob Copeland --- drivers/net/wireless/ath/at

[ath5k-devel] [PATCH 2/5] ath5k: correct channel setting for 2.5 mhz spacing

2010-03-28 Thread Bob Copeland
These channels aren't selectable anyway, but our calculations for 2.5 mhz frequencies are incorrect. The value is supposed to be: (frequency - reference) * (10/25) i.e., divide by 2.5, but we were instead doing: (10 * frequency - reference) / 25. Additionally, the check for (frequency % 5

[ath5k-devel] [PATCH 0/5] Misc bug fixes

2010-03-28 Thread Bob Copeland
Hi, Here are some patches for ath5k, based on top of Bruno's ANI patchset. None of these are really serious; I don't know of any specific reports that are fixed by these. Comments welcome. Bob Copeland (5): ath5k: fix off-by-one in pilot magnitude mask ath5k: correct channel setting for 2.5

[ath5k-devel] Making changes in source code & check working

2010-03-28 Thread anmol khurana
Hi As a part of my wireless network project ,I wanted to work on ath5k drivers and see how it effects my wireless card working. What is the easiest way of making changes in the driver source code and compile them to see changes made to the wireless card workings ? I mean ,in most softwares ,we ha

Re: [ath5k-devel] ath5k on 2.6.32 report different regdom a crash kernel on unload

2010-03-28 Thread Jiri Moravec
On 28.3.2010 14:44, Jiri Moravec wrote: > On 28.3.2010 13:16, Lukáš Turek wrote: >> On 28.3.2010 12:50 Jiri Moravec wrote: >>> As I reported 22.3., first founded atheros card reported these channels as >>> disabled. If this card is second, then these channels on second card are >>> enabled. WHY? >>

Re: [ath5k-devel] ath5k on 2.6.32 report different regdom a crash kernel on onload

2010-03-28 Thread Jiri Moravec
On 28.3.2010 13:16, Lukáš Turek wrote: > On 28.3.2010 12:50 Jiri Moravec wrote: >> As I reported 22.3., first founded atheros card reported these channels as >> disabled. If this card is second, then these channels on second card are >> enabled. WHY? > I reported the same problem recently: > https:

Re: [ath5k-devel] ath5k on 2.6.32 report different regdom a crash kernel on onload

2010-03-28 Thread Lukáš Turek
On 28.3.2010 12:50 Jiri Moravec wrote: > As I reported 22.3., first founded atheros card reported these channels as > disabled. If this card is second, then these channels on second card are > enabled. WHY? I reported the same problem recently: https://lists.ath5k.org/pipermail/ath5k-devel/2010-Mar

[ath5k-devel] ath5k on 2.6.32 report different regdom a crash kernel on onload

2010-03-28 Thread Jiri Moravec
I noticed another strange issues on my system: 1) card ignore regdom (on 2.6.33 kernel, wireless fully functional) ~ # iw phy Wiphy phy0 Band 1: Frequencies: