Re: [ath5k-devel] corrupted data

2010-05-28 Thread Bruno Randolf
On Friday 28 May 2010 14:49:12 Robert Brown wrote: I wasn't able to match up instances of data corruption with the repeated packets I was printing or with the device resets. Since the corruption doesn't seem to occur when ath5k_tasklet_rx sends the same data twice, something more

Re: [ath5k-devel] corrupted data

2010-05-28 Thread Bruno Randolf
On Friday 28 May 2010 00:14:18 Bob Copeland wrote: Well the invariant is supposed to be that we are always behind where the hardware is. If that holds, the hardware can't loop around and write into the buffer we are currently processing, because we'd have to add the buffer back to the

[ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Jussi Kivilinna
Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM enabled. With ASPM ath5k will eventually stall on heavy traffic with often 'unsupported jumbo' warnings appearing. Disabling ASPM L0s/L1 in ath5k

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Pavel Roskin
On Fri, 2010-05-28 at 13:09 +0300, Jussi Kivilinna wrote: +static void __ath5k_disable_aspm(struct pci_dev *pdev, u16 state); +static void ath5k_disable_aspm(struct pci_dev *pdev, u16 state); Forward declarations should not be needed unless the functions are called before

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Luis R. Rodriguez
On Fri, May 28, 2010 at 3:09 AM, Jussi Kivilinna jussi.kivili...@mbnet.fi wrote: Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM enabled. With ASPM ath5k will eventually stall on heavy traffic

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Jussi Kivilinna
Quoting Luis R. Rodriguez mcg...@gmail.com: On Fri, May 28, 2010 at 3:09 AM, Jussi Kivilinna jussi.kivili...@mbnet.fi wrote: Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM enabled. With

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Jussi Kivilinna
Quoting Pavel Roskin pro...@gnu.org: On Fri, 2010-05-28 at 13:09 +0300, Jussi Kivilinna wrote: +static void __ath5k_disable_aspm(struct pci_dev *pdev, u16 state); +static void ath5k_disable_aspm(struct pci_dev *pdev, u16 state); Forward declarations should not be needed

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Pavel Roskin
On Fri, 2010-05-28 at 21:25 +0300, Jussi Kivilinna wrote: I used code from e1000e which does this same way, which now suddenly reminds me of that ath5k is dual lisenced, right? Can I even reuse code from GPL driver in ath5k? That's another reason why we don't want this code to be all over