[ath5k-devel] [PATCH RFC] ath5k: Clean up retry limit configuration

2010-12-08 Thread Bruno Randolf
ath5k should take the retry limit (short and long) configuration from mac80211 instead of relyinng on some dubious initial values. More importantly, the register definition for retry configuration AR5212 was wrong, and simply copied over from AR5210. Update the register definitions from the

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Bruno Randolf
When ath5k doesn't get retry limits from above it uses the following defaults on dcu. For now i don't think we use local-hw.conf.short_frame_max_tx_count for that so the default is ah_limit_tx_retries (AR5K_INIT_TX_RETRY) but seems it's wrong and we should fix it... /* Tx retry

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Jonathan Guerin
On Wed, Dec 8, 2010 at 6:06 PM, Bruno Randolf b...@einfach.org wrote: When ath5k doesn't get retry limits from above it uses the following defaults on dcu. For now i don't think we use local-hw.conf.short_frame_max_tx_count for that so the default is ah_limit_tx_retries

Re: [ath5k-devel] [PATCH RFC] ath5k: Clean up retry limit configuration

2010-12-08 Thread Bruno Randolf
On Wed December 8 2010 18:05:33 Nick Kossifidis wrote: 2010/12/8 Bruno Randolf b...@einfach.org: ath5k should take the retry limit (short and long) configuration from mac80211 instead of relyinng on some dubious initial values. More importantly, the register definition for retry

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Bob Copeland
On Mon, Dec 6, 2010 at 3:14 AM, Bruno Randolf b...@einfach.org wrote: But it seems weird that there are so many retransmissions. The default maximum numbers of retransmissions should be 7 for short frames and 4 for long frames (dot11[Short|Long]RetryLimit), and this is what is set as defaults

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Bob Copeland
On Wed, Dec 8, 2010 at 11:08 AM, Bob Copeland m...@bobcopeland.com wrote: On Mon, Dec 6, 2010 at 3:14 AM, Bruno Randolf b...@einfach.org wrote: But it seems weird that there are so many retransmissions. The default maximum numbers of retransmissions should be 7 for short frames and 4 for long

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread John W. Linville
On Wed, Dec 08, 2010 at 11:45:39AM -0500, Bob Copeland wrote: On Wed, Dec 8, 2010 at 11:08 AM, Bob Copeland m...@bobcopeland.com wrote: On Mon, Dec 6, 2010 at 3:14 AM, Bruno Randolf b...@einfach.org wrote: But it seems weird that there are so many retransmissions. The default maximum

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Bob Copeland
On Wed, Dec 8, 2010 at 11:56 AM, John W. Linville linvi...@tuxdriver.com wrote: Found the patch: https://patchwork.kernel.org/patch/359722/ Are you posting that for merging?  Or just for testing? Testing -- I only compile tested it but it seemed relevant to this thread. -- Bob Copeland %%

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Bob Copeland
On Wed, Dec 8, 2010 at 12:06 PM, Bob Copeland m...@bobcopeland.com wrote: On Wed, Dec 8, 2010 at 11:56 AM, John W. Linville linvi...@tuxdriver.com wrote: Found the patch: https://patchwork.kernel.org/patch/359722/ Are you posting that for merging?  Or just for testing? Testing -- I only

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Sedat Dilek
On Wed, Dec 8, 2010 at 6:11 PM, Bob Copeland m...@bobcopeland.com wrote: On Wed, Dec 8, 2010 at 12:06 PM, Bob Copeland m...@bobcopeland.com wrote: On Wed, Dec 8, 2010 at 11:56 AM, John W. Linville linvi...@tuxdriver.com wrote: Found the patch: https://patchwork.kernel.org/patch/359722/ Are

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Bob Copeland
On Wed, Dec 8, 2010 at 12:50 PM, Sedat Dilek sedat.di...@googlemail.com wrote: I have applied, compiled and loaded new mac80211 kernel-module. What could be a good test-case? Hrm, not sure, something like this? - config the retry limits with iwconfig - bring up the interface and connect to

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Jonathan Guerin
On Thu, Dec 9, 2010 at 2:08 AM, Bob Copeland m...@bobcopeland.com wrote: On Mon, Dec 6, 2010 at 3:14 AM, Bruno Randolf b...@einfach.org wrote: But it seems weird that there are so many retransmissions. The default maximum numbers of retransmissions should be 7 for short frames and 4 for long

Re: [ath5k-devel] [PATCH RFC] ath5k: Clean up retry limit configuration

2010-12-08 Thread Jonathan Guerin
On Wed, Dec 8, 2010 at 7:05 PM, Nick Kossifidis mickfl...@gmail.com wrote: 2010/12/8 Bruno Randolf b...@einfach.org: ath5k should take the retry limit (short and long) configuration from mac80211 instead of relyinng on some dubious initial values. More importantly, the register definition