Re: [ath5k-devel] [PATCH] ath5k: merge ath5k_hw and ath5k_softc

2011-07-14 Thread Nick Kossifidis
2011/7/13 Pavel Roskin pro...@gnu.org: Both ath5k_hw and ath5k_softc represent one instance of the hardware. This duplication is historical and is not needed anymore. Keep the name ath5k_hw for the merged structure and ah for the variable pointing to it.  ath5k_hw is shorter than ath5k_softc,

Re: [ath5k-devel] [PATCH] ath5k: merge ath5k_hw and ath5k_softc

2011-07-14 Thread Pavel Roskin
On 07/14/2011 07:37 AM, Nick Kossifidis wrote: I believe we should keep struct ath5k_hw inside ath5k.h because it's being used everywhere, not only on base.c. Having it inside base.h is misleading, we'd better just kill base.h. Well, I tried that too, but it produced a bigger patch (to be

[ath5k-devel] [RFC PATCH v2] ath5k: merge ath5k_hw and ath5k_softc

2011-07-14 Thread Pavel Roskin
Both ath5k_hw and ath5k_softc represent one instance of the hardware. This duplication is historical and is not needed anymore. Keep the name ath5k_hw for the merged structure and ah for the variable pointing to it. ath5k_hw is shorter than ath5k_softc, more descriptive and more widely used.

Re: [ath5k-devel] [PATCH] ath5k: merge ath5k_hw and ath5k_softc

2011-07-14 Thread Bob Copeland
On Thu, Jul 14, 2011 at 4:36 PM, Pavel Roskin pro...@gnu.org wrote: By the way, carl9170 has one private structure, not two, so there is nothing wrong with it.  ath9k has two structures, but merging them is much more problematic, as the separation between the code is deeper, and there are even