Re: [ath5k-devel] [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

2008-12-19 Thread Bob Copeland
On Wed, 17 Dec 2008 13:35:27 -0500, John W. Linville wrote > > Okay. I think the one you took before, plus my diff should be sufficient. > > Do you want me to submit a proper patch that just fixes the TX, or should > > we regroup and combine both up into a single patch on our side? > > Just your n

Re: [ath5k-devel] [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

2008-12-17 Thread John W. Linville
On Wed, Dec 17, 2008 at 12:40:56PM -0500, Bob Copeland wrote: > On Wed, Dec 17, 2008 at 10:55 AM, John W. Linville > wrote: > > On Tue, Dec 16, 2008 at 10:22:39AM -0500, Bob Copeland wrote: > >> Well, anyway John already picked up your earlier (better, IMHO) patch. > >> Now we just need to fix the

Re: [ath5k-devel] [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

2008-12-17 Thread Bob Copeland
On Wed, Dec 17, 2008 at 10:55 AM, John W. Linville wrote: > On Tue, Dec 16, 2008 at 10:22:39AM -0500, Bob Copeland wrote: >> Well, anyway John already picked up your earlier (better, IMHO) patch. >> Now we just need to fix the tx descriptors :) > > Based on that comment, I'm dropping this version

Re: [ath5k-devel] [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

2008-12-17 Thread John W. Linville
On Tue, Dec 16, 2008 at 10:22:39AM -0500, Bob Copeland wrote: > On Mon, Dec 15, 2008 at 4:06 PM, Benoit PAPILLAULT > wrote: > > > frames. To me, the bug we have seen when receiving a ACK frame in > > monitor mode was not because "ACK is a small control frame", it was > > because the header length

Re: [ath5k-devel] [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

2008-12-16 Thread Bob Copeland
On Tue, Dec 16, 2008 at 10:22 AM, Bob Copeland wrote: > On Mon, Dec 15, 2008 at 4:06 PM, Benoit PAPILLAULT > wrote: > Well, anyway John already picked up your earlier (better, IMHO) patch. > Now we just need to fix the tx descriptors :) i.e. something like the following (attached as well becaus

Re: [ath5k-devel] [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

2008-12-16 Thread Bob Copeland
On Mon, Dec 15, 2008 at 4:06 PM, Benoit PAPILLAULT wrote: > frames. To me, the bug we have seen when receiving a ACK frame in > monitor mode was not because "ACK is a small control frame", it was > because the header length we computed was smaller than what the hardware > considered. It's becaus

Re: [ath5k-devel] [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

2008-12-15 Thread Jouni Malinen
On Mon, Dec 15, 2008 at 03:34:58PM +0100, Benoit Papillault wrote: > This patch is close to the original code except that > ieee80211_get_hdrlen_from_skb() has been replaced by > ath5k_hw_get_hdrlen_from_skb() which is specific to Atheros hardware. The same > probably applies to ath9k as well. Mos

Re: [ath5k-devel] [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

2008-12-15 Thread Benoit PAPILLAULT
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jouni Malinen a écrit : > On Mon, Dec 15, 2008 at 03:34:58PM +0100, Benoit Papillault wrote: >> This patch is close to the original code except that >> ieee80211_get_hdrlen_from_skb() has been replaced by >> ath5k_hw_get_hdrlen_from_skb() which is spec

Re: [ath5k-devel] [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

2008-12-15 Thread Bob Copeland
On Mon, Dec 15, 2008 at 9:34 AM, Benoit Papillault wrote: > From: Benoit PAPILLAULT > > This patch is close to the original code except that > ieee80211_get_hdrlen_from_skb() has been replaced by > ath5k_hw_get_hdrlen_from_skb() which is specific to Atheros hardware. The same > probably applies t