Re: [ath5k-devel] [PATCH] ath5k: fix exp off-by-one when computing OFDM delta slope

2009-05-13 Thread Bob Copeland
On Wed, May 13, 2009 at 2:25 PM, John W. Linville wrote: > That's fine.  But what about this last bit? > >        http://bugzilla.kernel.org/show_bug.cgi?id=13077#c6 > > Is that not needed? I think it is needed, but I checked back through 2.6.27 and it has the same (probably buggy) code, so I thi

Re: [ath5k-devel] [PATCH] ath5k: fix exp off-by-one when computing OFDM delta slope

2009-05-13 Thread John W. Linville
On Wed, May 13, 2009 at 11:14:39AM -0400, Bob Copeland wrote: > > From: Forrest Zhang > > Commit e8f055f0c3ba226ca599c14c2e5fe829f6f57cbb subtly changed the > code that computes floating point values for the PHY3_TIMING register > such that the exponent is off by a decimal point, which can cause

[ath5k-devel] [PATCH] ath5k: fix exp off-by-one when computing OFDM delta slope

2009-05-13 Thread Bob Copeland
From: Forrest Zhang Commit e8f055f0c3ba226ca599c14c2e5fe829f6f57cbb subtly changed the code that computes floating point values for the PHY3_TIMING register such that the exponent is off by a decimal point, which can cause problems with OFDM channel operation. get_bitmask_order() actually retur