Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-09 Thread Lukáš Turek
On 9.12.2009 14:30 you wrote: > That's definitely completely inaccurate. Even before you get packet > loss, as you lower the ACK timeout value, you will first start to get an > increase in the number of retransmissions. In fact the ping was "ping -s 1472 -c 1000 -i 0.002", that's more than 12Mbit/

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-09 Thread Felix Fietkau
On 2009-12-09 2:12 PM, Lukáš Turek wrote: >> Some hardware internally calculates the ACK timeout based on the >> configured slot time. Broadcom does it this way. >> Maybe adjusting the ACK timeout without adjusting the slot time works, >> but it'll probably interfere with CSMA. > Ahteros is not Bro

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-09 Thread Lukáš Turek
On 9.12.2009 02:48 Felix Fietkau wrote: > Twice the propagation time (in microseconds) for a signal to cross the > maximum distance between the most distant allowable STAs that are slot > synchronized. Oh, I missed that... And maybe I'm starting to understand it: the slots are in fact some kind of

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-08 Thread Felix Fietkau
On 2009-12-09 2:15 AM, Lukáš Turek wrote: > On 7.12.2009 10:48 you wrote: >> ACKTimeout is: aSIFSTime + aSlotTime + aPHY-RX-START-Delay > 802.11a uses SIFS of 16 µs and 9 µs slot time, that's 25 µs in total. > However, > the athctrl calculation uses 21 µs ACK timeout for zero distance. And I kno

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-08 Thread Lukáš Turek
On 7.12.2009 10:48 you wrote: > ACKTimeout is: aSIFSTime + aSlotTime + aPHY-RX-START-Delay 802.11a uses SIFS of 16 µs and 9 µs slot time, that's 25 µs in total. However, the athctrl calculation uses 21 µs ACK timeout for zero distance. And I know the result is correct, as we are using it on 70 l

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-07 Thread Felix Fietkau
Lukáš Turek wrote: > On 6.12.2009 20:20 Felix Fietkau wrote: >> In 2.4 GHz, regular slot time is 20 usec, unless short slot is enabled. >> 2.4 GHz with short slot and 5 GHz both use 9 usec. > Yes, but where the short slot time gets enabled? According to the standard > (don't have the reference now

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-06 Thread Lukáš Turek
On 6.12.2009 20:20 Felix Fietkau wrote: > In 2.4 GHz, regular slot time is 20 usec, unless short slot is enabled. > 2.4 GHz with short slot and 5 GHz both use 9 usec. Yes, but where the short slot time gets enabled? According to the standard (don't have the reference now) all stations in 802.11g n

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-06 Thread Felix Fietkau
Lukáš Turek wrote: > On 6.12.2009 19:34 Felix Fietkau wrote: >> This part is wrong. The slot time can be either short or long, based on >> configuration and PHY type. > I did some test, and the value returned by ath5k_hw_get_slot_time was always > 9, even when connected to 802.11b-only AP. I didn'

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-06 Thread Lukáš Turek
On 6.12.2009 19:34 Felix Fietkau wrote: > This part is wrong. The slot time can be either short or long, based on > configuration and PHY type. I did some test, and the value returned by ath5k_hw_get_slot_time was always 9, even when connected to 802.11b-only AP. I didn't try the turbo mode, thou

Re: [ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-06 Thread Felix Fietkau
Lukáš Turek wrote: > The callback sets slot time as specified in IEEE 802.11-2007 section > 17.3.8.6 (for 20MHz channels only for now) and ACK and CTS timeouts > using calculations taken from Madwifi's athctrl. The values are > persistent, they are restored after device reset. > > Signed-off-by: L

[ath5k-devel] [PATCH 4/4] ath5k: Implement mac80211 callback set_coverage

2009-12-06 Thread Lukáš Turek
The callback sets slot time as specified in IEEE 802.11-2007 section 17.3.8.6 (for 20MHz channels only for now) and ACK and CTS timeouts using calculations taken from Madwifi's athctrl. The values are persistent, they are restored after device reset. Signed-off-by: Lukas Turek <8...@praha12.net> -