Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-27 Thread Bruno Randolf
On Thu January 27 2011 14:51:05 Vasanthakumar Thiagarajan wrote: > On Wed, Jan 26, 2011 at 04:06:02PM +0530, Bruno Randolf wrote: > > On Wed January 26 2011 18:37:00 Jouni Malinen wrote: > > > On Wed, Jan 26, 2011 at 11:38:53AM +0900, Bruno Randolf wrote: > > > > Even without my patch, WEP does not

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-26 Thread Vasanthakumar Thiagarajan
On Wed, Jan 26, 2011 at 04:06:02PM +0530, Bruno Randolf wrote: > On Wed January 26 2011 18:37:00 Jouni Malinen wrote: > > On Wed, Jan 26, 2011 at 11:38:53AM +0900, Bruno Randolf wrote: > > > Even without my patch, WEP does not work with multiple vifs. > > > > Are you sure about that? > > Yes, I'

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-26 Thread Bruno Randolf
On Wed January 26 2011 18:37:00 Jouni Malinen wrote: > On Wed, Jan 26, 2011 at 11:38:53AM +0900, Bruno Randolf wrote: > > Even without my patch, WEP does not work with multiple vifs. > > Are you sure about that? Yes, I'm sure. Please test it yourself, if you don't believe me. :) I'm using ath5k,

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-26 Thread Jouni Malinen
On Wed, Jan 26, 2011 at 11:38:53AM +0900, Bruno Randolf wrote: > Even without my patch, WEP does not work with multiple vifs. Are you sure about that? Why would there be any issues in using software crypto for decrypting WEP frames while everything else is done in hardware? I'm really interested

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-26 Thread Johannes Berg
On Wed, 2011-01-26 at 18:21 +0900, Bruno Randolf wrote: > On Wed January 26 2011 17:29:48 Johannes Berg wrote: > > On Wed, 2011-01-26 at 11:38 +0900, Bruno Randolf wrote: > > > Even without my patch, WEP does not work with multiple vifs. > > > (As far as i understand it, with WEP the lookup is just

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-26 Thread Bruno Randolf
On Wed January 26 2011 17:29:48 Johannes Berg wrote: > On Wed, 2011-01-26 at 11:38 +0900, Bruno Randolf wrote: > > Even without my patch, WEP does not work with multiple vifs. > > (As far as i understand it, with WEP the lookup is just done based on the > > key index in the WLAN header field. mac80

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-26 Thread Johannes Berg
On Wed, 2011-01-26 at 11:38 +0900, Bruno Randolf wrote: > Even without my patch, WEP does not work with multiple vifs. > (As far as i understand it, with WEP the lookup is just done based on the key > index in the WLAN header field. mac80211 (or is it hostapd?) sets up both > keys > for both i

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-25 Thread Bruno Randolf
On Wed January 26 2011 03:32:05 Jouni Malinen wrote: > On Tue, Jan 25, 2011 at 01:15:49PM +0900, Bruno Randolf wrote: > > In AP mode hardware encryption for WEP was not used on the RX side > > because there was a mismatch in the key indices. The key index in the > > WLAN header is 0-3 while the har

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-25 Thread Jouni Malinen
On Tue, Jan 25, 2011 at 01:15:49PM +0900, Bruno Randolf wrote: > In AP mode hardware encryption for WEP was not used on the RX side because > there was a mismatch in the key indices. The key index in the WLAN header is > 0-3 while the hardware key cache was configured for key indices >= 4. This is

[ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-24 Thread Bruno Randolf
In AP mode hardware encryption for WEP was not used on the RX side because there was a mismatch in the key indices. The key index in the WLAN header is 0-3 while the hardware key cache was configured for key indices >= 4. This is ok for transmit but received packets were not decrypted in HW and the