Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS

2009-12-06 Thread Johannes Berg
On Sun, 2009-12-06 at 18:22 +0100, Lukáš Turek wrote: The new attribute NL80211_ATTR_WIPHY_COVERAGE_CLASS sets IEEE 802.11 Coverage Class, This patch assumes that all hardware supports this, which is not really what you want. You'll want to know if it can't be set. Yes, we assume rts/cts can be

Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS

2009-12-06 Thread Lukáš Turek
On 6.12.2009 19:01 Johannes Berg wrote: This patch assumes that all hardware supports this, which is not really what you want. You'll want to know if it can't be set. Yes, we assume rts/cts can be set always, but that's a _much_ safer bet. If the hardware does not support it, the operation will

Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS

2009-12-06 Thread Johannes Berg
On Sun, 2009-12-06 at 19:45 +0100, Lukáš Turek wrote: On 6.12.2009 19:01 Johannes Berg wrote: This patch assumes that all hardware supports this, which is not really what you want. You'll want to know if it can't be set. Yes, we assume rts/cts can be set always, but that's a _much_ safer

Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS

2009-12-06 Thread Lukáš Turek
On 6.12.2009 19:49 Johannes Berg wrote: Umm, no it won't, that's only with your specific mac80211 implementation. Try on rndis for instance. I looked at the rndis driver, but it seems it could be configured via wireless extensions only, it does not define cfg80211_ops at all, so I think it

Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS

2009-12-06 Thread Lukáš Turek
On 6.12.2009 20:28 Lukáš Turek wrote: I looked at the rndis driver, but it seems it could be configured via wireless extensions only, it does not define cfg80211_ops at all, so I think it cannot be managed via nl80211 and I don't see your point there... Sorry, I looked at some older version of

Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS

2009-12-06 Thread Lukáš Turek
On 6.12.2009 19:49 Johannes Berg wrote: Umm, no it won't, that's only with your specific mac80211 implementation. Try on rndis for instance. So I looked at both drivers that define set_wiphy_params: rndis and iwmc3200wifi. Both ignore WIPHY_PARAM_RETRY_SHORT and WIPHY_PARAM_RETRY_LONG, so

Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS

2009-12-06 Thread Johannes Berg
On Sun, 2009-12-06 at 22:59 +0100, Lukáš Turek wrote: On 6.12.2009 19:49 Johannes Berg wrote: Umm, no it won't, that's only with your specific mac80211 implementation. Try on rndis for instance. So I looked at both drivers that define set_wiphy_params: rndis and iwmc3200wifi. Both ignore