Re: [ath9k-devel] [PATCH] ath9k_htc: avoid memcpy when downloading firmware

2015-03-02 Thread Eric Dumazet
On Tue, 2015-03-03 at 12:24 +0800, Fred Chou wrote: From: Fred Chou fred.chou...@gmail.com The temporary buffer to hold firmware data is not really needed, and memcpy can be avoided by using data pointer instead. Signed-off-by: Fred Chou fred.chou...@gmail.com ---

Re: [ath9k-devel] stop_machine lockup issue in 3.9.y.

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 14:11 -0700, Tejun Heo wrote: (cc'ing wireless crowd, tglx and Ingo. The original thread is at http://thread.gmane.org/gmane.linux.kernel/1500158/focus=55005 ) Hello, Ben. On Wed, Jun 05, 2013 at 01:58:31PM -0700, Ben Greear wrote: Hmm, wonder if I found it. I

Re: [ath9k-devel] stop_machine lockup issue in 3.9.y.

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 20:14 -0700, Tejun Heo wrote: Ah, so, that's why it's showing up now. We probably have had the same issue all along but it used to be masked by the softirq limiting. Do you care to revive the 10 iterations limit so that it's limited by both the count and timing? We

Re: [ath9k-devel] stop_machine lockup issue in 3.9.y.

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 20:50 -0700, Ben Greear wrote: On 06/05/2013 08:46 PM, Eric Dumazet wrote: We use in Google a patch triggering warning is a thread holds the cpu without taking care to need_resched() for more than xx ms Well, I'm sure that patch works nicely until the clock stops

Re: [ath9k-devel] stop_machine lockup issue in 3.9.y.

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 20:41 -0700, Ben Greear wrote: On 06/05/2013 08:26 PM, Eric Dumazet wrote: On Wed, 2013-06-05 at 20:14 -0700, Tejun Heo wrote: Ah, so, that's why it's showing up now. We probably have had the same issue all along but it used to be masked by the softirq limiting

Re: [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Eric Dumazet
On Thu, 2012-10-18 at 20:55 -0700, Joe Perches wrote: ethernet, ipv4, and ipv6 address testing uses 3 different api naming styles. ethernet uses:is_foo_ether_addr ipv4 uses:ipv4_is_foo ipv6 uses:ipv6_addr_foo Standardize on the ipv6 style of prefix_addr_type to reduce the

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-07 Thread Eric Dumazet
Le vendredi 07 janvier 2011 à 14:20 -0800, Ben Greear a écrit : On 0 Using skb_copy() is wrong then, since it makes a copy (order-1 allocations) It should use : skb_alloc( actual_size_of_frame not the 3840 thing ...) copy(data) We need the extra stuff copied too I think (like

Re: [ath9k-devel] [ath9k] skbuff alloc of size 3872 failed

2011-01-06 Thread Eric Dumazet
Le jeudi 06 janvier 2011 à 16:05 -0800, Luis R. Rodriguez a écrit : Eric, also please make sure you read and understand what using a SOB means:

Re: [ath9k-devel] [ath9k] skbuff alloc of size 3872 failed

2011-01-06 Thread Eric Dumazet
-rc1. Eric Dumazet provided a patch which fixed the issue, but apparently it's still not upstream. Why is this? If it is suitable for upstream inclusion, please take my Tested-by: Matt Turnermatts...@gmail.com https://patchwork.kernel.org/patch/104271/ I applied this patch

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Eric Dumazet
Le vendredi 07 janvier 2011 à 02:04 +0100, Christian Lamparter a écrit : On Friday 07 January 2011 01:46:03 gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Patch is from Eric Dumazet, as described here: https://patchwork.kernel.org/patch/104271/ Reported

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Eric Dumazet
Le jeudi 06 janvier 2011 à 17:57 -0800, Luis R. Rodriguez a écrit : On Thu, Jan 6, 2011 at 5:23 PM, Eric Dumazet eric.duma...@gmail.com wrote: Le vendredi 07 janvier 2011 à 02:04 +0100, Christian Lamparter a écrit : On Friday 07 January 2011 01:46:03 gree...@candelatech.com wrote: From

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Eric Dumazet
Le jeudi 06 janvier 2011 à 18:13 -0800, Luis R. Rodriguez a écrit : On Thu, Jan 6, 2011 at 6:07 PM, Eric Dumazet eric.duma...@gmail.com wrote: The only way to accept your patch is to use a debugfs option to disable it, we need AMSDU support enabled by default. I dont care of my patch

Re: [ath9k-devel] [PATCH 1/3] ath9k: Decrease skb size to fit into one page.

2011-01-06 Thread Eric Dumazet
Le vendredi 07 janvier 2011 à 03:24 +0100, Eric Dumazet a écrit : Given IEEE80211_MAX_MPDU_LEN is more than 3840, and skb shinfo adds more than 256 bytes, I can assert rx_bufsize is greater than 4096 : order-1 On 64bit arches : sizeof(struct skb_shared_info) = 0x198 = 408