[ath9k-devel] [PATCH] ath9k_htc: remove dead code in error path of ath9k_htc_txcompletion_cb

2015-01-19 Thread John W. Linville
This clause is conditioned on htc_hdr != NULL, but it will only be NULL when that check is reached. Coverity: CID 114318 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/ath/ath9k/htc_hst.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

Re: [ath9k-devel] [PATCH 2/2] ath9k: fix regression in bssidmask calculation

2014-11-11 Thread John W. Linville
instead of whole list of vifs. This would allow each channel context to run in different mode (STA/AP). Signed-off-by: Felix Fietkau n...@openwrt.org Signed-off-by: Rajkumar Manoharan rmano...@qti.qualcomm.com Signed-off-by: John W. Linville linvi...@tuxdriver.com broke multi-vif

Re: [ath9k-devel] [PATCH 3/3] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries

2014-10-31 Thread John W. Linville
Acked-by: John W. Linville linvi...@tuxdriver.com -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH 2/3] ath: use seq_file api for ath9k debugfs files

2014-10-31 Thread John W. Linville
contents. Signed-off-by: Arend van Spriel ar...@broadcom.com Acked-by: John W. Linville linvi...@tuxdriver.com -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready

Re: [ath9k-devel] [PATCH 0/3] debugfs: adding helper for single seq_file

2014-10-30 Thread John W. Linville
in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready

Re: [ath9k-devel] [PATCH 09/10] ath9k: add ath9k_enable_dynack() method

2014-07-22 Thread John W. Linville
]: *** [drivers/net/wireless/ath] Error 2 make: *** [drivers/net/wireless/] Error 2 Missing a header file change? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready

Re: [ath9k-devel] [PATCH 09/10] ath9k: add ath9k_enable_dynack() method

2014-07-22 Thread John W. Linville
? -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] Bug: USB wifi card TL-WN722N (AR9271, ath9k_htc) fails to get DHCP lease

2014-06-30 Thread John W. Linville
? % git show 88daf80 commit 88daf80dcca19ff995cc263592426f734a9702f3 Merge: 010d3c3 35582ad Author: John W. Linville linvi...@tuxdriver.com Date: Thu Feb 20 15:02:02 2014 -0500 Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next into for-davem

[ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx

2014-05-19 Thread John W. Linville
(struct ath9k_htc_priv *priv, Signed-off-by: John W. Linville linvi...@tuxdriver.com --- Compile-test only...seems reasonable? drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers

Re: [ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx

2014-05-19 Thread John W. Linville
On Mon, May 19, 2014 at 11:28:42PM +0200, Oleksij Rempel wrote: Am 19.05.2014 23:07, schrieb John W. Linville: CC [M] drivers/net/wireless/ath/ath9k/htc_drv_txrx.o drivers/net/wireless/ath/ath9k/htc_drv_txrx.c: In function ‘ath9k_rx_prepare’: drivers/net/wireless/ath/ath9k

Re: [ath9k-devel] [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks

2014-05-16 Thread John W. Linville
that can be used for STA and other iftypes too) and ath9k/ath10k are the only (non) users of it. ;) John, I'm planning to take this as I think we will get less conflicts that way. But let me know if you want it instead. No, that's good. You will take the ath9k part too, right? -- John W

Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-07 Thread John W. Linville
); } } - } else if (!(caldata-CalValid currCal-calData-calType)) { + } else if (caldata !(caldata-CalValid currCal-calData-calType)) { ath9k_hw_reset_calibration(ah, currCal); } -- 1.9.2 -- John W. LinvilleSomeday the world

Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-07 Thread John W. Linville
On Wed, May 07, 2014 at 01:03:00PM -0700, Luis R. Rodriguez wrote: On Wed, May 7, 2014 at 12:54 PM, John W. Linville linvi...@tuxdriver.com wrote: Is there any hope for getting a more complete fix from the ath9k guys in short order? Wait, who are the ath9k folks now exactly ? A better

Re: [ath9k-devel] [PATCH] ath9k: Prevent divide by zero kernel crash.

2014-04-22 Thread John W. Linville
-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready

Re: [ath9k-devel] [PATCH 00/23] ath9k|ath9k_htc: move dups to common-beacon

2014-03-14 Thread John W. Linville
]: *** [drivers/net/wireless/ath] Error 2 make: *** [drivers/net/wireless/] Error 2 I'll be backing this out for now... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready

Re: [ath9k-devel] [PATCH 00/23] ath9k|ath9k_htc: move dups to common-beacon

2014-03-06 Thread John W. Linville
duplicate detection for initvals. It is part of the initvals tool in qca-swiss-army-knife. So, where does this leave us? Should this series be merged? Or not? -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we

Re: [ath9k-devel] [PATCH] net: wirelesse: wcn36xx: check allocation and trim critical section

2013-12-11 Thread John W. Linville
); break; default: wcn36xx_err(SMD_EVENT (%d) not supported\n, -- 1.8.4 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready

Re: [ath9k-devel] [PATCHv2] net: wireless: wcn36xx: fix potential NULL pointer dereference

2013-12-06 Thread John W. Linville
” Nazarewicz(o o) ooo +--m...@google.com--xmpp:min...@jabber.org--ooO--(_)--Ooo-- -- Best regards, Eugene -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready

Re: [ath9k-devel] [PATCH] ath9k: apply coverage class on slottime too

2013-04-22 Thread John W. Linville
think? Looks ok to me, let's get it merged. I don't seem to have it in my queue. Could someone resend it? -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready

Re: [ath9k-devel] Possible bug in drivers/net/wireless/ath/ath9k/ar9003_hw.c

2013-04-11 Thread John W. Linville
://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1680260226a8fd2aab590319da83ad8e610da9bd). I am not sure. I am going to downgrade my kernel to verify it. I'll have to refer you to the people that actually have their hands in the guts of ath9k... :-) John -- John W. Linville

Re: [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure

2013-04-01 Thread John W. Linville
as well. -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman

Re: [ath9k-devel] [PATCH] ath9k: Show actual timeout value in failed calibration messages.

2013-03-27 Thread John W. Linville
, + AH_WAIT_TIMEOUT / 1000); return false; } -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W

Re: [ath9k-devel] [PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-18 Thread John W. Linville
; -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.

2013-03-11 Thread John W. Linville
override_eeprom_regdomain=0 Signed-off-by: Ben Greear gree...@candelatech.com Why =0 to enable it? Just to make it more confusing? Do the Atheros folks have an opinion on this? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com

Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.

2013-03-11 Thread John W. Linville
On Mon, Mar 11, 2013 at 12:51:41PM -0700, Ben Greear wrote: On 03/11/2013 12:05 PM, John W. Linville wrote: On Mon, Mar 11, 2013 at 09:45:06AM -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Otherwise, can't get the Sparklan AR9380 NICs to be 5Ghz APs, since

Re: [ath9k-devel] [PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-08 Thread John W. Linville
unused stack variables. Removed unnecessary parentheses. Neatened alignment. Signed-off-by: Joe Perches j...@perches.com No objection... Acked-by: John W. Linville linvi...@tuxdriver.com -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com

Re: [ath9k-devel] [PATCH -next] wireless: ath9k-htc: fix possible use after free

2012-09-27 Thread John W. Linville
...@qca.qualcomm.com Cc: Jouni Malinen jo...@qca.qualcomm.com Cc: Vasanthakumar Thiagarajan vthia...@qca.qualcomm.com Cc: Senthil Balasubramanian senth...@qca.qualcomm.com Cc: John W. Linville linvi...@tuxdriver.com Gentle ping, :-) This is commit e962610f8100e1b52973f5a9c855cbc3d1ba04ec in wireless

Re: [ath9k-devel] [PATCH v3 00/10] Add support for WOW in ath9k

2012-07-06 Thread John W. Linville
| 145 ++- drivers/net/wireless/ath/ath9k/wow.c | 560 ++ 12 files changed, 1240 insertions(+), 1 deletions(-) create mode 100644 drivers/net/wireless/ath/ath9k/wow.c -- John W. LinvilleSomeday the world will need a hero

Re: [ath9k-devel] [PATCH] Build fix in drivers/net/wireless/ath/ath9k/main.c

2012-06-28 Thread John W. Linville
)) cancel_work_sync(sc-mci_work); +#endif } static void ath_cancel_work(struct ath_softc *sc) -- 1.7.8.6 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready

Re: [ath9k-devel] Regression due to ath9k: fix going to full-sleep on PS idle

2012-04-12 Thread John W. Linville
the commit: http://git.kernel.org/?p=linux/kernel/git/linville/wireless.git;a=commit;h=011afa1ed8c408d694957d2474d89dc81a60b70c Yes, I'll be pushing to Dave M shortly. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might

Re: [ath9k-devel] [PATCH v2 0/4] Fix the way ANI is being handled for ar9100 and ar9340

2011-11-30 Thread John W. Linville
this. I'm dropping this series for the above reason. Please feel free to fix your editor if necessary and to revise the patches to avoid needless and/or inappropriate whitespace changes or additions. John -- John W. LinvilleSomeday the world will need a hero, and you linvi

Re: [ath9k-devel] [PATCH 0/2] ath9k: DFS radar detection

2011-11-15 Thread John W. Linville
is not supported by mac80211/hostapd. Testing the proposed pulse detection is done in monitor mode. Zefir Kurtisi (2): ath9k: add DFS radar pulse processing ath9k: integrate initial DFS module Any comments from the ath9k guys on this? -- John W. LinvilleSomeday

Re: [ath9k-devel] [RFC/RFT] ath9k_htc: Fix memory leak

2011-08-23 Thread John W. Linville
a patch. Ping? Is this the patch we want? Or something else? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k

Re: [ath9k-devel] [PATCH -next 0/8] ath9k: ASPM fixes

2011-08-11 Thread John W. Linville
through the wireless trees? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https

Re: [ath9k-devel] [PATCHv2] ath9k: remove eeprom txgain override for minor version 19

2011-08-10 Thread John W. Linville
from someone from Atheros on the ath9k team? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel

Re: [ath9k-devel] [PATCH] ath9k: correct ath9k_hw_set_interrupts

2011-02-23 Thread John W. Linville
that behaviour and check ints arguments before enabling interrupts, also disable interrupts if ints do not have ATH9K_INT_GLOBAL flag set. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com Should this be Cc: sta...@kernel.org? -- John W. LinvilleSomeday the world will need

Re: [ath9k-devel] [PATCH RESEND 09/11] ath9k: Try all queues when looking for next packet to send.

2011-01-25 Thread John W. Linville
when using multiple stations, especially with AMPDU enabled. Signed-off-by: Ben Greear gree...@candelatech.com This one doesn't seem to apply any more. Can I persuade you to rebase and resubmit it? Thanks, John -- John W. LinvilleSomeday the world will need a hero, and you

[ath9k-devel] [PATCH] ath9k: qualify global modparam_nohwcrypt variable

2011-01-05 Thread John W. Linville
Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/ath/ath9k/ath9k.h |2 +- drivers/net/wireless/ath/ath9k/init.c |6 +++--- drivers/net/wireless/ath/ath9k/main.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless

[ath9k-devel] [PATCH 2/3] ath9k: use nohwcrypt in ath_common structure

2011-01-05 Thread John W. Linville
Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/ath/ath9k/ath9k.h |1 - drivers/net/wireless/ath/ath9k/init.c |5 +++-- drivers/net/wireless/ath/ath9k/main.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless

[ath9k-devel] [PATCH 3/3] ath9k_htc: use nohwcrypt in ath_common structure

2011-01-05 Thread John W. Linville
Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/ath/ath9k/htc.h |1 - drivers/net/wireless/ath/ath9k/htc_drv_init.c |5 +++-- drivers/net/wireless/ath/ath9k/htc_drv_main.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [ath9k-devel] [PATCH] ath9k: Make DMA warning in ath_stoprecv WARN_ON_ONCE.

2010-12-08 Thread John W. Linville
be printed, so users can be aware that problem exists. Signed-off-by: Ben Greear gree...@candelatech.com Acked-by: Luis R. Rodriguez lrodrig...@atheros.com Signed-off-by: John W. Linville linvi...@tuxdriver.com -- John W. LinvilleSomeday the world will need a hero

Re: [ath9k-devel] [PATCH 0/4] ath: logging message conversion

2010-12-07 Thread John W. Linville
(.., ATH_DBG_FATAL to ath_err ath: Convert ath_print to ath_dbg ath: Fix ath_dbg access beyond array bound Is the Atheros crew happy with this series? They didn't seem to like the original patches very much... John -- John W. LinvilleSomeday the world will need a hero, and you linvi

Re: [ath9k-devel] [PATCH] ath9k: Clear DMA addresses when buffers are freed.

2010-10-29 Thread John W. Linville
, Ben The patch seems fine to me, but it isn't a fix and so isn't going anywhere until wireless-next-2.6 opens again (i.e. after the merge window closes). John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have

Re: [ath9k-devel] [RFC] ath9k: Insert wmb before linking dma descriptors

2010-10-05 Thread John W. Linville
hope is that this may solve some of the harder chip lockups on MIPS but more testing is required to determine if it has this effect. Any thoughts? /Björn 1. http://www.mjmwired.net/kernel/Documentation/DMA-API.txt I think this seems OK...? John -- John W. LinvilleSomeday

[ath9k-devel] [PATCH] ath9k: enable serialize_regmode for non-PCIE AR9160

2010-07-28 Thread John W. Linville
https://bugzilla.kernel.org/show_bug.cgi?id=16476 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- Is there a better (i.e. either more precise or more inclusive) test to be using here? drivers/net/wireless/ath/ath9k/hw.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

Re: [ath9k-devel] kernel warning on 2.6.33 ath9k

2010-04-28 Thread John W. Linville
[c1387975] ? sock_ioctl+0x0/0x1db [c10b0ed6] do_vfs_ioctl+0x453/0x491 [c1388233] ? sys_recvmsg+0x2c/0x47 [c1389542] ? sys_socketcall+0x147/0x18c [c10b0f43] sys_ioctl+0x2f/0x49 [c10027d0] sysenter_do_call+0x12/0x26 -- John W. LinvilleSomeday the world will need a hero

Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now

2010-04-21 Thread John W. Linville
On Wed, Apr 21, 2010 at 07:38:12AM +0530, Sujith wrote: John W. Linville wrote: Any feedback on this? This has already been merged. commit e92119ca88691ac2239916d31c3dcecd10867521 Author: Sujith sujith.manoha...@atheros.com Date: Thu Apr 1 10:28:24 2010 +0530 ath9k_htc: Add TL

Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now

2010-04-20 Thread John W. Linville
@@ -21,6 +21,7 @@ static struct usb_device_id ath9k_hif_usb_ids[] = { ATH9K_FW_USB_DEV(0x9271, ar9271.fw), + ATH9K_FW_USB_DEV(0x1006, ar9271.fw), /* TL-WN422G v2 */ { }, }; Any feedback on this? John -- John W. LinvilleSomeday the world will need a hero

Re: [ath9k-devel] signed vs unsigned bug in ath9k

2009-12-08 Thread John W. Linville
and the minimum value for int8_t is -128 so why is it a bug? It could be that someone fixed this already in the net tree? In mainline it's still positive 128. #define ATH9K_RSSI_BAD 0x80 I queued a patch to fix that for 2.6.33. Hth! John -- John W. Linville

Re: [ath9k-devel] [internal-ath9k-devel] RHEL5.5 (and Centos 5.5!) wireless updates needs broad testing...

2009-12-03 Thread John W. Linville
On Wed, Dec 02, 2009 at 02:50:28PM -0800, Luis R. Rodriguez wrote: On Sat, Nov 28, 2009 at 1:21 PM, John W. Linville linvi...@redhat.com wrote: If you have a wireless LAN enabled box running RHEL5 (or CentOS 5 or other equivalent) then please give these kernels a try.  When you find

Re: [ath9k-devel] [PATCH] ath9k: This patch fix RX unpadding for any received frame.

2009-11-19 Thread John W. Linville
if you are trying to analyze non standard 802.11 frame going over the air. Signed-off-by: Benoit PAPILLAULT ben...@benoit-laptop.(none) Are you sure this is this the email address you want? -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com

Re: [ath9k-devel] [RFT 00/15] ath9k_hw ar9271 updates AR5416 force bias

2009-10-26 Thread John W. Linville
-- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k

Re: [ath9k-devel] Possible to set MCS Index?

2009-09-30 Thread John W. Linville
. That would require quite a lot of work though. ACK to the above... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list

Re: [ath9k-devel] Makefile ref to non-existent CONFIG_ATHEROS_AR71XX

2009-09-28 Thread John W. Linville
/ath9k/Makefile:ath9k-$(CONFIG_ATHEROS_AR71XX) += ahb.o We need it in OpenWrt and plan to send Atheros AR71xx SoC support soon, do not consider this for removal. Thanks Sure, fine...estimate when it will arrive? John -- John W. LinvilleSomeday the world will need a hero

Re: [ath9k-devel] [PATCH] ath9k: Fix read buffer overflow

2009-08-20 Thread John W. Linville
Anybody? On Tue, Aug 11, 2009 at 02:25:14PM -0400, John W. Linville wrote: Comments from the ath9k crowd? On Tue, Aug 11, 2009 at 08:49:08AM +0200, Roel Kluin wrote: Prevent a read of powInfo[-1] in the first iteration. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- diff --git

Re: [ath9k-devel] [PATCH] ath9k: Fix read buffer overflow

2009-08-11 Thread John W. Linville
; } -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo

Re: [ath9k-devel] [PATCH 0/7] ATH9K bug fixes - TX hang Signal Quality issue

2009-06-17 Thread John W. Linville
, but the changelog entries for those patches is insufficiently detailed -- especially if you want them merged as fixes for 2.6.31. I need a report with enough details for the fix to be properly evaluated and preferably a link to an actual bug report. John -- John W. LinvilleSomeday the world

Re: [ath9k-devel] ath9k: panic on tip/master

2008-10-03 Thread John W. Linville
be the culprit? Sorry to not be more immediately helpful, but I'm going to have to run in a few minutes. Perhaps this insight is helpful for someone more familiar with the internals of this driver? John -- John W. LinvilleLinux should be at the core [EMAIL PROTECTED