[ath9k-devel] [PATCH] ath9k: Support ethtool getstats api.

2012-05-07 Thread greearb
From: Ben Greear This returns many of the values that formerly could only be obtained from debugfs. This should be an improvement when trying to access these counters programatically. Currently this support is only enabled when DEBUGFS is enabled because otherwise these stats are not accumulate

Re: [ath9k-devel] [PATCH] ath9k: Support ethtool getstats api.

2012-05-07 Thread Joe Perches
On Mon, 2012-05-07 at 10:23 -0700, gree...@candelatech.com wrote: > From: Ben Greear > > This returns many of the values that formerly could > only be obtained from debugfs. This should be an > improvement when trying to access these counters > programatically. Currently this support is only >

Re: [ath9k-devel] [PATCH] ath9k: Support ethtool getstats api.

2012-05-07 Thread Ben Greear
On 05/07/2012 10:33 AM, Joe Perches wrote: > On Mon, 2012-05-07 at 10:23 -0700, gree...@candelatech.com wrote: >> From: Ben Greear >> >> This returns many of the values that formerly could >> only be obtained from debugfs. This should be an >> improvement when trying to access these counters >> pr

Re: [ath9k-devel] [PATCH] ath9k: Support ethtool getstats api.

2012-05-08 Thread Kalle Valo
Ben Greear writes: > No, there is a check later that does a BUG_ON if our > we have screwed up the indexing of the stats. Please, no BUG_ON() calls in wifi drivers. They just make users life miserable. WARN_ON() with a safe bailout is enough. -- Kalle Valo _

Re: [ath9k-devel] [PATCH] ath9k: Support ethtool getstats api.

2012-05-08 Thread Ben Greear
On 05/08/2012 12:55 AM, Kalle Valo wrote: > Ben Greear writes: > >> No, there is a check later that does a BUG_ON if our >> we have screwed up the indexing of the stats. > > Please, no BUG_ON() calls in wifi drivers. They just make users life > miserable. WARN_ON() with a safe bailout is enough.

Re: [ath9k-devel] [PATCH] ath9k: Support ethtool getstats api.

2012-05-08 Thread Joe Perches
On Tue, 2012-05-08 at 10:55 +0300, Kalle Valo wrote: > Ben Greear writes: > > > No, there is a check later that does a BUG_ON if our > > we have screwed up the indexing of the stats. > > Please, no BUG_ON() calls in wifi drivers. They just make users life > miserable. WARN_ON() with a safe bailo