Re: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses

2013-05-20 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 16/05/13 09:03, Joe Perches wrote: Neaten and shorten the uses of ath10k_dbg and ath10k_dbg_dump. Add macros to hold the ATH10K_DBG_ mask portion of the functions. I'm not really fond of this idea. It's harder to locate symbols when doing

Re: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses

2013-05-20 Thread Joe Perches
On Mon, 2013-05-20 at 10:12 +0300, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: On 16/05/13 09:03, Joe Perches wrote: Neaten and shorten the uses of ath10k_dbg and ath10k_dbg_dump. Add macros to hold the ATH10K_DBG_ mask portion of the functions. I'm not really

Re: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses

2013-05-20 Thread Kalle Valo
Joe Perches j...@perches.com writes: On Mon, 2013-05-20 at 10:12 +0300, Kalle Valo wrote: Michal Kazior michal.kaz...@tieto.com writes: On 16/05/13 09:03, Joe Perches wrote: Neaten and shorten the uses of ath10k_dbg and ath10k_dbg_dump. Add macros to hold the ATH10K_DBG_ mask portion

Re: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses

2013-05-16 Thread Michal Kazior
On 16/05/13 09:03, Joe Perches wrote: Neaten and shorten the uses of ath10k_dbg and ath10k_dbg_dump. Add macros to hold the ATH10K_DBG_ mask portion of the functions. I'm not really fond of this idea. It's harder to locate symbols when doing macro name concatenation. You can't jump to, e.g.