Re: [ath9k-devel] PHY counter hard coded values in reg.h

2012-12-01 Thread abhinav narain
0x24 is 36, indexing into one of 36 in the enum list, so that part I suppose is right.. I checked setting the mask to 0x in reg.h and found no difference in the counts of other PHY error counters incrementing, hence I suppose the mask is also fine; may be AR9820 doesn't have the hardware

[ath9k-devel] PHY counter hard coded values in reg.h

2012-11-30 Thread abhinav narain
hi, In ath9k/reg.h, there are some constants for the PHY error counters #define AR_FILT_CCK0x8128 #define AR_PHY_ERR_1 0x812c #define AR_PHY_ERR_MASK_1 0x8130 #define AR_PHY_ERR_2 0x8134 #define AR_PHY_ERR_MASK_2 0x8138 Can I change them to 0x or

Re: [ath9k-devel] PHY counter hard coded values in reg.h

2012-11-30 Thread Adrian Chadd
Hi, On 30 November 2012 16:34, abhinav narain abhinavnarai...@gmail.com wrote: hi, In ath9k/reg.h, there are some constants for the PHY error counters #define AR_FILT_CCK0x8128 #define AR_PHY_ERR_1 0x812c #define AR_PHY_ERR_MASK_1 0x8130 #define AR_PHY_ERR_2

Re: [ath9k-devel] PHY counter hard coded values in reg.h

2012-11-30 Thread Adrian Chadd
.. 0x24? Why's it ANDing with that? How big is that PHY error array? And there's a separate RX PHY error mask register you can set to 0x for experiment: ar5212reg.h:#define AR_PHY_ERR 0x810c /* Phy error filter */ Adrian On 30 November 2012 20:20, abhinav narain

Re: [ath9k-devel] PHY counter hard coded values in reg.h

2012-11-30 Thread abhinav narain
On Fri, Nov 30, 2012 at 11:27 PM, Adrian Chadd adr...@freebsd.org wrote: .. 0x24? Why's it ANDing with that? Not my code ! Its already present in debgufs.c How big is that PHY error array? Enum is indexed till 37 And there's a separate RX PHY error mask register you can set to

Re: [ath9k-devel] PHY counter hard coded values in reg.h

2012-11-30 Thread Adrian Chadd
On 30 November 2012 21:05, abhinav narain abhinavnarai...@gmail.com wrote: On Fri, Nov 30, 2012 at 11:27 PM, Adrian Chadd adr...@freebsd.org wrote: .. 0x24? Why's it ANDing with that? Not my code ! Its already present in debgufs.c How big is that PHY error array? Enum is indexed till