Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

Eli Schwartz via aur-general schrieb am Di., 16. Aug. 2016, 19:24: > On 08/16/2016 01:12 PM, Patrick Eigensatz wrote: > > No, the errors I experienced were all PKGBUILD syntax related mistakes; > > also I didn't know I could use full bash syntax in the PKGSRC file this

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

On 08/16/2016 01:12 PM, Patrick Eigensatz wrote: > No, the errors I experienced were all PKGBUILD syntax related mistakes; > also I didn't know I could use full bash syntax in the PKGSRC file this > is why I "extended" ./ to shto eliminate possible error causes > I would not have been

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

Eli Schwartz via aur-general schrieb am Di., 16. Aug. 2016, 15:10: > On 08/16/2016 06:54 AM, Patrick Eigensatz via aur-general wrote: > > I usually do run my shellscripts via ./ too, but when I experimented with > > makepkg I experienced some errors and I wasn't sure

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

Am 15.08.2016 02:57 schrieb "Eli Schwartz via aur-general" < aur-general@archlinux.org>: > > On 08/13/2016 03:47 PM, Patrick Eigensatz via aur-general wrote: > > Then I read I could ask here for suggestions and improvements. > > Is there something I didn't do which is e.g. a good habit? Or did I >

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

> I don't usually see people running shellscripts using `sh $shellscript` > -- it is usually `./$shellscript`. > It really makes no difference (practical or otherwise) except for > looking odd... I can make a difference. "sh shellscript" will run the script using sh, whereas "./shellscript" will

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

On 08/13/2016 03:47 PM, Patrick Eigensatz via aur-general wrote: > Then I read I could ask here for suggestions and improvements. > Is there something I didn't do which is e.g. a good habit? Or did I > something that I shouldn't have done? Including the feedback you have already received, it

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

Alad Wenter schrieb am Sa., 13. Aug. 2016 um 23:25 Uhr: > Op 13.08.2016 om 22:39 schreef Patrick Eigensatz via aur-general: > > @Alad: > > > > Thanks, I changed this as well! > > > > > > @Florian: > > I thought if there was a variable for both I'd set both :) > > Should I

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

Op 13.08.2016 om 22:39 schreef Patrick Eigensatz via aur-general: > @Alad: > > Thanks, I changed this as well! > > > @Florian: > I thought if there was a variable for both I'd set both :) > Should I remove the md5sum? Is there a guarantee every Archsystem > has the md5sum and/or the sha256 command

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

@Alad: Thanks, I changed this as well! @Florian: I thought if there was a variable for both I'd set both :) Should I remove the md5sum? Is there a guarantee every Archsystem has the md5sum and/or the sha256 command available? Another question just popped in my mind: How does namcap find

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

Op 13.08.2016 om 22:18 schreef Patrick Eigensatz via aur-general: > Hello Alad, Hello Dan > > Thank you very much for your ideas. I just pushed a new version of the > PKGBUILD > here: > > https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=qjournalctl > > > Are there further improvements? The

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

* Patrick Eigensatz via aur-general [2016-08-13 20:18:05 +]: > Thank you very much for your ideas. I just pushed a new version of the > PKGBUILD > here: > > https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=qjournalctl > > > Are there further improvements?

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

Hello Alad, Hello Dan Thank you very much for your ideas. I just pushed a new version of the PKGBUILD here: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=qjournalctl Are there further improvements? The point with the substitutions of $pkgver seems very handy to me! Thank you!

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

Remove the "make -j 9" line. I'll review the rest in a sec On Aug 13, 2016 2:47 PM, "Patrick Eigensatz via aur-general" < aur-general@archlinux.org> wrote: > Hello folks! > > I am a beginner in Arch packaging but I just came to a stable point writing > my small systemd journal analyzer and

Re: [aur-general] Request to check my PKGBUILD and suggest me some improvements

Op 13.08.2016 om 21:47 schreef Patrick Eigensatz via aur-general: > Hello folks! > > I am a beginner in Arch packaging but I just came to a stable point writing > my small systemd journal analyzer and beeing a Arch user for some years now > I thought it would > be a good exercise for me to write a