Re: Problems building rsync with Clang 15 beta

2022-08-18 Thread Zack Weinberg
On Thu, Aug 18, 2022, at 12:51 PM, Paul Eggert wrote: > On 8/18/22 09:38, Khem Raj wrote: >> I think the autoconf patch should be good on its own merits regardless > > It partly depends on how much we care about compatibility. Putting the > 'void' in there will break pre-C89 compilers, as well as

Re: Problems building rsync with Clang 15 beta

2022-08-18 Thread Paul Eggert
On 8/18/22 09:38, Khem Raj wrote: I think the autoconf patch should be good on its own merits regardless It partly depends on how much we care about compatibility. Putting the 'void' in there will break pre-C89 compilers, as well as C++ compilers pretending (badly) to be C compilers. I doubt

Re: Problems building rsync with Clang 15 beta

2022-08-18 Thread Khem Raj
On Thu, Aug 18, 2022 at 8:22 AM Paul Eggert wrote: > > On 8/17/22 23:58, Khem Raj wrote: > > rsync which add -pedantic-errors option to cflags during configure > > OK, that's the problem then. 'configure' should not use flags like > -pedantic-errors. This has long been a property of 'autoconf'-gen

Problems building rsync with Clang 15 beta

2022-08-18 Thread Paul Eggert
On 8/17/22 23:58, Khem Raj wrote: rsync which add -pedantic-errors option to cflags during configure OK, that's the problem then. 'configure' should not use flags like -pedantic-errors. This has long been a property of 'autoconf'-generated scripts. The simplest way to fix this would be for