Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

On 18 Jan 2022 11:29, Jim Meyering wrote: > On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote: > > On 18 Jan 2022 09:48, Jim Meyering wrote: > ... > > > But IMHO that's too much duplication/syntax. > > > How about this instead? > > > > > > case $(echo "$files" | wc -l) in 4|6) ;; *) false;;

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote: > On 18 Jan 2022 09:48, Jim Meyering wrote: ... > > But IMHO that's too much duplication/syntax. > > How about this instead? > > > > case $(echo "$files" | wc -l) in 4|6) ;; *) false;; esac > > looks reasonable for POSIX shell. not a fan

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

On 18 Jan 2022 09:48, Jim Meyering wrote: > On Tue, Jan 18, 2022 at 7:46 AM Mike Frysinger wrote: > > From: Thomas Deutschmann > > > > Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python > > tests, do not require .pyo files (for python3)") had a slight logic > > error in that it

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

On Tue, Jan 18, 2022 at 7:46 AM Mike Frysinger wrote: > From: Thomas Deutschmann > > Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python > tests, do not require .pyo files (for python3)") had a slight logic > error in that it missed a `test` call. > > Reported to Gentoo at

[PATCH] tests: fix py-compile-basedir.sh: add missing test call

From: Thomas Deutschmann Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python tests, do not require .pyo files (for python3)") had a slight logic error in that it missed a `test` call. Reported to Gentoo at https://bugs.gentoo.org/715040. * t/py-compile-basedir.sh: Add test

Re: [PATCH] readme: add missing word

-that the range specifies every single year in that closed interval. +note that the range specifies every single year in that closed interval. Thanks for pointing that out. I decided to delete the "that" instead of adding the "note". Pushed. --best wishes, karl.

[PATCH] readme: add missing word

diff --git a/README b/README index 4ac357012..184825761 100644 --- a/README +++ b/README @@ -48,7 +48,7 @@ be informed, subscribe to that list by following the instructions at . For any copyright year range specified as - in

bug#33166: automake --add-missing does not install config.rpath when AM_ICONV is used

> I need iconv but not gettext. Then take the Gnulib module 'iconv'. [1][2] It contains iconv.m4, its macro dependencies, and config.rpath - that is, exactly what you need. Bruno [1] https://www.gnu.org/software/gnulib/MODULES.html#module=iconv [1]

bug#33573: --add-missing behaviour

I ran 'automake --add-missing' to copy mdate-sh to my project. This, of course, creates a symbolic link to the automake install tree. Remembering this, I then ran 'automake --add-missing -c' to copy the script instead. Since mdate-sh was already present in my tree, automake did nothing. When

bug#33166: automake --add-missing does not install config.rpath when AM_ICONV is used

Am 27.10.2018 um 12:48 schrieb Stuart Caie: > I understand that there is a boundary between these two packages, and > this is not directly automake's problem, even though the main mechanism > for copying missing files is in automake. Not for this file it isn't, because as far as automake is

bug#33166: automake --add-missing does not install config.rpath when AM_ICONV is used

On 26/10/2018 20:54, Mathieu Lirzin wrote: “config.rpath” which is maintained in GNU Gettext is already copied inside the target source tree by the ‘autopoint’ program which is automatically run by ‘autoreconf --install’ when the Gettext macros are added to “configure.ac”. ‘autoreconf’

bug#33166: automake --add-missing does not install config.rpath when AM_ICONV is used

On 10/26/18, Hans-Bernhard Bröker wrote: > Am 26.10.2018 um 17:06 schrieb Stuart Caie: >> Technically, AM_ICONV is not distributed with automake, and neither is >> is config.rpath. However, automake recognises config.rpath as a special >> file to distribute nonetheless. > > That's not really

bug#33166: automake --add-missing does not install config.rpath when AM_ICONV is used

Hello Stuart, Stuart Caie writes: > the automake macro AM_ICONV requires the auxiliary program config.rpath, > however automake --add-missing will not install it. > > Technically, AM_ICONV is not distributed with automake, and neither is > is config.rpath. However, auto

bug#33166: automake --add-missing does not install config.rpath when AM_ICONV is used

Am 26.10.2018 um 17:06 schrieb Stuart Caie: > Hello, > > the automake macro AM_ICONV requires the auxiliary program config.rpath, > however automake --add-missing will not install it. That's because it's not automake's file. Automake has no way of knowing where to get that fi

bug#33166: automake --add-missing does not install config.rpath when AM_ICONV is used

Hello, the automake macro AM_ICONV requires the auxiliary program config.rpath, however automake --add-missing will not install it. Technically, AM_ICONV is not distributed with automake, and neither is is config.rpath. However, automake recognises config.rpath as a special file to distribute

Re: Add missing '$' for variable expansion in depout.m4

with git format-patch. But for such a small change it's really no big deal, so I went ahead and applied the patch in you name (the resulting commit is reported below, for reference). It will appear in the next bug-fixing version of Automake (1.13.2). Thank you, Stefano Add missing

Add missing '$' for variable expansion in depout.m4

(I hope I have prepared this patch properly.) Add missing '$' for variable expansion in depout.m4 * m4/depout.m4: am__include appeared where $am__include was meant. diff --git a/m4/depout.m4 b/m4/depout.m4 index 880a597..c79d04b 100644 --- a/m4/depout.m4 +++ b/m4/depout.m4 @@ -40,7

Re: Add missing '$' for variable expansion in depout.m4

an unusual way of doing it would be for automake to generate files which are source'd or m4_include'd from configure.ac). On Thu, Apr 11, 2013 at 7:45 PM, Nick Bowler nbow...@elliptictech.com wrote: On 2013-04-11 19:12 +0100, Gavin Smith wrote: (I hope I have prepared this patch properly.) Add

bug#12219: Could the --add-missing option be supported in AM_INIT_AUTOMAKE? (was: Re: How to automatically get missing files when changing configure.ac?)

for LT_INIT AFAIK. The make can fail when it tries to do an automake and ltmain.sh is missing. Note that even automake --add-missing wouldn't help you here, because the ltmain.sh is provided by Libtool, not Automake, and installed by 'libtoolize', not by 'automake'. Still, for other, similar use

Could the --add-missing option be supported in AM_INIT_AUTOMAKE? (was: Re: How to automatically get missing files when changing configure.ac?)

for LT_INIT AFAIK. The make can fail when it tries to do an automake and ltmain.sh is missing. Note that even automake --add-missing wouldn't help you here, because the ltmain.sh is provided by Libtool, not Automake, and installed by 'libtoolize', not by 'automake'. Still, for other, similar use

Re: Could the --add-missing option be supported in AM_INIT_AUTOMAKE?

, BTW; AC_PROG_LIBTOOL is the obsolescent name for LT_INIT AFAIK. Ok, the lines above were part of a bug report for the Eclipse CDT autotools plug-in and I just copied it over. The make can fail when it tries to do an automake and ltmain.sh is missing. Note that even automake --add-missing

[FYI] {maint} amversion: add missing dependency

* m4/Makefile.am ($(top_srcdir)/m4/amversion.m4): Depend on configure.ac, since the value of $(VERSION) can change every time configure.ac is updated. --- m4/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/m4/Makefile.am b/m4/Makefile.am index

Re: [FYI] {branch-1.11} tests: add missing dependency for some 'ar-lib*.test' tests

Subject: [FYI] {branch-1.11} tests: add missing dependency for some 'ar-lib*.test' tests Oops, wrong -- this patch hasn't been pushed to 'branch-1.11'. Rather, it has been pushed to the 'msvc' branch, and then merged into 'branch-1.11'. Sorry for the noise, Stefano

[FYI] {branch-1.11} tests: add missing dependency for some 'ar-lib*.test' tests

This change fixes spurious failures of the tests ar-lib4.test, ar-lib6a.test and ar-lib6b.test. * tests/Makefile.am (ar-lib4.log): Depend explicitly on the `libtool-macros.log' file. (ar-lib6a.log, ar-lib6b.log): Likewise. --- tests/Makefile.am |3 +++ 1 files changed, 3 insertions(+), 0

Re: * tests/amhello-binpkg.test: Add missing $EXEEXT usage.

On Monday 05 September 2011, Peter Rosin wrote: Hi! Hi Peter, thanks for the patch. This fixes a fail on Cygwin (and others I suppose). I'm aware that the lax non-gnu-tar branch adds even more laxness since $EXEEXT normally contains a dot for the oddball cases when it's non-empty, but

Re: * tests/amhello-binpkg.test: Add missing $EXEEXT usage.

Den 2011-09-05 10:06 skrev Stefano Lattarini: On Monday 05 September 2011, Peter Rosin wrote: Hi! Hi Peter, thanks for the patch. This fixes a fail on Cygwin (and others I suppose). I'm aware that the lax non-gnu-tar branch adds even more laxness since $EXEEXT normally contains a dot for

Re: * tests/amhello-binpkg.test: Add missing $EXEEXT usage.

Den 2011-09-05 11:37 skrev Stefano Lattarini: On Monday 05 September 2011, Peter Rosin wrote: Den 2011-09-05 10:06 skrev Stefano Lattarini: On Monday 05 September 2011, Peter Rosin wrote: Hi! Hi Peter, thanks for the patch. This fixes a fail on Cygwin (and others I suppose). I'm aware

Re: * tests/amhello-binpkg.test: Add missing $EXEEXT usage.

On Monday 05 September 2011, Peter Rosin wrote: Den 2011-09-05 11:37 skrev Stefano Lattarini: Ouch! Silly me for not thinking about that. And the quoting was off too, should have been s/\././g to do what you intended... :-) Double ouch, you're right again! $ x=`echo a.b |

* tests/amhello-binpkg.test: Add missing $EXEEXT usage.

2011-09-05 Peter Rosin p...@lysator.liu.se * tests/amhello-binpkg.test: Add missing $EXEEXT usage. From 396f69c65ddc01ebbcfcccb59381a80b9c050b1a Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@lysator.liu.se Date: Mon, 5 Sep 2011 00:31:48 +0200 Subject: [PATCH] * tests/amhello-binpkg.test

Re: [PATCH] {testsuite-work} tests: extend tests on `--add-missing' and `--copy' a bit

On Monday 13 June 2011, Stefano Lattarini wrote: On Monday 13 June 2011, Stefano Lattarini wrote: References: http://lists.gnu.org/archive/html/automake-patches/2011-06/msg00048.html http://lists.gnu.org/archive/html/automake-patches/2011-06/msg00065.html I've pushed this patch now.

[PATCH] {testsuite-work} tests: extend tests on `--add-missing' and `--copy' a bit

.git.stefano.lattar...@gmail.com From: Stefano Lattarini stefano.lattar...@gmail.com Date: Mon, 13 Jun 2011 19:42:52 +0200 Subject: [PATCH] tests: extend tests on `--add-missing' and `--copy' a bit * tests/add-missing.test: Fix typo in heading comments. Try with another testcase that install many (but not all

Re: [PATCH] {testsuite-work} tests: new test dedicated to `--add-missing' and `--copy' (was: Re: [PATCH 2/3] {testsuite-work} tests: can use also $SHELL to check shell scripts from `lib/')

References: http://lists.gnu.org/archive/html/automake-patches/2011-06/msg00048.html http://lists.gnu.org/archive/html/automake-patches/2011-06/msg00065.html I've pushed this patch now. Regards, Stefano

Re: [PATCH] {testsuite-work} tests: new test dedicated to `--add-missing' and `--copy' (was: Re: [PATCH 2/3] {testsuite-work} tests: can use also $SHELL to check shell scripts from `lib/')

script. Agreed. I now think we should have a centralized test where to check for files installed with `--add-missing', not to risk reduced coverage anymore. Patch coming up soon ... Done in the attached patch. It is more complex than I'd like, so I'll wait until sunday or so

Re: [PATCH] {testsuite-work} tests: new test dedicated to `--add-missing' and `--copy' (was: Re: [PATCH 2/3] {testsuite-work} tests: can use also $SHELL to check shell scripts from `lib/')

where to check for files installed with `--add-missing', not to risk reduced coverage anymore. Patch coming up soon ... Done in the attached patch. It is more complex than I'd like, so I'll wait until sunday or so before pushing, to allow more time for reviews. Regards, Stefano

[PATCH] {testsuite-work} tests: new test dedicated to `--add-missing' and `--copy' (was: Re: [PATCH 2/3] {testsuite-work} tests: can use also $SHELL to check shell scripts from `lib/')

'. The same argument could be made about the other instances where the script is brought in explicitly. Seems like a bit of a fluke that subobj.test covered the compile script. Agreed. I now think we should have a centralized test where to check for files installed with `--add-missing

[FYI] NEWS: Add missing blank line between two entries.

stefano.lattar...@gmail.com + * NEWS: Add missing blank line between two entries. + +2010-12-23 Stefano Lattarini stefano.lattar...@gmail.com + Improve and extend tests `suffix*.test'. * tests/suffix.test: Check that suffix rules for C compilation are only included once

Re: Add missing bootstrap file

You didn't answer why you need this switch, only that you want it.

Re: Add missing bootstrap file

Hi Alfred, * Alfred M. Szmidt wrote on Mon, Nov 16, 2009 at 08:33:10PM CET: You didn't answer why you need this switch, only that you want it. Various threads on this list during the last months document this, I would say. It otherwise isn't even hard to guess. ;-) Cheers, Ralf

Re: Add missing bootstrap file

Index: automake/m4/init.m4 === --- automake.orig/m4/init.m4 +++ automake/m4/init.m4 @@ -107,6 +107,7 @@ dnl is hooked onto _AC_COMPILER_EXEEXT e AC_CONFIG_COMMANDS_PRE(dnl [m4_provide_if([_AM_COMPILER_EXEEXT],

Re: Add missing bootstrap file

[Note that this has nothing to do with the bootstrap file] On Sunday 2009-11-15 17:44, Alfred M. Szmidt wrote: Index: automake/m4/init.m4 === --- automake.orig/m4/init.m4 +++ automake/m4/init.m4 @@ -107,6 +107,7 @@

Re: Add missing bootstrap file

Hi Jan, * Jan Engelhardt wrote on Mon, Nov 09, 2009 at 02:09:14AM CET: in the automake tarballs, the 'bootstrap' script is missing, but it would be needed when modifying any of the automake files in a tarball. Sounds reasonable to me, esp. since it doesn't even use git in any way (yet). In

Re: Add missing bootstrap file

On Sat, 2009-11-14 at 14:06 +0100, Ralf Wildenhues wrote: Hi Jan, * Jan Engelhardt wrote on Mon, Nov 09, 2009 at 02:09:14AM CET: in the automake tarballs, the 'bootstrap' script is missing, but it would be needed when modifying any of the automake files in a tarball. Sounds

Re: Add missing bootstrap file

Gaetan Nadon wrote: If you want to modify files in automake, then you are doing development, rather than just installing the software. Given that automake requires itself, there may be special things to do. In any case, nothing should be added to the tarball that isn't required for

Re: Add missing bootstrap file

On Sat, 2009-11-14 at 09:35 -0500, Peter Johansson wrote: Gaetan Nadon wrote: If you want to modify files in automake, then you are doing development, rather than just installing the software. Given that automake requires itself, there may be special things to do. In any case, nothing

Re: Add missing bootstrap file

On Saturday 2009-11-14 14:06, Ralf Wildenhues wrote: Hi Jan, * Jan Engelhardt wrote on Mon, Nov 09, 2009 at 02:09:14AM CET: in the automake tarballs, the 'bootstrap' script is missing, but it would be needed when modifying any of the automake files in a tarball. Sounds reasonable to me,

Re: Add missing bootstrap file

On Sat, 14 Nov 2009, Peter Johansson wrote: From where did you get that rule? It doesn't go very well with the fact that automake by default adds Makefile.am, configure.ac and other .m4 files to the tarball. Those files will never be useful for a pure ./configure; make; make install, but as

Add missing bootstrap file

Hi, in the automake tarballs, the 'bootstrap' script is missing, but it would be needed when modifying any of the automake files in a tarball. In other words, when used in an rpm build script: Source: automake-1.11.tar.bz2 Patch1: foobar.diff modifying m4/init.m4 Not running bootstrap after

Parallel automake --add-missing: serialized file installs. [4/4]

The final piece. A bit ugly because the changes in require_conf_file depend on nonlocal semantics in require_file_internal and in maybe_push_required_file. Oh well. Cheers, Ralf Parallel automake --add-missing: serialized file installs. * automake.in (QUEUE_CONF_FILE

Passing --add-missing when rebuilding Makefile.in

: required file `./depcomp' not found Makefile.am: `automake --add-missing' can install `depcomp' make: *** [Makefile.in] Error 1 Would it be a problem if --add-missing was always passed to automake at this point? Cheers, -- Benoit Sigoure aka Tsuna EPITA Research and Development Laboratory

Re: Passing --add-missing when rebuilding Makefile.in

. /bin/sh /tmp/ac/missing --run automake-1.10 --foreign Makefile.am: required file `./depcomp' not found Makefile.am: `automake --add-missing' can install `depcomp' make: *** [Makefile.in] Error 1 Would it be a problem if --add-missing was always passed to automake at this point? It would

Re: --add-missing

Hello Eric, * Eric Polino wrote on Tue, Jul 24, 2007 at 06:00:44AM CEST: Here lies the problem. If I run toplevel/ag.sh it creates finch/libgnt/Makefile.in, as it always has and should. Within there it generates a variable called DIST_COMMON which doesn't reference the automake scripts

Re: --add-missing

On 7/24/07, Ralf Wildenhues [EMAIL PROTECTED] wrote: Hello Eric, * Eric Polino wrote on Tue, Jul 24, 2007 at 06:00:44AM CEST: Here lies the problem. If I run toplevel/ag.sh it creates finch/libgnt/Makefile.in, as it always has and should. Within there it generates a variable called

--add-missing

to allow libgnt to be build standalone. We are essentially trying to make the libgnt folder extractable to be its own package so that distros can install it by itself without installing Pidgin Some more info on the directories: toplevel/autogen.sh (calls 'automake --add-missing --copy') finch/libgnt

Re: --add-missing broken

Akim == Akim Demaille [EMAIL PROTECTED] writes: Ralf == Ralf Corsepius [EMAIL PROTECTED] writes: Ralf Related question: Which directory is am_dir/--am-dir supposed to Ralf point to, now? ../automake/ or ../automake/am? Akim Good question. No idea what Tom will prefer. AFAIC, a single Akim

Re: --add-missing broken

Ralf == Ralf Corsepius [EMAIL PROTECTED] writes: Ralf Hi, At present time, automake --add-missing is broken. Ralf Apparent cause is this patch below. Doh! Thanks! Weird that the test suite did not catch this. Ralf Related question: Which directory is am_dir/--am-dir supposed to Ralf point

Re: --Werror and --add-missing don't work toghether

"Pavel" == Pavel Roskin [EMAIL PROTECTED] writes: Pavel CVS Automake uses am_line_error() to inform the user that it's Pavel installing files. As a result, --Werror causes Automake to exit Pavel after it installs the first file: I submitted a PR about this in your name. Thanks. Tom

--Werror and --add-missing don't work toghether

Hello! CVS Automake uses am_line_error() to inform the user that it's installing files. As a result, --Werror causes Automake to exit after it installs the first file: $ automake --Werror --add-missing; echo $? automake: Makefile.am: installing `./INSTALL' 2 $ automake --Werror --add-missing

Re: [Fwd: --add-missing]

Tom Tromey wrote: I wouldn't be averse to adding a `pdf' target so that `make pdf' works as expected. Someone else would have to write it though since I don't know how. It should be the exact target used for DVI except for the addition of a '--pdf' switch to the texi2dvi command line. I'm

Re: [Fwd: --add-missing]

"Derek" == Derek R Price [EMAIL PROTECTED] writes: Me too. But the point is that GNU packages are supposed to ship with texinfo.tex. Derek Is there a web page somewhere with this standard on it? I Derek browsed briefly but I haven't been able to locate one. It is in the GNU Coding

[Fwd: --add-missing]

On Nov 13, 2000, "Derek R. Price" [EMAIL PROTECTED] wrote: Okay, is there some way short of symlinking the /usr/share/automake/texinfo.tex file by hand to make sure that automake --add-missing uses the "proper" texinfo.tex file (i.e. the one installed with the texinfo

--add-missing

Okay, is there some way short of symlinking the /usr/share/automake/texinfo.tex file by hand to make sure that automake --add-missing uses the "proper" texinfo.tex file (i.e. the one installed with the texinfo package and assumedly the most recent one)? Derek -- D

Re: automake --add-missing --copy

"Lars" == Lars J Aas [EMAIL PROTECTED] writes: Lars I've always been annoyed that automake --add-missing --copy Lars doesn't pass the "--copy"-option along to libtoolize, so I end Lars up with symlinked config.guess, config.sub, ltconfig and Lars ltmain.sh. Fixed. Lars

automake --add-missing --copy

Using: automake (GNU automake) 1.4a I've always been annoyed that automake --add-missing --copy doesn't pass the "--copy"-option along to libtoolize, so I end up with symlinked config.guess, config.sub, ltconfig and ltmain.sh. This might be fixed already, it's an "old" (mont