Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: > At 1247139117 time_t, Uli Schlachter wrote: >>> Where exactly is that endless loop? I can't seem to find it. And >>> frankly said, if you use looping tables for your widgets, you shouldn't >>> be surprised :P >> "You get what y

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Julien Danjou
At 1247137243 time_t, Gregor Best wrote: > But how would we then implement things like the flex layout or the > rightleft layout? Those two absolutely need to know the available space, > and IMHO it's the job of the widget layout to partition the available > space among the widgets it contains. Ye

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Julien Danjou
At 1247139117 time_t, Uli Schlachter wrote: > > Where exactly is that endless loop? I can't seem to find it. And > > frankly said, if you use looping tables for your widgets, you shouldn't > > be surprised :P > > "You get what you deserve".. ok, you win Clearly. Somehow I wonder if luaA_isloop()

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Gregor Best wrote: > On Thu, Jul 09, 2009 at 10:53:52AM +0200, Uli Schlachter wrote: > > Where exactly is that endless loop? I can't seem to find it. And > frankly said, if you use looping tables for your widgets, you shouldn't > be surprised :P "Y

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Gregor Best
On Thu, Jul 09, 2009 at 11:08:56AM +0200, Julien Danjou wrote: > At 1247096479 time_t, Gregor Best wrote: > > The layouts now > > use the "bounds" parameter only to determine the available width and > > height they can put their widgets into, the X and Y coordinates are > > modified by the calling

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Gregor Best
On Thu, Jul 09, 2009 at 10:53:52AM +0200, Uli Schlachter wrote: > [...] > Uhm... "I'll do" in the beginning of a commit message? Copy&paste is nice, but > don't forget grammar and context. :P > [...] In my defence: It was late at night :) > > [...] > > +-- we are only interested in tables and

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Julien Danjou
At 1247130536 time_t, Julien Danjou wrote: > > --- a/widgets/graph.c > > +++ b/widgets/graph.c > > @@ -148,13 +148,13 @@ graph_plot_get(graph_data_t *d, const char *title) > > } > > > > static area_t > > -graph_geometry(widget_t *widget, screen_t *screen, int height, int > > width) > > +graph_ge

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Julien Danjou
At 1247134192 time_t, Uli Schlachter wrote: > I guess the flex layout needs the bounds and since one can nest layouts, the > other ones have to keep that bounds table up-to-date, too... I guess Make sense. I take back what I said. It's fine finally. :) -- Julien Danjou // ᐰhttp://julien.danj

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: > At 1247096479 time_t, Gregor Best wrote: >> The layouts now >> use the "bounds" parameter only to determine the available width and >> height they can put their widgets into, the X and Y coordinates are >> modified by the calli

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Julien Danjou
At 1247096479 time_t, Gregor Best wrote: > The layouts now > use the "bounds" parameter only to determine the available width and > height they can put their widgets into, the X and Y coordinates are > modified by the calling functions. (A much cleaner approach, why didn't > I think of that? :) Do

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Gregor Best wrote: > Once again, I'm very thankful for every little bit of advice, so please > review :) > From a93c80d17c649446b2d80477db8b1dfa7cece886 Mon Sep 17 00:00:00 2001 > From: Gregor Best > Date: Fri, 29 May 2009 01:31:57 +0200 > Subject:

Re: [Draft] Introduction of Widget Layouts

2009-07-09 Thread Julien Danjou
At 1247090952 time_t, Gregor Best wrote: > It does, because it removes the calculation of the actual text position > from C. Without that, widget_geometries isn't fully functional, as text > doesn't get drawn where the layout function decides it should. Okay. > Premature optimization is the root