Re: Need help submitting menubar

2012-02-17 Thread Alexander Yakushev
Oh, and one more thing. On 02/17/2012 05:53 PM, Uli Schlachter wrote: +prompt.run({ prompt = "Run app: ", bg_cursor = "#22" }, instance.prompt.widget, function(s) end, + nil, awful.util.getdir("cache") .. "/history_menu", nil, hide, + menulist_update, +

Re: Need help submitting menubar

2012-02-17 Thread Alexander Yakushev
On 02/18/2012 12:03 AM, Uli Schlachter wrote: How about doing stuff the other way around: Instead of making a magic-pattern, you could run the client's name through string.lower(). That is an option, but then I need to run string.lower() on every application name I'm filtering through. Not that

Re: Need help submitting menubar

2012-02-17 Thread Uli Schlachter
On 17.02.2012 22:55, Alexander Yakushev wrote: > Thanks for the detailed review, Uli! > > I completely agree with nearly everything you noted. There are but a few > things that I don't quite understand. >> +-- Generate a pattern matching expression that ignores case. >> +-- @param s Original patt

Re: Need help submitting menubar

2012-02-17 Thread Alexander Yakushev
Thanks for the detailed review, Uli! I completely agree with nearly everything you noted. There are but a few things that I don't quite understand. +-- Generate a pattern matching expression that ignores case. +-- @param s Original pattern matching expresion. +local function nocase (s) +s =

Re: [patch] filter tables

2012-02-17 Thread Uli Schlachter
On 17.02.2012 16:44, Anurag Priyam wrote: > On Fri, Feb 17, 2012 at 8:52 PM, Uli Schlachter wrote: >> Thanks, both patches are merged. However, I had to mess with the commit >> messages >> (my git hooks refuse commits with a too long summary) and I added some luadoc >> for the new "s" argument. >

Re: Need help submitting menubar

2012-02-17 Thread Uli Schlachter
On 15.02.2012 23:22, Alexander Yakushev wrote: > OK, then here's the "first round". I've put the whole extension into the > separate lib/menubar directory and modified existing lib/awful/prompt.lua. > Things I changed inside prompt.lua: > - introduced two more arguments to run() function - change_

Re: [patch] filter tables

2012-02-17 Thread Anurag Priyam
On Fri, Feb 17, 2012 at 8:52 PM, Uli Schlachter wrote: > Thanks, both patches are merged. However, I had to mess with the commit > messages > (my git hooks refuse commits with a too long summary) and I added some luadoc > for the new "s" argument. Yeah, first one was 80 or 81 chars. Thanks for

Re: [patch] filter tables

2012-02-17 Thread Uli Schlachter
On 17.02.2012 16:11, Anurag Priyam wrote: > On Fri, Feb 17, 2012 at 8:04 PM, Uli Schlachter wrote: [...] Thanks, both patches are merged. However, I had to mess with the commit messages (my git hooks refuse commits with a too long summary) and I added some luadoc for the new "s" argument. Sadly,

Re: [patch] filter tables

2012-02-17 Thread Anurag Priyam
On Fri, Feb 17, 2012 at 8:47 PM, Anurag Priyam wrote: >>> Finally: What about indentation? >> >> Luadoc ignores it.  IIRC, only one code example in the entire doc uses >> indentation: awful.menu.new.  It is painfully difficult to add >> indentation; see 514fd796f3272583ee409b784fcd9ee2a6f95875 (on

Re: [patch] filter tables

2012-02-17 Thread Anurag Priyam
On Fri, Feb 17, 2012 at 8:41 PM, Anurag Priyam wrote: >> Also: Urgh, really have to add inside of code examples? :-( > > Yeah.  Otherwise all code comes up on the same line in the final HTML > out.  This is the most important reason for which I want to see > markdown in commit messages. I meant

Re: [patch] filter tables

2012-02-17 Thread Anurag Priyam
On Fri, Feb 17, 2012 at 8:04 PM, Uli Schlachter wrote: > I just noticed that this would bring us awful.util.cycle and > awful.util.table.cycle which do completely different things. How about > awful.util.table.iterate? Anyone has any good ideas? (I definitely don't) I want to keep the name cycle

Re: [patch] filter tables

2012-02-17 Thread Uli Schlachter
Hi, first patch: On 17.02.2012 15:14, Anurag Priyam wrote: [...] > +function table.cycle(t, filter, start) [...] > +index = cycle(#t, index + 1) [...] I just noticed that this would bring us awful.util.cycle and awful.util.table.cycle which do completely different things. How about a

Re: [patch] filter tables

2012-02-17 Thread Anurag Priyam
On Fri, Feb 17, 2012 at 4:50 PM, Uli Schlachter wrote: >> +function table.apply(t, filter, callback) >> +    for _, i in pairs(t) do >> +        if filter(i) and callback(i) == false then return end >> +    end >> +end > > Dunno how often something like that is needed. Only thing which I can think

Re: [patch] filter tables

2012-02-17 Thread Uli Schlachter
On 17.02.2012 00:39, Anurag Priyam wrote: > On Fri, Feb 17, 2012 at 4:01 AM, Anurag Priyam > wrote: > [...] >> However, most of the times starting to iterate from the currently >> focused client helps, so I can iterate through Chrome instances in >> order starting from the one focused. > > I sta

Re: [patch] filter tables

2012-02-17 Thread Uli Schlachter
On 16.02.2012 23:31, Anurag Priyam wrote: > It seems to be a common idiom to apply a particular operation on > select elements of a table. Something like: > > for _, i in pairs(t) do > if (func1(i)) then func2(i) end > end > > So, how about (first patch) : > > --- > lib/awful/u