Re: [PATCH + RFC] awful.doc reactivation

2009-09-03 Thread Julien Danjou
At 1251908089 time_t, koniu wrote: > Actually, looking at the extent of naughty dependency (and therefore a > necessity to do a lot of different callbacks) I'm leaning towards your > first suggestion which is splitting it out of awful and calling it > 'handy' instead (unless someone has a better na

Re: [PATCH + RFC] awful.doc reactivation

2009-09-02 Thread koniu
On Wed, Sep 2, 2009 at 16:39, Julien Danjou wrote: > At 1251904856 time_t, koniu wrote: >> There's incremental commits that will eventually be squashed. > Please do so if you think it reduce the review size. ;) I'll keep the increments for now, since it's easier for me to track progress and squash

Re: [PATCH + RFC] awful.doc reactivation

2009-09-02 Thread Julien Danjou
At 1251906585 time_t, koniu wrote: > Having said that, I will keep the attempt to retrieve descriptions > from functions in awful.key but these will be overridden by any > definitions made in awful.key.new(). At least people who haven't > migrated their configs to include descriptions will have _so

Re: [PATCH + RFC] awful.doc reactivation

2009-09-02 Thread koniu
Another little update on a previously discussed matter: 16:37 < koniu> lol i tried retrieving keybinding descriptions for the cheat-sheet from descriptions of functions they're bound to and it's unimpressive :) http://omploader.org/vMjlwNg 16:40 < koniu> too many inline functions in the default rc

Re: [PATCH + RFC] awful.doc reactivation

2009-09-02 Thread Julien Danjou
At 1251904856 time_t, koniu wrote: > There's incremental commits that will eventually be squashed. Please do so if you think it reduce the review size. ;) > On Wed, Sep 2, 2009 at 09:33, Julien Danjou wrote: > > At 1251821489 time_t, koniu wrote: > > >> this shortcut. I could try hack up duplica

Re: [PATCH + RFC] awful.doc reactivation

2009-09-02 Thread koniu
Pushed an updated version to: http://git.mercenariesguild.net/?p=awesome.git;a=shortlog;h=refs/heads/awful-doc There's incremental commits that will eventually be squashed. On Wed, Sep 2, 2009 at 09:33, Julien Danjou wrote: > At 1251821489 time_t, koniu wrote: >> this shortcut. I could try hack

Re: [PATCH + RFC] awful.doc reactivation

2009-09-02 Thread Julien Danjou
At 1251821489 time_t, koniu wrote: > Alternative solution is to catch these duplicates in > awful.help.format.kb_list(), perhaps under condition that the > modifiers might be different but keysym is the same + the > doc.description is the same. This would add yet another loop to > format.kb_list()

Re: [PATCH + RFC] awful.doc reactivation

2009-09-01 Thread koniu
On Tue, Sep 1, 2009 at 13:05, Julien Danjou wrote: > I've a couple of things to add: > - awful.{button,key}: you set description only on ret[1], which seems >  not right, all returned objects should have a description set. Ha, yes, I don't like this either - it's a hack. It allows avoiding duplic

Re: [PATCH + RFC] awful.doc reactivation

2009-09-01 Thread Julien Danjou
Hi koniu, At 1251749608 time_t, koniu wrote: > There's a couple of patches for awful.prompt but only the 'font' one > is related. Other ones are general improvments/fixes. Thanks for your work! > There's not much news in terms of functionality (it's been fairly > complete for months now) and now

[PATCH + RFC] awful.doc reactivation

2009-08-31 Thread koniu
Heyup. I finally got around to clean up my awful-doc branch a bit. Starting a new thread not to cause too much confusion. Original one is here: http://www.mail-archive.com/awesome-devel@naquadah.org/msg02191.html Current version of the branch is available here: http://git.mercenariesguild.net/?p=