Re: [patch] awful.menu: enable keyboard navigation by default

2012-03-01 Thread Uli Schlachter
On 01.03.2012 10:52, Anurag Priyam wrote: > On Wed, Feb 29, 2012 at 3:59 PM, Uli Schlachter wrote: >> On 26.02.2012 05:56, Anurag Priyam wrote: [...] >>> Optionally allowing keygrabbers adds to the complexity of the code. >>> And for what gains? Without keygrabber enabled, you can't even close >>

Re: [patch] awful.menu: enable keyboard navigation by default

2012-03-01 Thread Anurag Priyam
On Wed, Feb 29, 2012 at 3:59 PM, Uli Schlachter wrote: > On 26.02.2012 05:56, Anurag Priyam wrote: [...] >> Here is the correct patch, tested on both values (keygrabber = >> true/false) this time.  But before this patch is applied, we should >> perhaps consider removing keygrabber support from men

Re: [patch] awful.menu: enable keyboard navigation by default

2012-02-29 Thread Uli Schlachter
On 26.02.2012 05:56, Anurag Priyam wrote: > On Tue, Feb 21, 2012 at 10:45 PM, Anurag Priyam > wrote: >> On Tue, Feb 21, 2012 at 10:33 PM, Daniel Silverstone >> wrote: > [...] >>> local keygrabber = (args.keygrabber == nil) and true or args.keygrabber >>> >>> That might work better for you >> >> T

Re: [patch] awful.menu: enable keyboard navigation by default

2012-02-25 Thread Anurag Priyam
rag Priyam From 5f8412a6e80824e7b5401ce3e26452760871b7c9 Mon Sep 17 00:00:00 2001 From: Anurag Priyam Date: Tue, 21 Feb 2012 21:52:53 +0530 Subject: [PATCH] awful.menu: enable keyboard navigation by default Thanks to Daniel Silverstone for pointing out how to better deal with falsy paramete

Re: [patch] awful.menu: enable keyboard navigation by default

2012-02-21 Thread Anurag Priyam
On Tue, Feb 21, 2012 at 10:33 PM, Daniel Silverstone wrote: > On Tue, Feb 21, 2012 at 05:53:16PM +0100, Uli Schlachter wrote: >> > -    local keygrabber = args.keygrabber or false >> > +    local keygrabber = args.keygrabber or true >> >> Let's assume that args.keygrabber is false. Now we have: >>

Re: [patch] awful.menu: enable keyboard navigation by default

2012-02-21 Thread Daniel Silverstone
On Tue, Feb 21, 2012 at 05:53:16PM +0100, Uli Schlachter wrote: > > -local keygrabber = args.keygrabber or false > > +local keygrabber = args.keygrabber or true > > Let's assume that args.keygrabber is false. Now we have: > > local keygrabber = args.keygrabber or true > local keygrabber

Re: [patch] awful.menu: enable keyboard navigation by default

2012-02-21 Thread Uli Schlachter
On 21.02.2012 17:41, Anurag Priyam wrote: > diff --git a/lib/awful/menu.lua.in b/lib/awful/menu.lua.in > index 3e8566f..64f8ae8 100644 > --- a/lib/awful/menu.lua.in > +++ b/lib/awful/menu.lua.in > @@ -317,12 +317,13 @@ end > --- Show a menu. > -- @param menu The menu to show. > -- @param args.ke

[patch] awful.menu: enable keyboard navigation by default

2012-02-21 Thread Anurag Priyam
riyam Date: Tue, 21 Feb 2012 21:52:53 +0530 Subject: [PATCH] awful.menu: enable keyboard navigation by default Signed-off-by: Anurag Priyam --- awesomerc.lua.in |2 +- lib/awful/menu.lua.in |5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/awesomerc.lua