Changeset: b5726775b0d8
Author:katleman
Date: 2012-05-10 10:25 -0700
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b5726775b0d8
Added tag jdk8-b38 for changeset c45f3509a707
! .hgtags
Changeset: c2d9166f3284
Author:ihse
Date: 2012-05-11 08:21 -0700
URL: http://hg
Changeset: 3c394919ca69
Author:katleman
Date: 2012-05-10 10:25 -0700
URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3c394919ca69
Added tag jdk8-b38 for changeset 637c3f5f068f
! .hgtags
Changeset: 36538fd1225e
Author:amurillo
Date: 2012-05-04 15:26 -0700
URL: h
Changeset: a9f547c218d9
Author:katleman
Date: 2012-05-10 10:25 -0700
URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/a9f547c218d9
Added tag jdk8-b38 for changeset 1f224f160aa8
! .hgtags
Changeset: 8b869afd2eb4
Author:katleman
Date: 2012-05-17 06:20 -0700
URL:
Changeset: f95fdbe525c8
Author:katleman
Date: 2012-05-10 10:25 -0700
URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/f95fdbe525c8
Added tag jdk8-b38 for changeset 5bbe0cb6f2f2
! .hgtags
Changeset: 9ecfdbd6aed4
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: http
Changeset: 7f6b44fd3034
Author:katleman
Date: 2012-05-10 10:25 -0700
URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/7f6b44fd3034
Added tag jdk8-b38 for changeset ac1ba3b56775
! .hgtags
Changeset: 09a0ddda03cb
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: htt
Changeset: 785af00e2827
Author:katleman
Date: 2012-05-10 10:24 -0700
URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/785af00e2827
Added tag jdk8-b38 for changeset b8cbfb31139f
! .hgtags
Changeset: 56d030e5035f
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: htt
Changeset: b67bdaca36c2
Author:katleman
Date: 2012-05-10 10:24 -0700
URL: http://hg.openjdk.java.net/jdk8/awt/rev/b67bdaca36c2
Added tag jdk8-b38 for changeset d939bd0ab13c
! .hgtags
Changeset: 955a3e8ed4f0
Author:ohair
Date: 2012-05-10 08:26 -0700
URL: http://hg.op
Hi, Jonathan.
Fix looks good to me. Just note that one more reviewer needed.
Thanks for the fix.
24.05.2012 11:50, Jonathan Lu wrote:
Hello Sergey,
I made one automatic jtreg test case and put it to following link
along with the patch.
http://cr.openjdk.java.net/~luchsh/7170655_3/
Could you
On May 24, 2012, at 7:49 PM, Scott Kovatch wrote:
> OpenJDK (IMO) shouldn't rely on an icon in a framework that could disappear
> in the next year or two, so it should use its own icon. The AWT will need to
> change for that to happen. If Apple would like to donate this icon I think it
> would
Changeset: 4b2b963f8774
Author:ant
Date: 2012-05-25 20:57 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4b2b963f8774
7171776: one more setGlobalCurrentFocusCycleRoot call requires doPrivileged
Reviewed-by: art
! src/share/classes/java/awt/KeyboardFocusManager.java
Changeset: cd00d68e06ac
Author:neugens
Date: 2012-05-25 14:16 +0200
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cd00d68e06ac
6800513: GTK-LaF renders menus incompletely
Reviewed-by: rupashka
! src/share/classes/javax/swing/JPopupMenu.java
Hi David,
The fix looks fine to me. Is the empty line 281 OK in Makefiles? I'd
remove it just in case. Besides it would make it more clearer that the
SIZERS_CC commands are related to the SIZERS target.
--
best regards,
Anthony
On 5/25/2012 10:20 AM, David Holmes wrote:
This is a tweak to th
Thanks for the confirmation. The fix looks fine to me then.
--
best regards,
Anthony
On 5/25/2012 3:04 PM, Alexander Zuev wrote:
Anthony, I have checked it on Windows and Ubuntu - seems like there's no
regressions caused by this fix.
With best regards,
Alexander Zuev
25.05.2012, в 14:38, Ant
Hi Alexander,
I guess I'm a bit late with the review, but my comment also concerns the
fix for 7u6. You're changing the shared file
SunDropTargetContextPeer.java and reverting a boolean argument when
calling postDropTargetEvent. Can this change affect other platforms?
Have you run some tests
I've looked at what icon is used in OpenJDK for Windows and X11, and they both
use Duke icon. So, I guess, it makes sense for OS X to use Duke image as well.
On 25.05.2012, at 8:40, Phil Race wrote:
> We don't need Apple to donate an Icon .. we can simply provide one for
> OpenJDK (open) AND o
I need to do some research on this question... We should follow what
has been done before. It makes sense that we don't put Oracle branded
images in the OpenJDK distribution -- but I'm not exactly sure what we
have been putting in there up until now... If we need a "generic" icns
file for th
Thanks for commenting this for the next guy.
Nit pick:
// Despite the naming this method on MacOS only making one event from
// the native loop to be executed so this call is not blocking
Is not great English. How about "Despite the naming of this method, on
MacOS only one event is read and d
> That seems like overkill to me. Can't we just put the .icns in the JRE
> (Contents/Home/jre/lib/images) and load it from there? What are we guarding
> against by putting it into a .h file?
OpenJDK will use Oracle icons ? Even for the community version ?
The implementation matches how these methods are used by drag and drop
but the naming makes no sense. Who else calls these methods? I'm
assuming nobody (or that they are all called with the same
implementation in mind).
startNativeNestedEventLoop is really "read and dispatch an event without
ToolkitThreadBlockedHandler seems to be shared code and it follows the
enter / exit naming that is wrong. It seems that a lot of changes will
be needed in shared code so I'm not sure the renaming is worth it.
You could add update the comments to indicate how this is used and save
the renaming
Thanks so much for finding and fixing this critical issue.
Steve
On 24/05/2012 10:33 AM, Alexander Zuev wrote:
Steve,
i guess you are right and i gladly borrow your version of comment to
use.
This and two other typos caught by Scott Palmer leads us to the fourth
version of
the webrev which
> We don't want to use the Apple java icons. It doesn't have 'Oracle' or
> anything like that on it -- it's just the generic steaming coffee cup in
> orange and blue. In fact, I believe it is already in use as the bundle icon
> for the JDK.
Ok Scott.
Didn't see any icon (.icns) under Contents/
22 matches
Mail list logo
