[7u] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

Hello, Could you review a back-port of 7129133 to JDK 7u, please? The back-port and the main fix integrated into jdk8 are slightly different. bug: http://bugs.sun.com/view_bug.do?bug_id=7129133 webrev for jdk7u: http://cr.openjdk.java.net/~dmarkov/7129133/webrev.00/ jdk8 changeset: http://hg.o

hg: jdk8/awt/jdk: 7150100: [macosx] "0123456789" is selected in the TextField

Changeset: cdfa2301a291 Author:serb Date: 2013-10-01 04:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cdfa2301a291 7150100: [macosx] "0123456789" is selected in the TextField Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/solaris

hg: jdk8/awt/jdk: 8025652: [macos] build failed

Changeset: 603cd3cefbb0 Author:malenkov Date: 2013-09-30 22:08 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/603cd3cefbb0 8025652: [macos] build failed Reviewed-by: serb ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11GraphicsEnv

Re: [8] Review request for 8025652: [macos] build failed

The fix looks good. I assume that it was checked via jprt on win, lin and osx. On 30.09.2013 20:57, sergey malenkov wrote: Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/8025652.8.0/ bug:https://

[8] Review request for 8025652: [macos] build failed

Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/8025652.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8025652 This is a regression after the 7117595 fix. Thanks, SAM

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

The new version of the fix still looks fine. Thanks, Artem On 9/27/2013 2:13 PM, Sergey Bylokhov wrote: Hello. Please review the updated version of the fix for jdk 8. The same problem was found and fixed in xawt as well. http://cr.openjdk.java.net/~serb/7150100/webrev.01 On 09.04.2012 15:03,

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Hi All, Just a friendly reminder, I'm still waiting for review. Thanks, Mikhail. On 27.09.2013 19:32, mikhail cherkasov wrote: Anthony thank you for this link, it's good replacement for removed link. Also I didn't find replacement for : - * Also see the article href="http://java.sun.com/produ

[8] Review Request for 8025649: need test to cover JDK-8000423

Hello, Could you please review the fix for the following [TEST] bug: https://bugs.openjdk.java.net/browse/JDK-8025649 Webrev corresponding: http://cr.openjdk.java.net/~alexsch/alexander-stepanov/8025649/webrev.00/ Just a new test added; no other code affected. The patch contains a simple manual

Re: [8] Review request for 7092283 Property Window.locationByPlatform is not cleared by calling setVisible(false)

Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/7092283/webrev.02/ - synchronization on tree lock is used instead of the setter method - the readObject() method is not modified Thanks, Alexandr. On 9/27/2013 5:59 PM, Anthony Petrov wrote: On 09/27/2013 05

Re: [8] Review request 7059886: 6 JCK manual awt/Desktop tests fail with GTKLookAndFeel - GTK intialization issue

This version of the fix looks fine. Thanks, Artem On 9/27/2013 9:17 PM, Alexander Zvegintsev wrote: Anthony, please see inline: On 09/27/2013 06:25 PM, Anthony Petrov wrote: Hi Alexander, How about getAndSetInitializationNeededFlag ? 74 * If it returns {@code false} user must cal

Re: [8] Review Request: JDK-7124363 [macosx] ClassCastException: CFileDialog cannot be cast to LWWindowPeer

Hi. Petr. The fix looks good. On 30.09.2013 13:25, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-7124363 The fix is available at: http://cr.openjdk.java.net/~pchelko/7124363/webrev.00/ This is a direct forward port form JDK-7

[8] Review Request: JDK-7124363 [macosx] ClassCastException: CFileDialog cannot be cast to LWWindowPeer

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-7124363 The fix is available at: http://cr.openjdk.java.net/~pchelko/7124363/webrev.00/ This is a direct forward port form JDK-7. We do not need to set a fileDialog as a blocker, because it's natively

Re: [8] Review Request: JDK-8024163 [macosx] NullPointerException at javax.swing.TransferHandler$DropHandler.handleDrag since jdk8b93, 7u40b28

Hello. This is a reminder. Could I please get the second review on this? The bug: https://bugs.openjdk.java.net/browse/JDK-8024163 The fix: http://cr.openjdk.java.net/~pchelko/8024163/webrev.01 Thank you. With best regards. Petr. On Sep 25, 2013, at 3:05 PM, Petr Pchelko wrote: > Hello, AWT T