Re: AWT Dev RFR for JDK-8028711: TEST_BUG: Tests should pass through VM options: corelibs tests

2014-02-12 Thread michael cui
On 02/10/2014 05:36 PM, Alan Bateman wrote: A minor comment on test/java/net/URLPermission/nstest/lookup.sh is that the resulting line length is 182 characters and this will likely be annoying for future side-by-side views. So I think I'd split this while you are there. Please review the

Re: AWT Dev [9] Review request for 8031694: [macosx] TwentyThousandTest test intermittently hangs

2014-02-12 Thread Artem Ananiev
On 2/10/2014 9:17 PM, Anthony Petrov wrote: Thanks for the clarifications. Note that given that we re-create the EDT if there are more events in the queue, I'm still unsure whether we regress or not. I recall there was a patch submitted on this mailing list a few years ago that made the EDT die

Re: AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2014-02-12 Thread Alexander Scherbatiy
On 2/8/2014 4:19 AM, Jim Graham wrote: The primary thing that I was concerned about was the presence of integers in the API when Windows uses non-integer multiples It would make sense to pass real numbers to the getResolutionVariant() method if the difference between resolution variants

Re: AWT Dev RFR: Allow using a system installed libpng

2014-02-12 Thread Andrew Hughes
- Original Message - On 2014-02-10 18:43, Andrew Hughes wrote: You're already using it: PKG_CHECK_MODULES([LIBFFI], [libffi]) Why that's in LIB_SETUP_STATIC_LINK_LIBSTDCPP, I have no idea. Because libraries.m4 is in need of a long overdue cleanup. :-( * Second, I believe

Re: AWT Dev [9] Review request for 8031694: [macosx] TwentyThousandTest test intermittently hangs

2014-02-12 Thread Anthony Petrov
Oleg, Artem, thank you for the clarifications. I'm fine with the webrev version .2, too. -- best regards, Anthony On 2/12/2014 4:58 PM, Artem Ananiev wrote: On 2/10/2014 9:17 PM, Anthony Petrov wrote: Thanks for the clarifications. Note that given that we re-create the EDT if there are more

Re: AWT Dev RFR for JDK-8028711: TEST_BUG: Tests should pass through VM options: corelibs tests

2014-02-12 Thread Alan Bateman
On 12/02/2014 12:59, michael cui wrote: On 02/10/2014 05:36 PM, Alan Bateman wrote: A minor comment on test/java/net/URLPermission/nstest/lookup.sh is that the resulting line length is 182 characters and this will likely be annoying for future side-by-side views. So I think I'd split this

Re: AWT Dev RFR: Allow using a system installed libpng

2014-02-12 Thread Magnus Ihse Bursie
On 2014-02-12 18:47, Andrew Hughes wrote: To be extremely clear: Andrew, do you object to bringing Omairs patch, as it is, into OpenJDK? Yes. Okay then. I'll put a mental note to revisit libpng when cleaning up libraries.m4. Are we in agreement that it should to the following:

Re: AWT Dev RFR: Allow using a system installed libpng

2014-02-12 Thread Omair Majid
Hi, * Magnus Ihse Bursie magnus.ihse.bur...@oracle.com [2014-02-12 17:49]: On 2014-02-12 18:47, Andrew Hughes wrote: To be extremely clear: Andrew, do you object to bringing Omairs patch, as it is, into OpenJDK? Yes. Okay then. I'll put a mental note to revisit libpng when cleaning

Re: AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2014-02-12 Thread Jim Graham
On 2/12/14 5:59 AM, Alexander Scherbatiy wrote: On 2/8/2014 4:19 AM, Jim Graham wrote: The primary thing that I was concerned about was the presence of integers in the API when Windows uses non-integer multiples It would make sense to pass real numbers to the getResolutionVariant()

Re: AWT Dev RFR for JDK-8028711: TEST_BUG: Tests should pass through VM options: corelibs tests

2014-02-12 Thread michael cui
On 02/13/2014 02:35 AM, Alan Bateman wrote: The changes look okay to me. I see you decided to ignore the javac usages but that is okay and can be done another time. Also thanks for fixing lookup.sh. I don't personally mind lines 80 but that one was 180 which make it difficult to look at